linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] lib: memscan() fixlet
@ 2021-06-05 22:19 Alexey Dobriyan
  0 siblings, 0 replies; only message in thread
From: Alexey Dobriyan @ 2021-06-05 22:19 UTC (permalink / raw)
  To: akpm; +Cc: linux-kernel

Generic version doesn't trucate second argument to char.

Older brother memchr() does as do s390, sparc and i386 assembly
versions.

Fortunately, no code passes c >= 256.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 lib/string.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/lib/string.c
+++ b/lib/string.c
@@ -977,7 +977,7 @@ void *memscan(void *addr, int c, size_t size)
 	unsigned char *p = addr;
 
 	while (size) {
-		if (*p == c)
+		if (*p == (unsigned char)c)
 			return (void *)p;
 		p++;
 		size--;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-06-05 22:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-05 22:19 [PATCH] lib: memscan() fixlet Alexey Dobriyan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).