From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Hans Verkuil" <hans.verkuil@cisco.com>,
"Sebastian Reichel" <sre@kernel.org>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 2/2] media: v4l2-async: Make subdev notifier cleanup conditional
Date: Wed, 9 Jun 2021 15:01:16 +0200 [thread overview]
Message-ID: <YMC7nNOpy9MX8/2W@aptenodytes> (raw)
In-Reply-To: <20210609122735.GE3@paasikivi.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
Hi Sakari,
On Wed 09 Jun 21, 15:27, Sakari Ailus wrote:
> Hi Paul,
>
> On Wed, Jun 09, 2021 at 01:54:57PM +0200, Paul Kocialkowski wrote:
> > A dedicated subdev notified is registered when using the helper
> > dedicated to sensors (v4l2_async_register_subdev_sensor_common),
> > but this is not the case when a driver uses v4l2_async_register_subdev
> > directly.
>
> Is this a problem?
>
> The notifier unregistration and cleanup functions should be safe to call on
> a notifier that's not been initialised or registered. The same goes for
> kfree with NULL argument.
I think you're right, the functions and kfree are indeed safe.
I think I mixed things up with debugging an issue and assumed this was part
of the fix I needed.
Sorry for the noise!
Paul
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-06-09 13:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 11:54 [PATCH 1/2] media: v4l2-subdev: Fix documentation of the subdev_notifier member Paul Kocialkowski
2021-06-09 11:54 ` [PATCH 2/2] media: v4l2-async: Make subdev notifier cleanup conditional Paul Kocialkowski
2021-06-09 12:27 ` Sakari Ailus
2021-06-09 13:01 ` Paul Kocialkowski [this message]
2021-06-09 12:30 ` [PATCH 1/2] media: v4l2-subdev: Fix documentation of the subdev_notifier member Sakari Ailus
2021-06-09 13:03 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMC7nNOpy9MX8/2W@aptenodytes \
--to=paul.kocialkowski@bootlin.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=sakari.ailus@linux.intel.com \
--cc=sre@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).