From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Hans Verkuil" <hans.verkuil@cisco.com>,
"Sebastian Reichel" <sre@kernel.org>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 1/2] media: v4l2-subdev: Fix documentation of the subdev_notifier member
Date: Wed, 9 Jun 2021 15:03:02 +0200 [thread overview]
Message-ID: <YMC8BgVmcpAk3o3h@aptenodytes> (raw)
In-Reply-To: <20210609123003.GF3@paasikivi.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1422 bytes --]
Hi Sakari,
On Wed 09 Jun 21, 15:30, Sakari Ailus wrote:
> Hi Paul,
>
> On Wed, Jun 09, 2021 at 01:54:56PM +0200, Paul Kocialkowski wrote:
> > Fix the name of the function that registers the subdev_notifier member
> > of the v4l2_subdev structure.
> >
> > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> > ---
> > include/media/v4l2-subdev.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> > index d0e9a5bdb08b..f3b657dfe304 100644
> > --- a/include/media/v4l2-subdev.h
> > +++ b/include/media/v4l2-subdev.h
> > @@ -854,7 +854,7 @@ struct v4l2_subdev_platform_data {
> > * @asd: Pointer to respective &struct v4l2_async_subdev.
> > * @notifier: Pointer to the managing notifier.
> > * @subdev_notifier: A sub-device notifier implicitly registered for the sub-
> > - * device using v4l2_device_register_sensor_subdev().
> > + * device using v4l2_async_register_subdev_sensor_common().
>
> I agree in principle, but the function is nowadays called
> v4l2_async_register_subdev_sensor().
>
> I can fix this while applying.
Looks like I missed the rename when rebasing my patch on media/master!
Of course, feel free to update with the new name.
Thanks,
Paul
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-06-09 13:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 11:54 [PATCH 1/2] media: v4l2-subdev: Fix documentation of the subdev_notifier member Paul Kocialkowski
2021-06-09 11:54 ` [PATCH 2/2] media: v4l2-async: Make subdev notifier cleanup conditional Paul Kocialkowski
2021-06-09 12:27 ` Sakari Ailus
2021-06-09 13:01 ` Paul Kocialkowski
2021-06-09 12:30 ` [PATCH 1/2] media: v4l2-subdev: Fix documentation of the subdev_notifier member Sakari Ailus
2021-06-09 13:03 ` Paul Kocialkowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMC8BgVmcpAk3o3h@aptenodytes \
--to=paul.kocialkowski@bootlin.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=sakari.ailus@linux.intel.com \
--cc=sre@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).