* [PATCH 2/3] dmaengine: qcom: gpi: Add SM8250 compatible
2021-06-14 23:53 [PATCH 1/3] dt-bindings: dmaengine: qcom: gpi: add compatible for sm8250 Konrad Dybcio
@ 2021-06-14 23:53 ` Konrad Dybcio
2021-06-15 23:34 ` Bjorn Andersson
2021-06-14 23:53 ` [PATCH 3/3] arm64: dts: qcom: sm8250: Add GPI DMA nodes Konrad Dybcio
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Konrad Dybcio @ 2021-06-14 23:53 UTC (permalink / raw)
To: ~postmarketos/upstreaming
Cc: martin.botka, angelogioacchino.delregno, marijn.suijten,
jamipkettunen, Konrad Dybcio, Andy Gross, Bjorn Andersson,
Vinod Koul, Rob Herring, linux-arm-msm, dmaengine, devicetree,
linux-kernel
SM8250 seems to work just fine, so add a shiny new compatible for it.
Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
---
drivers/dma/qcom/gpi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
index 43ac3ab23d4c..1a1b7d8458c9 100644
--- a/drivers/dma/qcom/gpi.c
+++ b/drivers/dma/qcom/gpi.c
@@ -2282,6 +2282,7 @@ static int gpi_probe(struct platform_device *pdev)
static const struct of_device_id gpi_of_match[] = {
{ .compatible = "qcom,sdm845-gpi-dma" },
{ .compatible = "qcom,sm8150-gpi-dma" },
+ { .compatible = "qcom,sm8250-gpi-dma" },
{ },
};
MODULE_DEVICE_TABLE(of, gpi_of_match);
--
2.32.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] dmaengine: qcom: gpi: Add SM8250 compatible
2021-06-14 23:53 ` [PATCH 2/3] dmaengine: qcom: gpi: Add SM8250 compatible Konrad Dybcio
@ 2021-06-15 23:34 ` Bjorn Andersson
0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2021-06-15 23:34 UTC (permalink / raw)
To: Konrad Dybcio
Cc: ~postmarketos/upstreaming, martin.botka,
angelogioacchino.delregno, marijn.suijten, jamipkettunen,
Andy Gross, Vinod Koul, Rob Herring, linux-arm-msm, dmaengine,
devicetree, linux-kernel
On Mon 14 Jun 18:53 CDT 2021, Konrad Dybcio wrote:
> SM8250 seems to work just fine, so add a shiny new compatible for it.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
> drivers/dma/qcom/gpi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
> index 43ac3ab23d4c..1a1b7d8458c9 100644
> --- a/drivers/dma/qcom/gpi.c
> +++ b/drivers/dma/qcom/gpi.c
> @@ -2282,6 +2282,7 @@ static int gpi_probe(struct platform_device *pdev)
> static const struct of_device_id gpi_of_match[] = {
> { .compatible = "qcom,sdm845-gpi-dma" },
> { .compatible = "qcom,sm8150-gpi-dma" },
> + { .compatible = "qcom,sm8250-gpi-dma" },
> { },
> };
> MODULE_DEVICE_TABLE(of, gpi_of_match);
> --
> 2.32.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] arm64: dts: qcom: sm8250: Add GPI DMA nodes
2021-06-14 23:53 [PATCH 1/3] dt-bindings: dmaengine: qcom: gpi: add compatible for sm8250 Konrad Dybcio
2021-06-14 23:53 ` [PATCH 2/3] dmaengine: qcom: gpi: Add SM8250 compatible Konrad Dybcio
@ 2021-06-14 23:53 ` Konrad Dybcio
2021-06-15 23:34 ` [PATCH 1/3] dt-bindings: dmaengine: qcom: gpi: add compatible for sm8250 Bjorn Andersson
2021-06-16 10:36 ` Vinod Koul
3 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2021-06-14 23:53 UTC (permalink / raw)
To: ~postmarketos/upstreaming
Cc: martin.botka, angelogioacchino.delregno, marijn.suijten,
jamipkettunen, Konrad Dybcio, Andy Gross, Bjorn Andersson,
Vinod Koul, Rob Herring, linux-arm-msm, dmaengine, devicetree,
linux-kernel
Add and configure GPI DMA nodes to enable the way for peripherals to make
DMA transfers.
Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
---
arch/arm64/boot/dts/qcom/sm8250.dtsi | 64 ++++++++++++++++++++++++++++
1 file changed, 64 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index d45b6aa6fd05..e41d64c6ca56 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -8,6 +8,7 @@
#include <dt-bindings/clock/qcom,gcc-sm8250.h>
#include <dt-bindings/clock/qcom,gpucc-sm8250.h>
#include <dt-bindings/clock/qcom,rpmh.h>
+#include <dt-bindings/dma/qcom-gpi.h>
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interconnect/qcom,osm-l3.h>
#include <dt-bindings/interconnect/qcom,sm8250.h>
@@ -520,6 +521,26 @@ opp-120000000 {
};
};
+ gpi_dma2: dma-controller@800000 {
+ compatible = "qcom,sdm845-gpi-dma";
+ reg = <0 0x00800000 0 0x70000>;
+ interrupts = <GIC_SPI 588 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 589 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 590 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 591 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 592 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 593 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 594 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 595 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 596 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 597 IRQ_TYPE_LEVEL_HIGH>;
+ dma-channels = <10>;
+ dma-channel-mask = <0x3f>;
+ iommus = <&apps_smmu 0x76 0x0>;
+ #dma-cells = <3>;
+ status = "disabled";
+ };
+
qupv3_id_2: geniqup@8c0000 {
compatible = "qcom,geni-se-qup";
reg = <0x0 0x008c0000 0x0 0x6000>;
@@ -715,6 +736,29 @@ spi19: spi@894000 {
};
};
+ gpi_dma0: dma-controller@900000 {
+ compatible = "qcom,sdm845-gpi-dma";
+ reg = <0 0x00900000 0 0x70000>;
+ interrupts = <GIC_SPI 244 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 245 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 248 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 249 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 250 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 251 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 252 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 253 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 254 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 255 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>;
+ dma-channels = <15>;
+ dma-channel-mask = <0x7ff>;
+ iommus = <&apps_smmu 0x5b6 0x0>;
+ #dma-cells = <3>;
+ status = "disabled";
+ };
+
qupv3_id_0: geniqup@9c0000 {
compatible = "qcom,geni-se-qup";
reg = <0x0 0x009c0000 0x0 0x6000>;
@@ -962,6 +1006,26 @@ spi7: spi@99c000 {
};
};
+ gpi_dma1: dma-controller@a00000 {
+ compatible = "qcom,sdm845-gpi-dma";
+ reg = <0 0x00a00000 0 0x70000>;
+ interrupts = <GIC_SPI 279 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 280 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 281 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 282 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 283 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 284 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 293 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 294 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 295 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 296 IRQ_TYPE_LEVEL_HIGH>;
+ dma-channels = <10>;
+ dma-channel-mask = <0x3f>;
+ iommus = <&apps_smmu 0x56 0x0>;
+ #dma-cells = <3>;
+ status = "disabled";
+ };
+
qupv3_id_1: geniqup@ac0000 {
compatible = "qcom,geni-se-qup";
reg = <0x0 0x00ac0000 0x0 0x6000>;
--
2.32.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] dt-bindings: dmaengine: qcom: gpi: add compatible for sm8250
2021-06-14 23:53 [PATCH 1/3] dt-bindings: dmaengine: qcom: gpi: add compatible for sm8250 Konrad Dybcio
2021-06-14 23:53 ` [PATCH 2/3] dmaengine: qcom: gpi: Add SM8250 compatible Konrad Dybcio
2021-06-14 23:53 ` [PATCH 3/3] arm64: dts: qcom: sm8250: Add GPI DMA nodes Konrad Dybcio
@ 2021-06-15 23:34 ` Bjorn Andersson
2021-06-16 10:36 ` Vinod Koul
3 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2021-06-15 23:34 UTC (permalink / raw)
To: Konrad Dybcio
Cc: ~postmarketos/upstreaming, martin.botka,
angelogioacchino.delregno, marijn.suijten, jamipkettunen,
Andy Gross, Vinod Koul, Rob Herring, linux-arm-msm, dmaengine,
devicetree, linux-kernel
On Mon 14 Jun 18:53 CDT 2021, Konrad Dybcio wrote:
> No functional changes, just adding a new compatible for a different
> SoC.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
> Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> index e302147e53c6..e614fe3187bb 100644
> --- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> +++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> @@ -21,6 +21,7 @@ properties:
> enum:
> - qcom,sdm845-gpi-dma
> - qcom,sm8150-gpi-dma
> + - qcom,sm8250-gpi-dma
>
> reg:
> maxItems: 1
> --
> 2.32.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] dt-bindings: dmaengine: qcom: gpi: add compatible for sm8250
2021-06-14 23:53 [PATCH 1/3] dt-bindings: dmaengine: qcom: gpi: add compatible for sm8250 Konrad Dybcio
` (2 preceding siblings ...)
2021-06-15 23:34 ` [PATCH 1/3] dt-bindings: dmaengine: qcom: gpi: add compatible for sm8250 Bjorn Andersson
@ 2021-06-16 10:36 ` Vinod Koul
3 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2021-06-16 10:36 UTC (permalink / raw)
To: Konrad Dybcio
Cc: ~postmarketos/upstreaming, martin.botka,
angelogioacchino.delregno, marijn.suijten, jamipkettunen,
Andy Gross, Bjorn Andersson, Rob Herring, linux-arm-msm,
dmaengine, devicetree, linux-kernel
On 15-06-21, 01:53, Konrad Dybcio wrote:
> No functional changes, just adding a new compatible for a different
> SoC.
Applied 1 & 2, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread