* [PATCH] selftests: net: use bash to run udpgro_fwd test case
@ 2021-06-16 14:57 Andrea Righi
2021-06-16 20:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Andrea Righi @ 2021-06-16 14:57 UTC (permalink / raw)
To: Shuah Khan
Cc: David S. Miller, Jakub Kicinski, linux-kselftest, netdev, linux-kernel
udpgro_fwd.sh contains many bash specific operators ("[[", "local -r"),
but it's using /bin/sh; in some distro /bin/sh is mapped to /bin/dash,
that doesn't support such operators.
Force the test to use /bin/bash explicitly and prevent false positive
test failures.
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
---
tools/testing/selftests/net/udpgro_fwd.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/udpgro_fwd.sh b/tools/testing/selftests/net/udpgro_fwd.sh
index a8fa64136282..7f26591f236b 100755
--- a/tools/testing/selftests/net/udpgro_fwd.sh
+++ b/tools/testing/selftests/net/udpgro_fwd.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# SPDX-License-Identifier: GPL-2.0
readonly BASE="ns-$(mktemp -u XXXXXX)"
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests: net: use bash to run udpgro_fwd test case
2021-06-16 14:57 [PATCH] selftests: net: use bash to run udpgro_fwd test case Andrea Righi
@ 2021-06-16 20:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-16 20:00 UTC (permalink / raw)
To: Andrea Righi; +Cc: shuah, davem, kuba, linux-kselftest, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 16 Jun 2021 16:57:27 +0200 you wrote:
> udpgro_fwd.sh contains many bash specific operators ("[[", "local -r"),
> but it's using /bin/sh; in some distro /bin/sh is mapped to /bin/dash,
> that doesn't support such operators.
>
> Force the test to use /bin/bash explicitly and prevent false positive
> test failures.
>
> [...]
Here is the summary with links:
- selftests: net: use bash to run udpgro_fwd test case
https://git.kernel.org/netdev/net/c/1b29df0e2e80
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-16 20:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 14:57 [PATCH] selftests: net: use bash to run udpgro_fwd test case Andrea Righi
2021-06-16 20:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).