* [PATCH] sload.f2fs: Reword "IMMUTABLE" in strings/comments
@ 2021-06-11 7:31 Robin Hsu
2021-06-22 13:33 ` Pavel Machek
0 siblings, 1 reply; 3+ messages in thread
From: Robin Hsu @ 2021-06-11 7:31 UTC (permalink / raw)
To: linux-f2fs-devel, jaegeuk, chao; +Cc: linux-kernel, Robin Hsu
From: Robin Hsu <robinhsu@google.com>
Since the IMMUTABLE flag for compression is now changed
to F2FS_COMPRESS_RELEASED, some 'IMMUTABLE' words should be changed too:
1. sload help page
2. inline comments
Signed-off-by: Robin Hsu <robinhsu@google.com>
---
fsck/main.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fsck/main.c b/fsck/main.c
index c07be1e..c0b871b 100644
--- a/fsck/main.c
+++ b/fsck/main.c
@@ -149,7 +149,8 @@ void sload_usage()
MSG(0, " * -i or -x: use it many times for multiple extensions.\n");
MSG(0, " * -i and -x cannot be used together..\n");
MSG(0, " -m <num> min compressed blocks per cluster\n");
- MSG(0, " -r readonly (IMMUTABLE) for compressed files\n");
+ MSG(0, " -r read only (to release unused blocks) for compressed "
+ "files\n");
MSG(0, " ------------------------------------------------------\n");
MSG(0, " -d debug level [default:0]\n");
MSG(0, " -V print the version number and exit\n");
@@ -650,7 +651,7 @@ void f2fs_parse_options(int argc, char *argv[])
}
c.compress.min_blocks = val;
break;
- case 'r': /* compress file to set IMMUTABLE */
+ case 'r': /* for setting F2FS_COMOPRESS_RELEASE */
c.compress.required = true;
c.compress.readonly = true;
break;
--
2.32.0.272.g935e593368-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sload.f2fs: Reword "IMMUTABLE" in strings/comments
2021-06-11 7:31 [PATCH] sload.f2fs: Reword "IMMUTABLE" in strings/comments Robin Hsu
@ 2021-06-22 13:33 ` Pavel Machek
2021-06-22 15:10 ` Jaegeuk Kim
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Machek @ 2021-06-22 13:33 UTC (permalink / raw)
To: Robin Hsu; +Cc: linux-f2fs-devel, jaegeuk, chao, linux-kernel, Robin Hsu
Hi!
> Since the IMMUTABLE flag for compression is now changed
> to F2FS_COMPRESS_RELEASED, some 'IMMUTABLE' words should be changed too:
> 1. sload help page
> 2. inline comments
>
> Signed-off-by: Robin Hsu <robinhsu@google.com>
> @@ -650,7 +651,7 @@ void f2fs_parse_options(int argc, char *argv[])
> }
> c.compress.min_blocks = val;
> break;
> - case 'r': /* compress file to set IMMUTABLE */
> + case 'r': /* for setting F2FS_COMOPRESS_RELEASE */
Typo.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sload.f2fs: Reword "IMMUTABLE" in strings/comments
2021-06-22 13:33 ` Pavel Machek
@ 2021-06-22 15:10 ` Jaegeuk Kim
0 siblings, 0 replies; 3+ messages in thread
From: Jaegeuk Kim @ 2021-06-22 15:10 UTC (permalink / raw)
To: Pavel Machek; +Cc: Robin Hsu, linux-f2fs-devel, chao, linux-kernel, Robin Hsu
On 06/22, Pavel Machek wrote:
> Hi!
>
> > Since the IMMUTABLE flag for compression is now changed
> > to F2FS_COMPRESS_RELEASED, some 'IMMUTABLE' words should be changed too:
> > 1. sload help page
> > 2. inline comments
> >
> > Signed-off-by: Robin Hsu <robinhsu@google.com>
>
> > @@ -650,7 +651,7 @@ void f2fs_parse_options(int argc, char *argv[])
> > }
> > c.compress.min_blocks = val;
> > break;
> > - case 'r': /* compress file to set IMMUTABLE */
> > + case 'r': /* for setting F2FS_COMOPRESS_RELEASE */
>
> Typo.
Ah, fixed. Thank you~
>
> Best regards,
> Pavel
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-22 15:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-11 7:31 [PATCH] sload.f2fs: Reword "IMMUTABLE" in strings/comments Robin Hsu
2021-06-22 13:33 ` Pavel Machek
2021-06-22 15:10 ` Jaegeuk Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).