From: Heiko Carstens <hca@linux.ibm.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH 7/9] s390: kprobes: Use is_kernel() helper
Date: Mon, 28 Jun 2021 12:02:22 +0200 [thread overview]
Message-ID: <YNmeLhfWf3Rs6yRA@osiris> (raw)
In-Reply-To: <20210626073439.150586-8-wangkefeng.wang@huawei.com>
On Sat, Jun 26, 2021 at 03:34:37PM +0800, Kefeng Wang wrote:
> Use is_kernel() helper instead of is_kernel_addr().
>
> Cc: Heiko Carstens <hca@linux.ibm.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: linux-s390@vger.kernel.org
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> arch/s390/kernel/kprobes.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
...
> -static inline int is_kernel_addr(void *addr)
> -{
> - return addr < (void *)_end;
> -}
> -
> static int s390_get_insn_slot(struct kprobe *p)
> {
> /*
> @@ -105,7 +100,7 @@ static int s390_get_insn_slot(struct kprobe *p)
> * field can be patched and executed within the insn slot.
> */
> p->ainsn.insn = NULL;
> - if (is_kernel_addr(p->addr))
> + if (is_kernel(p->addr))
> p->ainsn.insn = get_s390_insn_slot();
> else if (is_module_addr(p->addr))
> p->ainsn.insn = get_insn_slot();
> @@ -117,7 +112,7 @@ static void s390_free_insn_slot(struct kprobe *p)
> {
> if (!p->ainsn.insn)
> return;
> - if (is_kernel_addr(p->addr))
> + if (is_kernel(p->addr))
> free_s390_insn_slot(p->ainsn.insn, 0);
> else
> free_insn_slot(p->ainsn.insn, 0);
Given that this makes sense its own, and I can't follow the discussion
of the patch series due to missing cc, I applied this to the s390 tree
- and also fixed up the missing unsigned long casts.
Thanks!
next prev parent reply other threads:[~2021-06-28 10:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-26 7:34 [PATCH 0/9] sections: Unify kernel sections range check and use Kefeng Wang
2021-06-26 7:34 ` [PATCH 1/9] kallsyms: Remove arch specific text and data check Kefeng Wang
2021-06-26 7:34 ` [PATCH 2/9] kallsyms: Fix address-checks for kernel related range Kefeng Wang
2021-07-05 3:35 ` Sergey Senozhatsky
2021-07-07 12:43 ` Petr Mladek
2021-06-26 7:34 ` [PATCH 3/9] sections: Move and rename core_kernel_data() to is_kernel_data() Kefeng Wang
2021-06-29 1:05 ` Steven Rostedt
2021-06-29 6:36 ` Kefeng Wang
2021-06-26 7:34 ` [PATCH 4/9] sections: Move is_kernel_inittext() into sections.h Kefeng Wang
2021-06-26 7:34 ` [PATCH 5/9] kallsyms: Rename is_kernel() and is_kernel_text() Kefeng Wang
2021-06-26 7:34 ` [PATCH 6/9] sections: Add new " Kefeng Wang
2021-06-26 7:34 ` [PATCH 7/9] s390: kprobes: Use is_kernel() helper Kefeng Wang
2021-06-28 10:02 ` Heiko Carstens [this message]
2021-06-28 11:09 ` Kefeng Wang
2021-06-26 7:34 ` [PATCH 8/9] powerpc/mm: Use is_kernel_text() and is_kernel_inittext() helper Kefeng Wang
2021-06-26 7:34 ` [PATCH 9/9] dma-debug: Use memory_intersects() directly Kefeng Wang
2021-06-28 6:11 ` Christoph Hellwig
2021-06-28 6:29 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNmeLhfWf3Rs6yRA@osiris \
--to=hca@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=borntraeger@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).