From: Greg KH <gregkh@linuxfoundation.org>
To: kan.liang@linux.intel.com
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
linux-kernel@vger.kernel.org, eranian@google.com,
namhyung@kernel.org, jolsa@redhat.com, ak@linux.intel.com,
yao.jin@linux.intel.com, stable@vger.kernel.org
Subject: Re: [PATCH V3 5/6] perf/x86/intel/uncore: Fix invalid unit check
Date: Wed, 30 Jun 2021 11:36:09 +0200 [thread overview]
Message-ID: <YNw7CT2sBE0l8aNf@kroah.com> (raw)
In-Reply-To: <1624990443-168533-6-git-send-email-kan.liang@linux.intel.com>
On Tue, Jun 29, 2021 at 11:14:02AM -0700, kan.liang@linux.intel.com wrote:
> From: Kan Liang <kan.liang@linux.intel.com>
>
> The uncore unit with the type ID 0 and the unit ID 0 is missed.
>
> The table3 of the uncore unit maybe 0. The
> uncore_discovery_invalid_unit() mistakenly treated it as an invalid
> value.
>
> Remove the !unit.table3 check.
>
> Fixes: edae1f06c2cd ("perf/x86/intel/uncore: Parse uncore discovery tables")
> Reviewed-by: Andi Kleen <ak@linux.intel.com>
> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
> Cc: stable@vger.kernel.org
> ---
> arch/x86/events/intel/uncore_discovery.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Why is a bugfix that needs to be backported patch 5 in the series?
Shouldn't that be totally independant and sent on its own and not part
of this series at all so that it can be accepted and merged much
quicker? It also should not depened on the previous 4 patches, right?
Andi, you know better than this...
greg k-h
next prev parent reply other threads:[~2021-06-30 9:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 18:13 [PATCH V3 0/6] perf: Add Sapphire Rapids server uncore support kan.liang
2021-06-29 18:13 ` [PATCH V3 1/6] perf/x86/intel/uncore: Add Sapphire Rapids server support kan.liang
2021-06-30 9:36 ` Greg KH
2021-06-30 12:56 ` Liang, Kan
2021-06-30 13:05 ` Greg KH
2021-06-30 9:39 ` Greg KH
2021-06-30 13:06 ` Liang, Kan
2021-06-29 18:13 ` [PATCH V3 2/6] perf/x86/intel/uncore: Add alias PMU name kan.liang
2021-06-30 9:39 ` Greg KH
2021-06-30 13:06 ` Liang, Kan
2021-06-29 18:14 ` [PATCH V3 3/6] perf/x86/intel/uncore: Factor out snr_uncore_mmio_map() kan.liang
2021-06-29 18:14 ` [PATCH V3 4/6] perf/x86/intel/uncore: Support free-running counters on Sapphire Rapids server kan.liang
2021-06-29 18:14 ` [PATCH V3 5/6] perf/x86/intel/uncore: Fix invalid unit check kan.liang
2021-06-30 9:36 ` Greg KH [this message]
2021-06-30 12:54 ` Liang, Kan
2021-06-29 18:14 ` [PATCH V3 6/6] perf pmu: Add PMU alias support kan.liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNw7CT2sBE0l8aNf@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).