* [printk:for-5.15-printk-index 4/8] drivers/media/usb/pvrusb2/pvrusb2-encoder.c:288 pvr2_encoder_cmd() warn: inconsistent indenting
@ 2021-07-25 1:52 kernel test robot
2021-07-25 11:43 ` Chris Down
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2021-07-25 1:52 UTC (permalink / raw)
To: Chris Down; +Cc: kbuild-all, linux-kernel, Petr Mladek
[-- Attachment #1: Type: text/plain, Size: 23453 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/printk/linux.git for-5.15-printk-index
head: 894d9c2e994946ffbd5401c2391f0a4ca6243a08
commit: 337015573718b161891a3473d25f59273f2e626b [4/8] printk: Userspace format indexing support
config: x86_64-randconfig-m001-20210724 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
smatch warnings:
drivers/media/usb/pvrusb2/pvrusb2-encoder.c:288 pvr2_encoder_cmd() warn: inconsistent indenting
drivers/media/usb/pvrusb2/pvrusb2-hdw.c:1730 pvr2_hdw_set_streaming() warn: inconsistent indenting
drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3461 pvr2_hdw_cpufw_set_enabled() warn: inconsistent indenting
drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3501 pvr2_hdw_cpufw_get() warn: inconsistent indenting
vim +288 drivers/media/usb/pvrusb2/pvrusb2-encoder.c
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 120
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 121
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 122 /* This prototype is set up to be compatible with the
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 123 cx2341x_mbox_func prototype in cx2341x.h, which should be in
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 124 kernels 2.6.18 or later. We do this so that we can enable
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 125 cx2341x.ko to write to our encoder (by handing it a pointer to this
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 126 function). For earlier kernels this doesn't really matter. */
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 127 static int pvr2_encoder_cmd(void *ctxt,
ea48c13ad0e562 drivers/media/video/pvrusb2/pvrusb2-encoder.c Hans Verkuil 2007-12-12 128 u32 cmd,
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 129 int arg_cnt_send,
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 130 int arg_cnt_recv,
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 131 u32 *argp)
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 132 {
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 133 unsigned int poll_count;
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 134 unsigned int try_count = 0;
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 135 int retry_flag;
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 136 int ret = 0;
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 137 unsigned int idx;
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 138 /* These sizes look to be limited by the FX2 firmware implementation */
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 139 u32 wrData[16];
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 140 u32 rdData[16];
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 141 struct pvr2_hdw *hdw = (struct pvr2_hdw *)ctxt;
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 142
c05c0462da0e3a drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 143
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 144 /*
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 145
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 146 The encoder seems to speak entirely using blocks 32 bit words.
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 147 In ivtv driver terms, this is a mailbox at MBOX_BASE which we
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 148 populate with data and watch what the hardware does with it.
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 149 The first word is a set of flags used to control the
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 150 transaction, the second word is the command to execute, the
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 151 third byte is zero (ivtv driver suggests that this is some
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 152 kind of return value), and the fourth byte is a specified
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 153 timeout (windows driver always uses 0x00060000 except for one
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 154 case when it is zero). All successive words are the argument
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 155 words for the command.
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 156
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 157 First, write out the entire set of words, with the first word
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 158 being zero.
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 159
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 160 Next, write out just the first word again, but set it to
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 161 IVTV_MBOX_DRIVER_DONE | IVTV_DRIVER_BUSY this time (which
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 162 probably means "go").
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 163
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 164 Next, read back the return count words. Check the first word,
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 165 which should have IVTV_MBOX_FIRMWARE_DONE set. If however
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 166 that bit is not set, then the command isn't done so repeat the
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 167 read until it is set.
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 168
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 169 Finally, write out just the first word again, but set it to
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 170 0x0 this time (which probably means "idle").
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 171
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 172 */
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 173
eca8ebfc11d193 drivers/media/video/pvrusb2/pvrusb2-encoder.c Ahmed S. Darwish 2007-01-20 174 if (arg_cnt_send > (ARRAY_SIZE(wrData) - 4)) {
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 175 pvr2_trace(
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 176 PVR2_TRACE_ERROR_LEGS,
96292c89cf1fa7 drivers/media/usb/pvrusb2/pvrusb2-encoder.c Mauro Carvalho Chehab 2016-10-18 177 "Failed to write cx23416 command - too many input arguments (was given %u limit %lu)",
69b04f0dc1c489 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mauro Carvalho Chehab 2007-01-21 178 arg_cnt_send, (long unsigned) ARRAY_SIZE(wrData) - 4);
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 179 return -EINVAL;
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 180 }
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 181
eca8ebfc11d193 drivers/media/video/pvrusb2/pvrusb2-encoder.c Ahmed S. Darwish 2007-01-20 182 if (arg_cnt_recv > (ARRAY_SIZE(rdData) - 4)) {
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 183 pvr2_trace(
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 184 PVR2_TRACE_ERROR_LEGS,
96292c89cf1fa7 drivers/media/usb/pvrusb2/pvrusb2-encoder.c Mauro Carvalho Chehab 2016-10-18 185 "Failed to write cx23416 command - too many return arguments (was given %u limit %lu)",
69b04f0dc1c489 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mauro Carvalho Chehab 2007-01-21 186 arg_cnt_recv, (long unsigned) ARRAY_SIZE(rdData) - 4);
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 187 return -EINVAL;
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 188 }
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 189
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 190
1ad371deb9b0be drivers/media/usb/pvrusb2/pvrusb2-encoder.c Mauro Carvalho Chehab 2017-06-26 191 LOCK_TAKE(hdw->ctl_lock); while (1) {
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 192
681c739944018d drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-11-26 193 if (!hdw->state_encoder_ok) {
9a607f01b044dd drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-10-14 194 ret = -EIO;
9a607f01b044dd drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-10-14 195 break;
9a607f01b044dd drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-10-14 196 }
9a607f01b044dd drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-10-14 197
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 198 retry_flag = 0;
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 199 try_count++;
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 200 ret = 0;
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 201 wrData[0] = 0;
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 202 wrData[1] = cmd;
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 203 wrData[2] = 0;
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 204 wrData[3] = 0x00060000;
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 205 for (idx = 0; idx < arg_cnt_send; idx++) {
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 206 wrData[idx+4] = argp[idx];
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 207 }
eca8ebfc11d193 drivers/media/video/pvrusb2/pvrusb2-encoder.c Ahmed S. Darwish 2007-01-20 208 for (; idx < ARRAY_SIZE(wrData) - 4; idx++) {
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 209 wrData[idx+4] = 0;
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 210 }
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 211
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 212 ret = pvr2_encoder_write_words(hdw,MBOX_BASE,wrData,idx);
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 213 if (ret) break;
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 214 wrData[0] = IVTV_MBOX_DRIVER_DONE|IVTV_MBOX_DRIVER_BUSY;
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 215 ret = pvr2_encoder_write_words(hdw,MBOX_BASE,wrData,1);
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 216 if (ret) break;
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 217 poll_count = 0;
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 218 while (1) {
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 219 poll_count++;
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 220 ret = pvr2_encoder_read_words(hdw,MBOX_BASE,rdData,
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 221 arg_cnt_recv+4);
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 222 if (ret) {
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 223 break;
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 224 }
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 225 if (rdData[0] & IVTV_MBOX_FIRMWARE_DONE) {
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 226 break;
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 227 }
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 228 if (rdData[0] && (poll_count < 1000)) continue;
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 229 if (!rdData[0]) {
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 230 retry_flag = !0;
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 231 pvr2_trace(
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 232 PVR2_TRACE_ERROR_LEGS,
96292c89cf1fa7 drivers/media/usb/pvrusb2/pvrusb2-encoder.c Mauro Carvalho Chehab 2016-10-18 233 "Encoder timed out waiting for us; arranging to retry");
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 234 } else {
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 235 pvr2_trace(
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 236 PVR2_TRACE_ERROR_LEGS,
96292c89cf1fa7 drivers/media/usb/pvrusb2/pvrusb2-encoder.c Mauro Carvalho Chehab 2016-10-18 237 "***WARNING*** device's encoder appears to be stuck (status=0x%08x)",
96292c89cf1fa7 drivers/media/usb/pvrusb2/pvrusb2-encoder.c Mauro Carvalho Chehab 2016-10-18 238 rdData[0]);
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 239 }
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 240 pvr2_trace(
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 241 PVR2_TRACE_ERROR_LEGS,
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 242 "Encoder command: 0x%02x",cmd);
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 243 for (idx = 4; idx < arg_cnt_send; idx++) {
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 244 pvr2_trace(
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 245 PVR2_TRACE_ERROR_LEGS,
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 246 "Encoder arg%d: 0x%08x",
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 247 idx-3,wrData[idx]);
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 248 }
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 249 ret = -EBUSY;
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 250 break;
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 251 }
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 252 if (retry_flag) {
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 253 if (try_count < 20) continue;
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 254 pvr2_trace(
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 255 PVR2_TRACE_ERROR_LEGS,
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 256 "Too many retries...");
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 257 ret = -EBUSY;
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 258 }
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 259 if (ret) {
d913d6303072ca drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2008-04-06 260 del_timer_sync(&hdw->encoder_run_timer);
681c739944018d drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-11-26 261 hdw->state_encoder_ok = 0;
681c739944018d drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-11-26 262 pvr2_trace(PVR2_TRACE_STBITS,
681c739944018d drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-11-26 263 "State bit %s <-- %s",
681c739944018d drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-11-26 264 "state_encoder_ok",
681c739944018d drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-11-26 265 (hdw->state_encoder_ok ? "true" : "false"));
d913d6303072ca drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2008-04-06 266 if (hdw->state_encoder_runok) {
d913d6303072ca drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2008-04-06 267 hdw->state_encoder_runok = 0;
d913d6303072ca drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2008-04-06 268 pvr2_trace(PVR2_TRACE_STBITS,
d913d6303072ca drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2008-04-06 269 "State bit %s <-- %s",
d913d6303072ca drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2008-04-06 270 "state_encoder_runok",
d913d6303072ca drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2008-04-06 271 (hdw->state_encoder_runok ?
d913d6303072ca drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2008-04-06 272 "true" : "false"));
d913d6303072ca drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2008-04-06 273 }
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 274 pvr2_trace(
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 275 PVR2_TRACE_ERROR_LEGS,
96292c89cf1fa7 drivers/media/usb/pvrusb2/pvrusb2-encoder.c Mauro Carvalho Chehab 2016-10-18 276 "Giving up on command. This is normally recovered via a firmware reload and re-initialization; concern is only warranted if this happens repeatedly and rapidly.");
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 277 break;
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 278 }
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 279 wrData[0] = 0x7;
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 280 for (idx = 0; idx < arg_cnt_recv; idx++) {
eacbe7c51f0fe7 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-25 281 argp[idx] = rdData[idx+4];
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 282 }
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 283
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 284 wrData[0] = 0x0;
c43000ef0c9f21 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2007-01-28 285 ret = pvr2_encoder_write_words(hdw,MBOX_BASE,wrData,1);
1ad371deb9b0be drivers/media/usb/pvrusb2/pvrusb2-encoder.c Mauro Carvalho Chehab 2017-06-26 286 break;
11c48e41d5fcc5 drivers/media/usb/pvrusb2/pvrusb2-encoder.c Ma Feng 2019-12-19 287 }
11c48e41d5fcc5 drivers/media/usb/pvrusb2/pvrusb2-encoder.c Ma Feng 2019-12-19 @288 LOCK_GIVE(hdw->ctl_lock);
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 289
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 290 return ret;
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 291 }
d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-encoder.c Mike Isely 2006-06-26 292
:::::: The code at line 288 was first introduced by commit
:::::: 11c48e41d5fcc5b4cf17aa74388be128ca5444f8 media: pvrusb2: Remove unneeded semicolon and add newline
:::::: TO: Ma Feng <mafeng.ma@huawei.com>
:::::: CC: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 40317 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [printk:for-5.15-printk-index 4/8] drivers/media/usb/pvrusb2/pvrusb2-encoder.c:288 pvr2_encoder_cmd() warn: inconsistent indenting
2021-07-25 1:52 [printk:for-5.15-printk-index 4/8] drivers/media/usb/pvrusb2/pvrusb2-encoder.c:288 pvr2_encoder_cmd() warn: inconsistent indenting kernel test robot
@ 2021-07-25 11:43 ` Chris Down
0 siblings, 0 replies; 2+ messages in thread
From: Chris Down @ 2021-07-25 11:43 UTC (permalink / raw)
To: Ma Feng; +Cc: kbuild-all, linux-kernel, Petr Mladek
Hey there,
kernel test robot writes:
>smatch warnings:
>drivers/media/usb/pvrusb2/pvrusb2-encoder.c:288 pvr2_encoder_cmd() warn: inconsistent indenting
>drivers/media/usb/pvrusb2/pvrusb2-hdw.c:1730 pvr2_hdw_set_streaming() warn: inconsistent indenting
>drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3461 pvr2_hdw_cpufw_set_enabled() warn: inconsistent indenting
>drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3501 pvr2_hdw_cpufw_get() warn: inconsistent indenting
>
>vim +288 drivers/media/usb/pvrusb2/pvrusb2-encoder.c
>
>[...]
>1ad371deb9b0be drivers/media/usb/pvrusb2/pvrusb2-encoder.c Mauro Carvalho Chehab 2017-06-26 191 LOCK_TAKE(hdw->ctl_lock); while (1) {
>[...]
>11c48e41d5fcc5 drivers/media/usb/pvrusb2/pvrusb2-encoder.c Ma Feng 2019-12-19 287 }
>11c48e41d5fcc5 drivers/media/usb/pvrusb2/pvrusb2-encoder.c Ma Feng 2019-12-19 @288 LOCK_GIVE(hdw->ctl_lock);
Ok, so it looks like it's complaining that LOCK_TAKE and LOCK_GIVE are somewhat
unbalanced in indenting. Which... they are. I don't really see what this has to
do with the printk indexing patchset.
I tried to reproduce myself, but spatch just segfaults when trying to read
drivers/media/usb/pvrusb2/pvrusb2-encoder.c under CHECK=, before _and_ after...
There is a pr_info user in here, pvr2_trace, which may be related, but honestly
I'm not seeing how the printk indexing patchset could materially change this,
and not having a repro is frustrating.
All of the reported places are just LOCK_GIVE, which is just a mutex unlock,
nothing to do with printk:
% sed -n 288p drivers/media/usb/pvrusb2/pvrusb2-encoder.c
LOCK_GIVE(hdw->ctl_lock);
% sed -n '1730p;3461p;3501p' drivers/media/usb/pvrusb2/pvrusb2-hdw.c
} while (0); LOCK_GIVE(hdw->big_lock);
} while (0); LOCK_GIVE(hdw->big_lock);
} while (0); LOCK_GIVE(hdw->big_lock);
...where...
#define LOCK_TAKE(x) do { mutex_lock(&x##_mutex); x##_held = !0; } while (0)
#define LOCK_GIVE(x) do { x##_held = 0; mutex_unlock(&x##_mutex); } while (0)
Ma Feng, looks like you were already cleaning this up, judging by 11c48e41d5
("media: pvrusb2: Remove unneeded semicolon and add newline"), maybe you have
some suggestions? I really don't see what it has to do with the printk indexing
patchset, although if I had a local repro it would help.
Thanks,
Chris
>:::::: The code at line 288 was first introduced by commit
>:::::: 11c48e41d5fcc5b4cf17aa74388be128ca5444f8 media: pvrusb2: Remove unneeded semicolon and add newline
>
>:::::: TO: Ma Feng <mafeng.ma@huawei.com>
>:::::: CC: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
>
>---
>0-DAY CI Kernel Test Service, Intel Corporation
>https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-25 11:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-25 1:52 [printk:for-5.15-printk-index 4/8] drivers/media/usb/pvrusb2/pvrusb2-encoder.c:288 pvr2_encoder_cmd() warn: inconsistent indenting kernel test robot
2021-07-25 11:43 ` Chris Down
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).