* [PATCH 1/2] ARM: configs: at91: sama5: Use make savedefconfig and clean leftovers
@ 2021-07-16 15:14 Tudor Ambarus
2021-07-16 15:14 ` [PATCH 2/2] ARM: configs: at91: Enable crypto software implementations Tudor Ambarus
2021-07-16 15:59 ` [PATCH 1/2] ARM: configs: at91: sama5: Use make savedefconfig and clean leftovers Alexandre Belloni
0 siblings, 2 replies; 4+ messages in thread
From: Tudor Ambarus @ 2021-07-16 15:14 UTC (permalink / raw)
To: nicolas.ferre, alexandre.belloni, ludovic.desroches
Cc: claudiu.beznea, eugen.hristev, codrin.ciubotariu, emil.velikov,
linux-arm-kernel, linux-kernel, Tudor Ambarus
Even since the addition CONFIG_VIDEO_HANTRO was set to n because
it did not respect the dependency chain. It doesn't respect it now
either, remove it.
Fixes: a0e6830c95b7 ("ARM: configs: at91: sama5: enable the Hantro G1 engine")
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
arch/arm/configs/sama5_defconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig
index 17db3b3e2dd3..1ccf84091dd7 100644
--- a/arch/arm/configs/sama5_defconfig
+++ b/arch/arm/configs/sama5_defconfig
@@ -207,7 +207,6 @@ CONFIG_AT_HDMAC=y
CONFIG_AT_XDMAC=y
CONFIG_STAGING=y
CONFIG_STAGING_MEDIA=y
-CONFIG_VIDEO_HANTRO=m
# CONFIG_IOMMU_SUPPORT is not set
CONFIG_IIO=y
CONFIG_AT91_ADC=y
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] ARM: configs: at91: Enable crypto software implementations
2021-07-16 15:14 [PATCH 1/2] ARM: configs: at91: sama5: Use make savedefconfig and clean leftovers Tudor Ambarus
@ 2021-07-16 15:14 ` Tudor Ambarus
2021-07-16 15:59 ` [PATCH 1/2] ARM: configs: at91: sama5: Use make savedefconfig and clean leftovers Alexandre Belloni
1 sibling, 0 replies; 4+ messages in thread
From: Tudor Ambarus @ 2021-07-16 15:14 UTC (permalink / raw)
To: nicolas.ferre, alexandre.belloni, ludovic.desroches
Cc: claudiu.beznea, eugen.hristev, codrin.ciubotariu, emil.velikov,
linux-arm-kernel, linux-kernel, Tudor Ambarus
It's a good idea to enable at least the same amount of algs as
the hardware IPs are supporting. Provide the posibility for the
hw accelerated crypto alg to fallback to software implementation,
in case they need it.
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
arch/arm/configs/at91_dt_defconfig | 8 +++++++-
arch/arm/configs/sama5_defconfig | 7 +++++++
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/arch/arm/configs/at91_dt_defconfig b/arch/arm/configs/at91_dt_defconfig
index 06c888a45eb3..d348ae0d5363 100644
--- a/arch/arm/configs/at91_dt_defconfig
+++ b/arch/arm/configs/at91_dt_defconfig
@@ -213,7 +213,13 @@ CONFIG_NLS_CODEPAGE_437=y
CONFIG_NLS_CODEPAGE_850=y
CONFIG_NLS_ISO8859_1=y
CONFIG_NLS_UTF8=y
-CONFIG_CRYPTO_ECB=y
+CONFIG_CRYPTO_CBC=y
+CONFIG_CRYPTO_CFB=y
+CONFIG_CRYPTO_OFB=y
+CONFIG_CRYPTO_XTS=y
+CONFIG_CRYPTO_SHA1=y
+CONFIG_CRYPTO_SHA512=y
+CONFIG_CRYPTO_DES=y
CONFIG_CRYPTO_USER_API_HASH=m
CONFIG_CRYPTO_USER_API_SKCIPHER=m
CONFIG_CRYPTO_DEV_ATMEL_AES=y
diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig
index 1ccf84091dd7..e170676eed66 100644
--- a/arch/arm/configs/sama5_defconfig
+++ b/arch/arm/configs/sama5_defconfig
@@ -230,6 +230,13 @@ CONFIG_NLS_CODEPAGE_437=y
CONFIG_NLS_CODEPAGE_850=y
CONFIG_NLS_ISO8859_1=y
CONFIG_NLS_UTF8=y
+CONFIG_CRYPTO_CBC=y
+CONFIG_CRYPTO_CFB=y
+CONFIG_CRYPTO_OFB=y
+CONFIG_CRYPTO_XTS=y
+CONFIG_CRYPTO_SHA1=y
+CONFIG_CRYPTO_SHA512=y
+CONFIG_CRYPTO_DES=y
CONFIG_CRYPTO_USER_API_HASH=m
CONFIG_CRYPTO_USER_API_SKCIPHER=m
CONFIG_CRYPTO_DEV_ATMEL_AES=y
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] ARM: configs: at91: sama5: Use make savedefconfig and clean leftovers
2021-07-16 15:14 [PATCH 1/2] ARM: configs: at91: sama5: Use make savedefconfig and clean leftovers Tudor Ambarus
2021-07-16 15:14 ` [PATCH 2/2] ARM: configs: at91: Enable crypto software implementations Tudor Ambarus
@ 2021-07-16 15:59 ` Alexandre Belloni
2021-07-16 16:15 ` Tudor.Ambarus
1 sibling, 1 reply; 4+ messages in thread
From: Alexandre Belloni @ 2021-07-16 15:59 UTC (permalink / raw)
To: Tudor Ambarus
Cc: nicolas.ferre, ludovic.desroches, claudiu.beznea, eugen.hristev,
codrin.ciubotariu, emil.velikov, linux-arm-kernel, linux-kernel
On 16/07/2021 18:14:46+0300, Tudor Ambarus wrote:
> Even since the addition CONFIG_VIDEO_HANTRO was set to n because
> it did not respect the dependency chain. It doesn't respect it now
> either, remove it.
>
Shouldn't you rather ensure it is enabled so we get it for sama5d4?
> Fixes: a0e6830c95b7 ("ARM: configs: at91: sama5: enable the Hantro G1 engine")
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
> arch/arm/configs/sama5_defconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig
> index 17db3b3e2dd3..1ccf84091dd7 100644
> --- a/arch/arm/configs/sama5_defconfig
> +++ b/arch/arm/configs/sama5_defconfig
> @@ -207,7 +207,6 @@ CONFIG_AT_HDMAC=y
> CONFIG_AT_XDMAC=y
> CONFIG_STAGING=y
> CONFIG_STAGING_MEDIA=y
> -CONFIG_VIDEO_HANTRO=m
> # CONFIG_IOMMU_SUPPORT is not set
> CONFIG_IIO=y
> CONFIG_AT91_ADC=y
> --
> 2.25.1
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] ARM: configs: at91: sama5: Use make savedefconfig and clean leftovers
2021-07-16 15:59 ` [PATCH 1/2] ARM: configs: at91: sama5: Use make savedefconfig and clean leftovers Alexandre Belloni
@ 2021-07-16 16:15 ` Tudor.Ambarus
0 siblings, 0 replies; 4+ messages in thread
From: Tudor.Ambarus @ 2021-07-16 16:15 UTC (permalink / raw)
To: alexandre.belloni, emil.velikov
Cc: Nicolas.Ferre, Ludovic.Desroches, Claudiu.Beznea, Eugen.Hristev,
Codrin.Ciubotariu, linux-arm-kernel, linux-kernel
On 7/16/21 6:59 PM, Alexandre Belloni wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 16/07/2021 18:14:46+0300, Tudor Ambarus wrote:
>> Even since the addition CONFIG_VIDEO_HANTRO was set to n because
>> it did not respect the dependency chain. It doesn't respect it now
>> either, remove it.
>>
>
> Shouldn't you rather ensure it is enabled so we get it for sama5d4?
CONFIG_VIDEO_HANTRO has the following dependency chain:
Depends on: STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && (ARCH_MXC [=n] || ARCH_ROCKCHIP [=n] || COMPILE_TEST [=n]) && VIDEO_DEV [=y] && VIDEO_V4L2 [=y]
Maybe a better fix is to add ARCH_AT91 in the list of supported archs.
Emil, can you shed some light on this?
>
>> Fixes: a0e6830c95b7 ("ARM: configs: at91: sama5: enable the Hantro G1 engine")
>> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>> ---
>> arch/arm/configs/sama5_defconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig
>> index 17db3b3e2dd3..1ccf84091dd7 100644
>> --- a/arch/arm/configs/sama5_defconfig
>> +++ b/arch/arm/configs/sama5_defconfig
>> @@ -207,7 +207,6 @@ CONFIG_AT_HDMAC=y
>> CONFIG_AT_XDMAC=y
>> CONFIG_STAGING=y
>> CONFIG_STAGING_MEDIA=y
>> -CONFIG_VIDEO_HANTRO=m
>> # CONFIG_IOMMU_SUPPORT is not set
>> CONFIG_IIO=y
>> CONFIG_AT91_ADC=y
>> --
>> 2.25.1
>>
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-16 16:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-16 15:14 [PATCH 1/2] ARM: configs: at91: sama5: Use make savedefconfig and clean leftovers Tudor Ambarus
2021-07-16 15:14 ` [PATCH 2/2] ARM: configs: at91: Enable crypto software implementations Tudor Ambarus
2021-07-16 15:59 ` [PATCH 1/2] ARM: configs: at91: sama5: Use make savedefconfig and clean leftovers Alexandre Belloni
2021-07-16 16:15 ` Tudor.Ambarus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).