From: Greg KH <gregkh@linuxfoundation.org>
To: Ojaswin Mujoo <ojaswin98@gmail.com>
Cc: nsaenz@kernel.org, stefan.wahren@i2se.com,
dan.carpenter@oracle.com, phil@raspberrypi.com,
linux-arm-kernel@lists.infradead.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/5] staging: vchiq: Make creation of vchiq cdev optional
Date: Tue, 27 Jul 2021 15:25:01 +0200 [thread overview]
Message-ID: <YQAJLao8H1Hl5VVf@kroah.com> (raw)
In-Reply-To: <846c424dd4aae14d1cc28c8f30877a06e2b7dd10.1626882325.git.ojaswin98@gmail.com>
On Wed, Jul 21, 2021 at 09:50:52PM +0530, Ojaswin Mujoo wrote:
> Before this commit, vchiq cdev (/dev/vchiq) was always created during
> platform initialization. Introduce a new Kconfig option
> CONFIG_VCHIQ_CDEV which determines if the cdev will be created or not.
>
> Signed-off-by: Ojaswin Mujoo <ojaswin98@gmail.com>
> ---
> drivers/staging/vc04_services/Kconfig | 10 ++++++++++
> drivers/staging/vc04_services/Makefile | 5 ++++-
> .../vc04_services/interface/vchiq_arm/vchiq_arm.h | 9 +++++++++
> 3 files changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vc04_services/Kconfig b/drivers/staging/vc04_services/Kconfig
> index 4b886293f198..63caa6818d37 100644
> --- a/drivers/staging/vc04_services/Kconfig
> +++ b/drivers/staging/vc04_services/Kconfig
> @@ -19,6 +19,16 @@ config BCM2835_VCHIQ
> Defaults to Y when the Broadcom Videocore services
> are included in the build, N otherwise.
>
> +if BCM2835_VCHIQ
> +
> +config VCHIQ_CDEV
> + bool "VCHIQ Character Driver"
> + help
> + Enable the creation of VCHIQ character driver to help
> + communicate with the Videocore platform.
I'll take this, but this really should say more about what this really
is for. Who needs this? Why will I know if I want a character driver
interface? What tools talk to this?
Or conversely, why would I want to turn this off?
Can you send a follow-on patch that makes this more descriptive?
thanks,
greg k-h
next prev parent reply other threads:[~2021-07-27 13:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 16:20 [PATCH v4 0/5] vchiq: Patch to separate platform and cdev code Ojaswin Mujoo
2021-07-21 16:20 ` [PATCH v4 1/5] staging: vchiq: Refactor vchiq " Ojaswin Mujoo
2021-07-21 16:20 ` [PATCH v4 2/5] staging: vchiq: Move certain declarations to vchiq_arm.h Ojaswin Mujoo
2021-07-21 16:20 ` [PATCH v4 3/5] staging: vchiq: Move vchiq char driver to its own file Ojaswin Mujoo
2021-07-21 16:20 ` [PATCH v4 4/5] staging: vchiq: Make creation of vchiq cdev optional Ojaswin Mujoo
2021-07-27 13:25 ` Greg KH [this message]
2021-07-27 16:55 ` Ojaswin Mujoo
2021-07-21 16:20 ` [PATCH v4 5/5] staging: vchiq: Combine vchiq platform code into single file Ojaswin Mujoo
2021-07-23 11:02 ` [PATCH v4 0/5] vchiq: Patch to separate platform and cdev code Greg KH
2021-07-23 12:59 ` Ojaswin Mujoo
2021-07-23 13:31 ` Stefan Wahren
2021-07-24 10:44 ` Ojaswin Mujoo
2021-07-24 9:38 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQAJLao8H1Hl5VVf@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nsaenz@kernel.org \
--cc=ojaswin98@gmail.com \
--cc=phil@raspberrypi.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).