linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH rdma-next] docs: Fix infiniband uverbs minor number
@ 2021-07-22  6:45 Leon Romanovsky
  2021-07-23 13:52 ` Leon Romanovsky
  0 siblings, 1 reply; 5+ messages in thread
From: Leon Romanovsky @ 2021-07-22  6:45 UTC (permalink / raw)
  To: Doug Ledford, Jason Gunthorpe
  Cc: Leon Romanovsky, Jonathan Corbet, linux-doc, linux-kernel,
	Mauro Carvalho Chehab

From: Leon Romanovsky <leonro@nvidia.com>

Starting from the introduction of infiniband subsystem, the uverbs
char devices started from 192 as a minor number, see 
commit bc38a6abdd5a ("[PATCH] IB uverbs: core implementation"), but
the documentation was slightly different.

This patch updates the admin guide documentation to reflect it.

Fixes: 9d85025b0418 ("docs-rst: create an user's manual book")
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
 Documentation/admin-guide/devices.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/admin-guide/devices.txt b/Documentation/admin-guide/devices.txt
index 9c2be821c225..922c23bb4372 100644
--- a/Documentation/admin-guide/devices.txt
+++ b/Documentation/admin-guide/devices.txt
@@ -2993,10 +2993,10 @@
 		65 = /dev/infiniband/issm1     Second InfiniBand IsSM device
 		  ...
 		127 = /dev/infiniband/issm63    63rd InfiniBand IsSM device
-		128 = /dev/infiniband/uverbs0   First InfiniBand verbs device
-		129 = /dev/infiniband/uverbs1   Second InfiniBand verbs device
+		192 = /dev/infiniband/uverbs0   First InfiniBand verbs device
+		193 = /dev/infiniband/uverbs1   Second InfiniBand verbs device
 		  ...
-		159 = /dev/infiniband/uverbs31  31st InfiniBand verbs device
+		223 = /dev/infiniband/uverbs31  31st InfiniBand verbs device
 
  232 char	Biometric Devices
 		0 = /dev/biometric/sensor0/fingerprint	first fingerprint sensor on first device
-- 
2.31.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH rdma-next] docs: Fix infiniband uverbs minor number
  2021-07-22  6:45 [PATCH rdma-next] docs: Fix infiniband uverbs minor number Leon Romanovsky
@ 2021-07-23 13:52 ` Leon Romanovsky
  2021-07-28 11:53   ` Leon Romanovsky
  0 siblings, 1 reply; 5+ messages in thread
From: Leon Romanovsky @ 2021-07-23 13:52 UTC (permalink / raw)
  To: Doug Ledford, Jason Gunthorpe
  Cc: Jonathan Corbet, linux-doc, linux-kernel, Mauro Carvalho Chehab,
	RDMA mailing list

+ RDMA

On Thu, Jul 22, 2021 at 09:45:07AM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
> 
> Starting from the introduction of infiniband subsystem, the uverbs
> char devices started from 192 as a minor number, see 
> commit bc38a6abdd5a ("[PATCH] IB uverbs: core implementation"), but
> the documentation was slightly different.
> 
> This patch updates the admin guide documentation to reflect it.
> 
> Fixes: 9d85025b0418 ("docs-rst: create an user's manual book")
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
>  Documentation/admin-guide/devices.txt | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/admin-guide/devices.txt b/Documentation/admin-guide/devices.txt
> index 9c2be821c225..922c23bb4372 100644
> --- a/Documentation/admin-guide/devices.txt
> +++ b/Documentation/admin-guide/devices.txt
> @@ -2993,10 +2993,10 @@
>  		65 = /dev/infiniband/issm1     Second InfiniBand IsSM device
>  		  ...
>  		127 = /dev/infiniband/issm63    63rd InfiniBand IsSM device
> -		128 = /dev/infiniband/uverbs0   First InfiniBand verbs device
> -		129 = /dev/infiniband/uverbs1   Second InfiniBand verbs device
> +		192 = /dev/infiniband/uverbs0   First InfiniBand verbs device
> +		193 = /dev/infiniband/uverbs1   Second InfiniBand verbs device
>  		  ...
> -		159 = /dev/infiniband/uverbs31  31st InfiniBand verbs device
> +		223 = /dev/infiniband/uverbs31  31st InfiniBand verbs device
>  
>   232 char	Biometric Devices
>  		0 = /dev/biometric/sensor0/fingerprint	first fingerprint sensor on first device
> -- 
> 2.31.1
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH rdma-next] docs: Fix infiniband uverbs minor number
  2021-07-23 13:52 ` Leon Romanovsky
@ 2021-07-28 11:53   ` Leon Romanovsky
  2021-07-28 11:59     ` Jason Gunthorpe
  0 siblings, 1 reply; 5+ messages in thread
From: Leon Romanovsky @ 2021-07-28 11:53 UTC (permalink / raw)
  To: Doug Ledford, Jason Gunthorpe
  Cc: Jonathan Corbet, linux-doc, linux-kernel, Mauro Carvalho Chehab,
	RDMA mailing list

Jason ????

On Fri, Jul 23, 2021 at 04:52:34PM +0300, Leon Romanovsky wrote:
> + RDMA
> 
> On Thu, Jul 22, 2021 at 09:45:07AM +0300, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@nvidia.com>
> > 
> > Starting from the introduction of infiniband subsystem, the uverbs
> > char devices started from 192 as a minor number, see 
> > commit bc38a6abdd5a ("[PATCH] IB uverbs: core implementation"), but
> > the documentation was slightly different.
> > 
> > This patch updates the admin guide documentation to reflect it.
> > 
> > Fixes: 9d85025b0418 ("docs-rst: create an user's manual book")
> > Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> > ---
> >  Documentation/admin-guide/devices.txt | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/admin-guide/devices.txt b/Documentation/admin-guide/devices.txt
> > index 9c2be821c225..922c23bb4372 100644
> > --- a/Documentation/admin-guide/devices.txt
> > +++ b/Documentation/admin-guide/devices.txt
> > @@ -2993,10 +2993,10 @@
> >  		65 = /dev/infiniband/issm1     Second InfiniBand IsSM device
> >  		  ...
> >  		127 = /dev/infiniband/issm63    63rd InfiniBand IsSM device
> > -		128 = /dev/infiniband/uverbs0   First InfiniBand verbs device
> > -		129 = /dev/infiniband/uverbs1   Second InfiniBand verbs device
> > +		192 = /dev/infiniband/uverbs0   First InfiniBand verbs device
> > +		193 = /dev/infiniband/uverbs1   Second InfiniBand verbs device
> >  		  ...
> > -		159 = /dev/infiniband/uverbs31  31st InfiniBand verbs device
> > +		223 = /dev/infiniband/uverbs31  31st InfiniBand verbs device
> >  
> >   232 char	Biometric Devices
> >  		0 = /dev/biometric/sensor0/fingerprint	first fingerprint sensor on first device
> > -- 
> > 2.31.1
> > 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH rdma-next] docs: Fix infiniband uverbs minor number
  2021-07-28 11:53   ` Leon Romanovsky
@ 2021-07-28 11:59     ` Jason Gunthorpe
  2021-07-28 13:05       ` Leon Romanovsky
  0 siblings, 1 reply; 5+ messages in thread
From: Jason Gunthorpe @ 2021-07-28 11:59 UTC (permalink / raw)
  To: Leon Romanovsky
  Cc: Doug Ledford, Jonathan Corbet, linux-doc, linux-kernel,
	Mauro Carvalho Chehab, RDMA mailing list

On Wed, Jul 28, 2021 at 02:53:10PM +0300, Leon Romanovsky wrote:
> Jason ????

I don't know what happened here, but it is not in patchworks

The patch looks fine unless there are remarks from the docs people -
please get it in patchworks

Jason

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH rdma-next] docs: Fix infiniband uverbs minor number
  2021-07-28 11:59     ` Jason Gunthorpe
@ 2021-07-28 13:05       ` Leon Romanovsky
  0 siblings, 0 replies; 5+ messages in thread
From: Leon Romanovsky @ 2021-07-28 13:05 UTC (permalink / raw)
  To: Jason Gunthorpe
  Cc: Doug Ledford, Jonathan Corbet, linux-doc, linux-kernel,
	Mauro Carvalho Chehab, RDMA mailing list

On Wed, Jul 28, 2021 at 08:59:33AM -0300, Jason Gunthorpe wrote:
> On Wed, Jul 28, 2021 at 02:53:10PM +0300, Leon Romanovsky wrote:
> > Jason ????
> 
> I don't know what happened here, but it is not in patchworks
> 
> The patch looks fine unless there are remarks from the docs people -
> please get it in patchworks

Done,
https://patchwork.kernel.org/project/linux-rdma/patch/bad03e6bcde45550c01e12908a6fe7dfa4770703.1627477347.git.leonro@nvidia.com/

> 
> Jason

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-07-28 13:05 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-22  6:45 [PATCH rdma-next] docs: Fix infiniband uverbs minor number Leon Romanovsky
2021-07-23 13:52 ` Leon Romanovsky
2021-07-28 11:53   ` Leon Romanovsky
2021-07-28 11:59     ` Jason Gunthorpe
2021-07-28 13:05       ` Leon Romanovsky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).