From: Greg KH <gregkh@linuxfoundation.org>
To: Xianting Tian <xianting.tian@linux.alibaba.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
amit@kernel.org, arnd@arndb.de, osandov@fb.com,
linuxppc-dev@lists.ozlabs.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] tty: hvc: pass DMA capable memory to put_chars()
Date: Thu, 5 Aug 2021 10:18:38 +0200 [thread overview]
Message-ID: <YQue3tK98e6fAqwP@kroah.com> (raw)
In-Reply-To: <40f78d10-0a57-4620-e7e2-f806bd61abca@linux.alibaba.com>
On Thu, Aug 05, 2021 at 04:08:46PM +0800, Xianting Tian wrote:
>
> 在 2021/8/5 下午3:58, Jiri Slaby 写道:
> > Hi,
> >
> > On 04. 08. 21, 4:54, Xianting Tian wrote:
> > > @@ -933,6 +949,16 @@ struct hvc_struct *hvc_alloc(uint32_t vtermno,
> > > int data,
> > > hp->outbuf_size = outbuf_size;
> > > hp->outbuf = &((char *)hp)[ALIGN(sizeof(*hp), sizeof(long))];
> > > + /*
> > > + * hvc_con_outbuf is guaranteed to be aligned at least to the
> > > + * size(N_OUTBUF) by kmalloc().
> > > + */
> > > + hp->hvc_con_outbuf = kzalloc(N_OUTBUF, GFP_KERNEL);
> > > + if (!hp->hvc_con_outbuf)
> > > + return ERR_PTR(-ENOMEM);
> >
> > This leaks hp, right?
> >
> > BTW your 2 patches are still not threaded, that is hard to follow.
>
> yes, thanks, I found the bug, I am preparing to do this in v4.
>
> It is the first time I send series patches(number >1), I checked the method
> for sending series patch on LKML.org, I should send '0/2' which is the
> history info for series patches.
Please use 'git send-email' to send the full series all at once,
otherwise it is hard to make the emails threaded "by hand" if you do not
do so.
thanks,
greg k-h
next prev parent reply other threads:[~2021-08-05 8:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 2:54 [PATCH v3 1/2] tty: hvc: pass DMA capable memory to put_chars() Xianting Tian
2021-08-05 7:58 ` Jiri Slaby
2021-08-05 8:09 ` Jiri Slaby
2021-08-05 11:14 ` Xianting Tian
[not found] ` <40f78d10-0a57-4620-e7e2-f806bd61abca@linux.alibaba.com>
2021-08-05 8:18 ` Greg KH [this message]
2021-08-05 8:23 ` Xianting Tian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQue3tK98e6fAqwP@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=amit@kernel.org \
--cc=arnd@arndb.de \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=osandov@fb.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xianting.tian@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).