From: Andrew Lunn <andrew@lunn.ch>
To: Joel Stanley <joel@jms.id.au>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Karol Gugala <kgugala@antmicro.com>,
Mateusz Holenko <mholenko@antmicro.com>,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: net: Add bindings for LiteETH
Date: Fri, 20 Aug 2021 19:41:03 +0200 [thread overview]
Message-ID: <YR/pLw8EDKJWt8Uw@lunn.ch> (raw)
In-Reply-To: <20210820074726.2860425-2-joel@jms.id.au>
On Fri, Aug 20, 2021 at 05:17:25PM +0930, Joel Stanley wrote:
> LiteETH is a small footprint and configurable Ethernet core for FPGA
> based system on chips.
Hi Joel
Just an FYI.
DT is considered ABI. Once released, you should not be making changes
which are not backwards compatible.
All the PHY and MDIO properties you are adding here are unused in the
driver. They all look sensible, and you should be able to make it
work. But when you do come to make that implementation, this
definition is the base of what you have to work with.
Andrew
next prev parent reply other threads:[~2021-08-20 17:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 7:47 [PATCH v2 0/2] net: Add LiteETH network driver Joel Stanley
2021-08-20 7:47 ` [PATCH v2 1/2] dt-bindings: net: Add bindings for LiteETH Joel Stanley
2021-08-20 17:41 ` Andrew Lunn [this message]
2021-08-23 18:44 ` Rob Herring
2021-08-24 3:51 ` Joel Stanley
2021-08-24 11:52 ` Rob Herring
2021-08-25 3:00 ` Joel Stanley
2021-08-20 7:47 ` [PATCH v2 2/2] net: Add driver for LiteX's LiteEth network interface Joel Stanley
2021-08-20 11:50 ` kernel test robot
2021-08-24 19:43 ` Gabriel L. Somlo
2021-08-25 6:35 ` Joel Stanley
2021-08-25 6:41 ` Joel Stanley
2021-08-25 12:00 ` Gabriel L. Somlo
2021-08-27 2:11 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YR/pLw8EDKJWt8Uw@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=kgugala@antmicro.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mholenko@antmicro.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).