From: Andrew Lunn <andrew@lunn.ch>
To: Joel Stanley <joel@jms.id.au>
Cc: "Gabriel L. Somlo" <gsomlo@gmail.com>,
Florent Kermarrec <florent@enjoy-digital.fr>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Karol Gugala <kgugala@antmicro.com>,
Mateusz Holenko <mholenko@antmicro.com>,
devicetree <devicetree@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Shah <dave@ds0.me>, Stafford Horne <shorne@gmail.com>
Subject: Re: [PATCH v2 2/2] net: Add driver for LiteX's LiteEth network interface
Date: Fri, 27 Aug 2021 04:11:11 +0200 [thread overview]
Message-ID: <YShJv2XRud7pSseZ@lunn.ch> (raw)
In-Reply-To: <CACPK8Xf9LGQBUHmS9sQ4zG1akk5SoQ-31MD-GMWVSRuByAT7KQ@mail.gmail.com>
On Wed, Aug 25, 2021 at 06:35:17AM +0000, Joel Stanley wrote:
> On Tue, 24 Aug 2021 at 19:43, Gabriel L. Somlo <gsomlo@gmail.com> wrote:
> >
> > Hi Joel,
> >
> > Couple of comments below:
> >
> > On Fri, Aug 20, 2021 at 05:17:26PM +0930, Joel Stanley wrote:
>
> > > diff --git a/drivers/net/ethernet/litex/Kconfig b/drivers/net/ethernet/litex/Kconfig
> > > new file mode 100644
> > > index 000000000000..265dba414b41
> > > --- /dev/null
> > > +++ b/drivers/net/ethernet/litex/Kconfig
>
> > > +
> > > +config LITEX_LITEETH
> > > + tristate "LiteX Ethernet support"
> >
> > Mostly cosmetic, but should there be a "depends on LITEX" statement in here?
>
> No, there's as there is no dependency on the litex soc driver.
Which is good, you will get more build coverage that way, it will be
built of x86, arm, mips, etc...
>
> > Maybe also "select MII" and "select PHYLIB"?
>
> Again, there is no mii or phy code so the driver doesn't need these.
Yet.
At some point i expect you will need these, but you don't need them
now.
Andrew
prev parent reply other threads:[~2021-08-27 2:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 7:47 [PATCH v2 0/2] net: Add LiteETH network driver Joel Stanley
2021-08-20 7:47 ` [PATCH v2 1/2] dt-bindings: net: Add bindings for LiteETH Joel Stanley
2021-08-20 17:41 ` Andrew Lunn
2021-08-23 18:44 ` Rob Herring
2021-08-24 3:51 ` Joel Stanley
2021-08-24 11:52 ` Rob Herring
2021-08-25 3:00 ` Joel Stanley
2021-08-20 7:47 ` [PATCH v2 2/2] net: Add driver for LiteX's LiteEth network interface Joel Stanley
2021-08-20 11:50 ` kernel test robot
2021-08-24 19:43 ` Gabriel L. Somlo
2021-08-25 6:35 ` Joel Stanley
2021-08-25 6:41 ` Joel Stanley
2021-08-25 12:00 ` Gabriel L. Somlo
2021-08-27 2:11 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YShJv2XRud7pSseZ@lunn.ch \
--to=andrew@lunn.ch \
--cc=dave@ds0.me \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=florent@enjoy-digital.fr \
--cc=gsomlo@gmail.com \
--cc=joel@jms.id.au \
--cc=kgugala@antmicro.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mholenko@antmicro.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).