From: Mike Rapoport <rppt@kernel.org>
To: Vineet Gupta <vgupta@kernel.org>
Cc: linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: [PATCH 09/18] ARC: mm: non-functional code cleanup ahead of 3 levels
Date: Wed, 11 Aug 2021 15:31:43 +0300 [thread overview]
Message-ID: <YRPDL90Qr5RLDmnT@kernel.org> (raw)
In-Reply-To: <20210811004258.138075-10-vgupta@kernel.org>
On Tue, Aug 10, 2021 at 05:42:49PM -0700, Vineet Gupta wrote:
> Signed-off-by: Vineet Gupta <vgupta@kernel.org>
> ---
> arch/arc/include/asm/page.h | 30 ++++++++++++++++--------------
> arch/arc/include/asm/pgalloc.h | 7 ++++++-
> 2 files changed, 22 insertions(+), 15 deletions(-)
>
> diff --git a/arch/arc/include/asm/page.h b/arch/arc/include/asm/page.h
> index c4ac827379cd..313e6f543d2d 100644
> --- a/arch/arc/include/asm/page.h
> +++ b/arch/arc/include/asm/page.h
> @@ -34,6 +34,13 @@ void copy_user_highpage(struct page *to, struct page *from,
> unsigned long u_vaddr, struct vm_area_struct *vma);
> void clear_user_page(void *to, unsigned long u_vaddr, struct page *page);
>
> +typedef struct {
> + unsigned long pgd;
> +} pgd_t;
> +
> +#define pgd_val(x) ((x).pgd)
> +#define __pgd(x) ((pgd_t) { (x) })
> +
> typedef struct {
> #ifdef CONFIG_ARC_HAS_PAE40
> unsigned long long pte;
> @@ -41,22 +48,17 @@ typedef struct {
> unsigned long pte;
> #endif
> } pte_t;
> -typedef struct {
> - unsigned long pgd;
> -} pgd_t;
> +
> +#define pte_val(x) ((x).pte)
> +#define __pte(x) ((pte_t) { (x) })
> +
> typedef struct {
> unsigned long pgprot;
> } pgprot_t;
>
> -#define pte_val(x) ((x).pte)
> -#define pgd_val(x) ((x).pgd)
> -#define pgprot_val(x) ((x).pgprot)
> -
> -#define __pte(x) ((pte_t) { (x) })
> -#define __pgd(x) ((pgd_t) { (x) })
> -#define __pgprot(x) ((pgprot_t) { (x) })
> -
> -#define pte_pgprot(x) __pgprot(pte_val(x))
> +#define pgprot_val(x) ((x).pgprot)
> +#define __pgprot(x) ((pgprot_t) { (x) })
> +#define pte_pgprot(x) __pgprot(pte_val(x))
>
> typedef pte_t * pgtable_t;
>
> @@ -96,8 +98,8 @@ extern int pfn_valid(unsigned long pfn);
> * virt here means link-address/program-address as embedded in object code.
> * And for ARC, link-addr = physical address
> */
> -#define __pa(vaddr) ((unsigned long)(vaddr))
> -#define __va(paddr) ((void *)((unsigned long)(paddr)))
> +#define __pa(vaddr) ((unsigned long)(vaddr))
> +#define __va(paddr) ((void *)((unsigned long)(paddr)))
>
> #define virt_to_page(kaddr) pfn_to_page(virt_to_pfn(kaddr))
> #define virt_addr_valid(kaddr) pfn_valid(virt_to_pfn(kaddr))
> diff --git a/arch/arc/include/asm/pgalloc.h b/arch/arc/include/asm/pgalloc.h
> index 356237b9c537..0cf73431eb89 100644
> --- a/arch/arc/include/asm/pgalloc.h
> +++ b/arch/arc/include/asm/pgalloc.h
> @@ -29,6 +29,11 @@
> #ifndef _ASM_ARC_PGALLOC_H
> #define _ASM_ARC_PGALLOC_H
>
> +/*
> + * For ARC, pgtable_t is not struct page *, but pte_t * (to avoid
> + * extraneous page_address() calculations) hence can't use
> + * use asm-generic/pgalloc.h which assumes it being struct page *
> + */
Another reason to leave ARC without asm-generic/pgalloc.h was
__get_order_pte() that other arches don't have.
So this and pgtable_t aliased to pte_t * seemed to me too much to bother
then, but probably it's worth reconsidering with addition of 3rd and 4th
levels.
> #include <linux/mm.h>
> #include <linux/log2.h>
>
> @@ -36,7 +41,7 @@ static inline void
> pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmdp, pte_t *ptep)
> {
> /*
> - * The cast to long below is OK even when pte is long long (PAE40)
> + * The cast to long below is OK in 32-bit PAE40 regime with long long pte
> * Despite "wider" pte, the pte table needs to be in non-PAE low memory
> * as all higher levels can only hold long pointers.
> *
> --
> 2.25.1
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2021-08-11 12:31 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 0:42 [PATCH 00/18] ARC mm updates to support 3 or 4 levels of paging Vineet Gupta
2021-08-11 0:42 ` [PATCH 01/18] ARC: mm: simplify mmu scratch register assingment to mmu needs Vineet Gupta
2021-08-11 0:42 ` [PATCH 02/18] ARC: mm: remove tlb paranoid code Vineet Gupta
2021-08-11 0:42 ` [PATCH 03/18] ARC: mm: move mmu/cache externs out to setup.h Vineet Gupta
2021-08-11 5:10 ` Mike Rapoport
2021-08-11 18:46 ` Vineet Gupta
2021-08-11 0:42 ` [PATCH 04/18] ARC: mm: remove pgd_offset_fast Vineet Gupta
2021-08-11 5:12 ` Mike Rapoport
2021-08-11 18:54 ` Vineet Gupta
2021-08-11 0:42 ` [PATCH 05/18] ARC: mm: Fixes to allow STRICT_MM_TYPECHECKS Vineet Gupta
2021-08-11 0:42 ` [PATCH 06/18] ARC: mm: Enable STRICT_MM_TYPECHECKS Vineet Gupta
2021-08-11 12:04 ` Mike Rapoport
2021-08-11 19:01 ` Vineet Gupta
2021-08-11 0:42 ` [PATCH 07/18] ARC: ioremap: use more commonly used PAGE_KERNEL based uncached flag Vineet Gupta
2021-08-11 5:18 ` Mike Rapoport
2021-08-11 18:58 ` Vineet Gupta
2021-08-11 0:42 ` [PATCH 08/18] ARC: mm: pmd_populate* to use the canonical set_pmd (and drop pmd_set) Vineet Gupta
2021-08-11 0:42 ` [PATCH 09/18] ARC: mm: non-functional code cleanup ahead of 3 levels Vineet Gupta
2021-08-11 12:31 ` Mike Rapoport [this message]
2021-08-12 1:37 ` Vineet Gupta
2021-08-12 6:18 ` Mike Rapoport
2021-08-12 18:58 ` Vineet Gupta
2021-08-11 0:42 ` [PATCH 10/18] ARC: mm: move MMU specific bits out of ASID allocator Vineet Gupta
2021-08-11 0:42 ` [PATCH 11/18] ARC: mm: move MMU specific bits out of entry code Vineet Gupta
2021-08-11 12:15 ` Mike Rapoport
2021-08-11 19:30 ` Vineet Gupta
2021-08-11 0:42 ` [PATCH 12/18] ARC: mm: disintegrate mmu.h (arcv2 bits out) Vineet Gupta
2021-08-11 0:42 ` [PATCH 13/18] ARC: mm: disintegrate pgtable.h into levels and flags Vineet Gupta
2021-08-11 0:42 ` [PATCH 14/18] ARC: mm: hack to allow 2 level build with 4 level code Vineet Gupta
2021-08-11 0:42 ` [PATCH 15/18] ARC: mm: support 3 levels of page tables Vineet Gupta
2021-08-11 12:24 ` Mike Rapoport
2021-08-11 22:15 ` Vineet Gupta
2021-08-11 0:42 ` [PATCH 16/18] ARC: mm: support 4 " Vineet Gupta
2021-08-11 12:28 ` Mike Rapoport
2021-08-11 22:17 ` Vineet Gupta
2021-08-11 0:42 ` [PATCH 17/18] ARC: mm: vmalloc sync from kernel to user table to update PMD Vineet Gupta
2021-08-11 0:42 ` [PATCH 18/18] ARC: mm: introduce _PAGE_TABLE to explicitly link pgd,pud,pmd entries Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRPDL90Qr5RLDmnT@kernel.org \
--to=rppt@kernel.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=vgupta@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).