* [PATCH] soc: qcom: socinfo: Fixed argument passed to platform_set_data()
@ 2021-08-17 0:24 Antonio Martorana
2021-08-17 2:35 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Antonio Martorana @ 2021-08-17 0:24 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson
Cc: Antonio Martorana, Elliot Berman, Trilok Soni, linux-arm-msm,
linux-kernel
Set qcom_socinfo pointer as data being stored instead of pointer
to soc_device structure. Aligns with future calls to platform_get_data()
which expects qcom_socinfo pointer.
Signed-off-by: Antonio Martorana <amartora@codeaurora.org>
---
drivers/soc/qcom/socinfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
index 9faf483..52e5811 100644
--- a/drivers/soc/qcom/socinfo.c
+++ b/drivers/soc/qcom/socinfo.c
@@ -628,7 +628,7 @@ static int qcom_socinfo_probe(struct platform_device *pdev)
/* Feed the soc specific unique data into entropy pool */
add_device_randomness(info, item_size);
- platform_set_drvdata(pdev, qs->soc_dev);
+ platform_set_drvdata(pdev, qs);
return 0;
}
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] soc: qcom: socinfo: Fixed argument passed to platform_set_data()
2021-08-17 0:24 [PATCH] soc: qcom: socinfo: Fixed argument passed to platform_set_data() Antonio Martorana
@ 2021-08-17 2:35 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2021-08-17 2:35 UTC (permalink / raw)
To: Antonio Martorana
Cc: Andy Gross, Elliot Berman, Trilok Soni, linux-arm-msm, linux-kernel
On Mon 16 Aug 19:24 CDT 2021, Antonio Martorana wrote:
> Set qcom_socinfo pointer as data being stored instead of pointer
> to soc_device structure. Aligns with future calls to platform_get_data()
> which expects qcom_socinfo pointer.
>
Thanks for the patch Antonio!
This should have a fixes tag, to ensure that it's appropriately
backported.
Fixes: efb448d0a3fc ("soc: qcom: Add socinfo driver")
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Signed-off-by: Antonio Martorana <amartora@codeaurora.org>
> ---
> drivers/soc/qcom/socinfo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index 9faf483..52e5811 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -628,7 +628,7 @@ static int qcom_socinfo_probe(struct platform_device *pdev)
> /* Feed the soc specific unique data into entropy pool */
> add_device_randomness(info, item_size);
>
> - platform_set_drvdata(pdev, qs->soc_dev);
> + platform_set_drvdata(pdev, qs);
>
> return 0;
> }
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-17 2:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-17 0:24 [PATCH] soc: qcom: socinfo: Fixed argument passed to platform_set_data() Antonio Martorana
2021-08-17 2:35 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).