[PATCH] perf, android: fixup get_current_dir_name() compilation

[PATCH] perf, android: fixup get_current_dir_name() compilation

[Alexey Dobriyan]

strdup() prototype doesn't live in stdlib.h .

Add limits.h for PATH_MAX definition as well.

Signed-off-by: Alexey Dobriyan (SK hynix) <adobriyan@gmail.com>
---

 tools/perf/util/get_current_dir_name.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/tools/perf/util/get_current_dir_name.c
+++ b/tools/perf/util/get_current_dir_name.c
@@ -3,8 +3,9 @@
 //
 #ifndef HAVE_GET_CURRENT_DIR_NAME
 #include "get_current_dir_name.h"
+#include <limits.h>
+#include <string.h>
 #include <unistd.h>
-#include <stdlib.h>
 
 /* Android's 'bionic' library, for one, doesn't have this */
 

Re: [PATCH] perf, android: fixup get_current_dir_name() compilation

[Namhyung Kim]

Hello,

On Tue, Aug 17, 2021 at 4:59 AM Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> strdup() prototype doesn't live in stdlib.h .
>
> Add limits.h for PATH_MAX definition as well.
>
> Signed-off-by: Alexey Dobriyan (SK hynix) <adobriyan@gmail.com>

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung


> ---
>
>  tools/perf/util/get_current_dir_name.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- a/tools/perf/util/get_current_dir_name.c
> +++ b/tools/perf/util/get_current_dir_name.c
> @@ -3,8 +3,9 @@
>  //
>  #ifndef HAVE_GET_CURRENT_DIR_NAME
>  #include "get_current_dir_name.h"
> +#include <limits.h>
> +#include <string.h>
>  #include <unistd.h>
> -#include <stdlib.h>
>
>  /* Android's 'bionic' library, for one, doesn't have this */
>

Re: [PATCH] perf, android: fixup get_current_dir_name() compilation

[Arnaldo Carvalho de Melo]

Em Thu, Aug 19, 2021 at 09:28:13AM -0700, Namhyung Kim escreveu:
> Hello,
> 
> On Tue, Aug 17, 2021 at 4:59 AM Alexey Dobriyan <adobriyan@gmail.com> wrote:
> >
> > strdup() prototype doesn't live in stdlib.h .
> >
> > Add limits.h for PATH_MAX definition as well.
> >
> > Signed-off-by: Alexey Dobriyan (SK hynix) <adobriyan@gmail.com>
> 
> Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks, applied.

- Arnaldo