From: Vinod Koul <vkoul@kernel.org>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Jonathan Corbet" <corbet@lwn.net>,
dmaengine <dmaengine@vger.kernel.org>,
"Linux Documentation List" <linux-doc@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
patches@linaro.org, "Haavard Skinnemoen" <hskinnemoen@atmel.com>,
"Håvard Skinnemoen" <hskinnemoen@gmail.com>
Subject: Re: [PATCH 1/2] Documentation: dmaengine: Add a description of what dmatest does
Date: Thu, 26 Aug 2021 18:22:55 +0530 [thread overview]
Message-ID: <YSeOpxIVJNCcKtEV@matsya> (raw)
In-Reply-To: <20210819091328.6up4oprx4j7u5bjl@maple.lan>
On 19-08-21, 10:13, Daniel Thompson wrote:
> On Wed, Aug 18, 2021 at 06:27:52PM +0300, Andy Shevchenko wrote:
> > On Wed, Aug 18, 2021 at 6:15 PM Daniel Thompson
> > <daniel.thompson@linaro.org> wrote:
> > >
> > > Currently it can difficult to determine what dmatest does without
> > > reading the source code. Let's add a description.
> > >
> > > The description is taken mostly from the patch header of
> > > commit 4a776f0aa922 ("dmatest: Simple DMA memcpy test client")
> > > although it has been edited and updated slightly.
> >
> > > Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
> >
> > Not sure if you can use it like this (I mean the above SoB)
>
> I wondered about that.
>
> In the end I concluded that if I had picked up code from an old patch
> and edited to this degree then I would probably consider it a new
> patch but be clear about credit and preserve the original SoB. I saw no
> real reason to treat the contents of a patch header much different.
>
> However, I'm very happy to make the credit more informal if needed.
It would be better if we be formal when giving credit. I am okay with
sob by Haavard if he acks it...
Daniel, Yes the intention is very noble, but I would have Haavard ack
before applying a patch with his sob, if not lets drop it and give
credit in changelog :)
--
~Vinod
next prev parent reply other threads:[~2021-08-26 12:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 15:13 [PATCH 0/2] Documentation: dmaengine: Tweak dmatest docs Daniel Thompson
2021-08-18 15:13 ` [PATCH 1/2] Documentation: dmaengine: Add a description of what dmatest does Daniel Thompson
2021-08-18 15:27 ` Andy Shevchenko
2021-08-19 9:13 ` Daniel Thompson
2021-08-26 12:52 ` Vinod Koul [this message]
2021-08-18 15:13 ` [PATCH 2/2] Documentation: dmaengine: Correctly describe dmatest with channel unset Daniel Thompson
2021-11-18 10:09 [PATCH 0/2] Documentation: dmaengine: Tweak dmatest docs Daniel Thompson
2021-11-18 10:09 ` [PATCH 1/2] Documentation: dmaengine: Add a description of what dmatest does Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSeOpxIVJNCcKtEV@matsya \
--to=vkoul@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=corbet@lwn.net \
--cc=daniel.thompson@linaro.org \
--cc=dmaengine@vger.kernel.org \
--cc=hskinnemoen@atmel.com \
--cc=hskinnemoen@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).