* [PATCH v3] staging: r8188eu: core: remove null check before vfree
@ 2021-08-29 7:34 Saurav Girepunje
2021-08-29 8:10 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Saurav Girepunje @ 2021-08-29 7:34 UTC (permalink / raw)
To: Larry.Finger, phil, gregkh, straube.linux, ross.schm.dev,
saurav.girepunje, linux-staging, linux-kernel
Cc: saurav.girepunje
Remove NULL check. NULL check before freeing function is not needed.
Correct the indentation.
ChangeLog V3:
-Added change log.
ChangeLog V2:
-Correct the indentation.
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
drivers/staging/r8188eu/core/rtw_sta_mgt.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_sta_mgt.c b/drivers/staging/r8188eu/core/rtw_sta_mgt.c
index f6dffed53a60..c3600cb1790a 100644
--- a/drivers/staging/r8188eu/core/rtw_sta_mgt.c
+++ b/drivers/staging/r8188eu/core/rtw_sta_mgt.c
@@ -155,9 +155,8 @@ u32 _rtw_free_sta_priv(struct sta_priv *pstapriv)
spin_unlock_bh(&pstapriv->sta_hash_lock);
/*===============================*/
- if (pstapriv->pallocated_stainfo_buf)
- vfree(pstapriv->pallocated_stainfo_buf);
- }
+ vfree(pstapriv->pallocated_stainfo_buf);
+ }
return _SUCCESS;
}
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] staging: r8188eu: core: remove null check before vfree
2021-08-29 7:34 [PATCH v3] staging: r8188eu: core: remove null check before vfree Saurav Girepunje
@ 2021-08-29 8:10 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-08-29 8:10 UTC (permalink / raw)
To: Saurav Girepunje
Cc: Larry.Finger, phil, straube.linux, ross.schm.dev, linux-staging,
linux-kernel, saurav.girepunje
On Sun, Aug 29, 2021 at 01:04:22PM +0530, Saurav Girepunje wrote:
> Remove NULL check. NULL check before freeing function is not needed.
> Correct the indentation.
>
> ChangeLog V3:
> -Added change log.
>
> ChangeLog V2:
> -Correct the indentation.
Please put this information below the --- line, as the documentation
says to do.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-29 8:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-29 7:34 [PATCH v3] staging: r8188eu: core: remove null check before vfree Saurav Girepunje
2021-08-29 8:10 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).