* [PATCH 1/2] driver core: platform: Fix the line-break indentation
@ 2021-09-02 5:24 Cai Huoqing
2021-09-02 5:37 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Cai Huoqing @ 2021-09-02 5:24 UTC (permalink / raw)
To: caihuoqing; +Cc: Greg Kroah-Hartman, Rafael J. Wysocki, linux-kernel
Fix the line-break indentation for the helper function
devm_platform_get_and_ioremap_resource()
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/base/platform.c | 2 +-
include/linux/platform_device.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index 652531f67135..52a1b94428c8 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -95,7 +95,7 @@ EXPORT_SYMBOL_GPL(platform_get_mem_or_io);
*/
void __iomem *
devm_platform_get_and_ioremap_resource(struct platform_device *pdev,
- unsigned int index, struct resource **res)
+ unsigned int index, struct resource **res)
{
struct resource *r;
diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h
index 7c96f169d274..07e1bba45243 100644
--- a/include/linux/platform_device.h
+++ b/include/linux/platform_device.h
@@ -61,7 +61,7 @@ platform_find_device_by_driver(struct device *start,
const struct device_driver *drv);
extern void __iomem *
devm_platform_get_and_ioremap_resource(struct platform_device *pdev,
- unsigned int index, struct resource **res);
+ unsigned int index, struct resource **res);
extern void __iomem *
devm_platform_ioremap_resource(struct platform_device *pdev,
unsigned int index);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] driver core: platform: Fix the line-break indentation
2021-09-02 5:24 [PATCH 1/2] driver core: platform: Fix the line-break indentation Cai Huoqing
@ 2021-09-02 5:37 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2021-09-02 5:37 UTC (permalink / raw)
To: Cai Huoqing; +Cc: Rafael J. Wysocki, linux-kernel
On Thu, Sep 02, 2021 at 01:24:45PM +0800, Cai Huoqing wrote:
> Fix the line-break indentation for the helper function
> devm_platform_get_and_ioremap_resource()
Why? What is wrong with what is there today? You need to explain _why_
you do something, not just _what_ you did.
If you want to do basic coding style cleanups, please stick with
drivers/staging/
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-02 5:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-02 5:24 [PATCH 1/2] driver core: platform: Fix the line-break indentation Cai Huoqing
2021-09-02 5:37 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).