linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] input/serio:unneeded variable:delay
@ 2021-03-23  7:02 mateng
  2021-09-04  6:54 ` Dmitry Torokhov
  0 siblings, 1 reply; 2+ messages in thread
From: mateng @ 2021-03-23  7:02 UTC (permalink / raw)
  To: dmitry.torokhov; +Cc: linux-input, linux-kernel, mateng

From: mateng <mateng@yulong.com>

delete unneeded variable 'delay'

Signed-off-by: mateng <mateng@yulong.com>
---
 drivers/input/serio/i8042.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
index abae23a..145bda1 100644
--- a/drivers/input/serio/i8042.c
+++ b/drivers/input/serio/i8042.c
@@ -1126,7 +1126,6 @@ static void i8042_controller_reset(bool s2r_wants_reset)
 
 static long i8042_panic_blink(int state)
 {
-	long delay = 0;
 	char led;
 
 	led = (state) ? 0x01 | 0x04 : 0;
@@ -1142,7 +1141,7 @@ static long i8042_panic_blink(int state)
 	dbg("%02x -> i8042 (panic blink)\n", led);
 	i8042_write_data(led);
 	DELAY;
-	return delay;
+	return 0;
 }
 
 #undef DELAY
-- 
1.9.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] input/serio:unneeded variable:delay
  2021-03-23  7:02 [PATCH] input/serio:unneeded variable:delay mateng
@ 2021-09-04  6:54 ` Dmitry Torokhov
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2021-09-04  6:54 UTC (permalink / raw)
  To: mateng; +Cc: linux-input, linux-kernel, mateng

On Tue, Mar 23, 2021 at 03:02:50PM +0800, mateng wrote:
> From: mateng <mateng@yulong.com>
> 
> delete unneeded variable 'delay'

Sorry, but this is bogus.

> 
> Signed-off-by: mateng <mateng@yulong.com>
> ---
>  drivers/input/serio/i8042.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
> index abae23a..145bda1 100644
> --- a/drivers/input/serio/i8042.c
> +++ b/drivers/input/serio/i8042.c
> @@ -1126,7 +1126,6 @@ static void i8042_controller_reset(bool s2r_wants_reset)
>  
>  static long i8042_panic_blink(int state)
>  {
> -	long delay = 0;
>  	char led;
>  
>  	led = (state) ? 0x01 | 0x04 : 0;
> @@ -1142,7 +1141,7 @@ static long i8042_panic_blink(int state)
>  	dbg("%02x -> i8042 (panic blink)\n", led);
>  	i8042_write_data(led);
>  	DELAY;
> -	return delay;
> +	return 0;
>  }
>  
>  #undef DELAY
> -- 
> 1.9.1
> 

-- 
Dmitry

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-04  6:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23  7:02 [PATCH] input/serio:unneeded variable:delay mateng
2021-09-04  6:54 ` Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).