From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Yunsheng Lin <linyunsheng@huawei.com>
Cc: Jesper Dangaard Brouer <jbrouer@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Networking <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
linuxarm@openeuler.org, Jesper Dangaard Brouer <hawk@kernel.org>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
Alexander Lobakin <alobakin@pm.me>,
Willem de Bruijn <willemb@google.com>,
Cong Wang <cong.wang@bytedance.com>,
Paolo Abeni <pabeni@redhat.com>, Kevin Hao <haokexin@gmail.com>,
Aleksandr Nogikh <nogikh@google.com>,
Marco Elver <elver@google.com>,
memxor@gmail.com, Eric Dumazet <edumazet@google.com>,
Alexander Duyck <alexander.duyck@gmail.com>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net-next 1/7] page_pool: disable dma mapping support for 32-bit arch with 64-bit DMA
Date: Thu, 23 Sep 2021 16:07:53 +0300 [thread overview]
Message-ID: <YUx8KZS5NPdTRkPS@apalos.home> (raw)
In-Reply-To: <adb2687f-b501-9324-52b2-33ede1169007@huawei.com>
On Thu, Sep 23, 2021 at 07:13:11PM +0800, Yunsheng Lin wrote:
> On 2021/9/23 18:02, Ilias Apalodimas wrote:
> > Hi Jesper,
> >
> > On Thu, 23 Sept 2021 at 12:33, Jesper Dangaard Brouer
> > <jbrouer@redhat.com> wrote:
> >>
> >>
> >> On 22/09/2021 11.41, Yunsheng Lin wrote:
> >>> diff --git a/net/core/page_pool.c b/net/core/page_pool.c
> >>> index 1a6978427d6c..a65bd7972e37 100644
> >>> --- a/net/core/page_pool.c
> >>> +++ b/net/core/page_pool.c
> >>> @@ -49,6 +49,12 @@ static int page_pool_init(struct page_pool *pool,
> >>> * which is the XDP_TX use-case.
> >>> */
> >>> if (pool->p.flags & PP_FLAG_DMA_MAP) {
> >>> + /* DMA-mapping is not supported on 32-bit systems with
> >>> + * 64-bit DMA mapping.
> >>> + */
> >>> + if (sizeof(dma_addr_t) > sizeof(unsigned long))
> >>> + return -EINVAL;
> >>
> >> As I said before, can we please use another error than EINVAL.
> >> We should give drivers a chance/ability to detect this error, and e.g.
> >> fallback to doing DMA mappings inside driver instead.
> >>
> >> I suggest using EOPNOTSUPP 95 (Operation not supported).
>
> Will change it to EOPNOTSUPP, thanks.
Mind sending this one separately (and you can keep my reviewed-by). It
fits nicely on it's own and since I am not sure about the rest of the
changes yet, it would be nice to get this one in.
Cheers
/Ilias
>
> >
> > I am fine with both. In any case though the aforementioned driver can
> > just remove PP_FLAG_DMA_MAP and do it's own mappings.
> >
> > Regards
> > /Ilias
> >>
> >> -Jesper
> >>
> > .
> >
next prev parent reply other threads:[~2021-09-23 13:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 9:41 [PATCH net-next 0/7] some optimization for page pool Yunsheng Lin
2021-09-22 9:41 ` [PATCH net-next 1/7] page_pool: disable dma mapping support for 32-bit arch with 64-bit DMA Yunsheng Lin
2021-09-23 9:10 ` Ilias Apalodimas
2021-09-23 9:33 ` Jesper Dangaard Brouer
2021-09-23 10:02 ` Ilias Apalodimas
2021-09-23 11:13 ` Yunsheng Lin
2021-09-23 13:07 ` Ilias Apalodimas [this message]
2021-09-24 7:04 ` Yunsheng Lin
2021-09-24 7:25 ` Ilias Apalodimas
2021-09-24 8:01 ` Yunsheng Lin
2021-09-22 9:41 ` [PATCH net-next 2/7] page_pool: support non-split page with PP_FLAG_PAGE_FRAG Yunsheng Lin
2021-09-23 12:08 ` Jesper Dangaard Brouer
2021-09-24 7:23 ` Yunsheng Lin
2021-09-30 7:28 ` [Linuxarm] " Yunsheng Lin
2021-09-22 9:41 ` [PATCH net-next 3/7] pool_pool: avoid calling compound_head() for skb frag page Yunsheng Lin
2021-09-23 8:33 ` Ilias Apalodimas
2021-09-23 11:24 ` Yunsheng Lin
2021-09-23 11:47 ` Ilias Apalodimas
2021-09-24 7:33 ` Yunsheng Lin
2021-09-24 7:44 ` Ilias Apalodimas
2021-09-22 9:41 ` [PATCH net-next 4/7] page_pool: change BIAS_MAX to support incrementing Yunsheng Lin
2021-09-22 9:41 ` [PATCH net-next 5/7] skbuff: keep track of pp page when __skb_frag_ref() is called Yunsheng Lin
2021-09-22 9:41 ` [PATCH net-next 6/7] skbuff: only use pp_magic identifier for a skb' head page Yunsheng Lin
2021-09-22 9:41 ` [PATCH net-next 7/7] skbuff: remove unused skb->pp_recycle Yunsheng Lin
2021-09-23 7:07 ` [PATCH net-next 0/7] some optimization for page pool Ilias Apalodimas
2021-09-23 11:12 ` Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUx8KZS5NPdTRkPS@apalos.home \
--to=ilias.apalodimas@linaro.org \
--cc=alexander.duyck@gmail.com \
--cc=alobakin@pm.me \
--cc=brouer@redhat.com \
--cc=cong.wang@bytedance.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=elver@google.com \
--cc=haokexin@gmail.com \
--cc=hawk@kernel.org \
--cc=jbrouer@redhat.com \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=linyunsheng@huawei.com \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nogikh@google.com \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).