* [lpieralisi-pci:pci/dwc 5/7] drivers/pci/controller/dwc/pcie-visconti.c:282:17: error: unused variable 'dev'
@ 2021-10-07 12:19 kernel test robot
2021-10-07 12:33 ` Krzysztof Wilczyński
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2021-10-07 12:19 UTC (permalink / raw)
To: Krzysztof Wilczyński
Cc: llvm, kbuild-all, Bjorn Helgaas, linux-kernel, Lorenzo Pieralisi
[-- Attachment #1: Type: text/plain, Size: 3298 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git pci/dwc
head: 2d614eea218333de679fb2f59681671bb88168c1
commit: 99e8fc7d35c810813915a4d998953d3c545df6b5 [5/7] PCI: visconti: Remove surplus dev_err() when using platform_get_irq_byname()
config: riscv-buildonly-randconfig-r004-20211007 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 58b68e70ebf6308f982426a2618782f473218eed)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/commit/?id=99e8fc7d35c810813915a4d998953d3c545df6b5
git remote add lpieralisi-pci https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git
git fetch --no-tags lpieralisi-pci pci/dwc
git checkout 99e8fc7d35c810813915a4d998953d3c545df6b5
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/pci/controller/dwc/pcie-visconti.c:282:17: error: unused variable 'dev' [-Werror,-Wunused-variable]
struct device *dev = &pdev->dev;
^
1 error generated.
vim +/dev +282 drivers/pci/controller/dwc/pcie-visconti.c
da36024a4e838b Nobuhiro Iwamatsu 2021-08-11 276
da36024a4e838b Nobuhiro Iwamatsu 2021-08-11 277 static int visconti_add_pcie_port(struct visconti_pcie *pcie,
da36024a4e838b Nobuhiro Iwamatsu 2021-08-11 278 struct platform_device *pdev)
da36024a4e838b Nobuhiro Iwamatsu 2021-08-11 279 {
da36024a4e838b Nobuhiro Iwamatsu 2021-08-11 280 struct dw_pcie *pci = &pcie->pci;
da36024a4e838b Nobuhiro Iwamatsu 2021-08-11 281 struct pcie_port *pp = &pci->pp;
da36024a4e838b Nobuhiro Iwamatsu 2021-08-11 @282 struct device *dev = &pdev->dev;
da36024a4e838b Nobuhiro Iwamatsu 2021-08-11 283
da36024a4e838b Nobuhiro Iwamatsu 2021-08-11 284 pp->irq = platform_get_irq_byname(pdev, "intr");
99e8fc7d35c810 Krzysztof Wilczyński 2021-10-01 285 if (pp->irq < 0)
da36024a4e838b Nobuhiro Iwamatsu 2021-08-11 286 return pp->irq;
da36024a4e838b Nobuhiro Iwamatsu 2021-08-11 287
da36024a4e838b Nobuhiro Iwamatsu 2021-08-11 288 pp->ops = &visconti_pcie_host_ops;
da36024a4e838b Nobuhiro Iwamatsu 2021-08-11 289
da36024a4e838b Nobuhiro Iwamatsu 2021-08-11 290 return dw_pcie_host_init(pp);
da36024a4e838b Nobuhiro Iwamatsu 2021-08-11 291 }
da36024a4e838b Nobuhiro Iwamatsu 2021-08-11 292
:::::: The code at line 282 was first introduced by commit
:::::: da36024a4e838b52408cf3d04999ae934728092a PCI: visconti: Add Toshiba Visconti PCIe host controller driver
:::::: TO: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
:::::: CC: Bjorn Helgaas <bhelgaas@google.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31368 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [lpieralisi-pci:pci/dwc 5/7] drivers/pci/controller/dwc/pcie-visconti.c:282:17: error: unused variable 'dev'
2021-10-07 12:19 [lpieralisi-pci:pci/dwc 5/7] drivers/pci/controller/dwc/pcie-visconti.c:282:17: error: unused variable 'dev' kernel test robot
@ 2021-10-07 12:33 ` Krzysztof Wilczyński
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Wilczyński @ 2021-10-07 12:33 UTC (permalink / raw)
To: kernel test robot
Cc: llvm, kbuild-all, Bjorn Helgaas, linux-kernel, Lorenzo Pieralisi
Hello,
[...]
> >> drivers/pci/controller/dwc/pcie-visconti.c:282:17: error: unused variable 'dev' [-Werror,-Wunused-variable]
> struct device *dev = &pdev->dev;
> ^
Doh! This has been since fixed in v2.
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-07 12:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-07 12:19 [lpieralisi-pci:pci/dwc 5/7] drivers/pci/controller/dwc/pcie-visconti.c:282:17: error: unused variable 'dev' kernel test robot
2021-10-07 12:33 ` Krzysztof Wilczyński
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).