* [PATCH] fs/elf: Fix kernel pointer leak
@ 2021-09-29 13:17 Guo Zhi
2021-10-03 3:47 ` Al Viro
0 siblings, 1 reply; 2+ messages in thread
From: Guo Zhi @ 2021-09-29 13:17 UTC (permalink / raw)
To: Alexander Viro; +Cc: Guo Zhi, linux-fsdevel, linux-kernel
Pointers should be printed with %p rather than %px
which printed kernel pointer directly.
Change %px to %p to print the secured pointer.
Signed-off-by: Guo Zhi <qtxuning1999@sjtu.edu.cn>
---
fs/binfmt_elf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
index f3523807dbca..440a483656ed 100644
--- a/fs/binfmt_elf.c
+++ b/fs/binfmt_elf.c
@@ -393,7 +393,7 @@ static unsigned long elf_map(struct file *filep, unsigned long addr,
if ((type & MAP_FIXED_NOREPLACE) &&
PTR_ERR((void *)map_addr) == -EEXIST)
- pr_info("%d (%s): Uhuuh, elf segment at %px requested but the memory is mapped already\n",
+ pr_info("%d (%s): Uhuuh, elf segment at %p requested but the memory is mapped already\n",
task_pid_nr(current), current->comm, (void *)addr);
return(map_addr);
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs/elf: Fix kernel pointer leak
2021-09-29 13:17 [PATCH] fs/elf: Fix kernel pointer leak Guo Zhi
@ 2021-10-03 3:47 ` Al Viro
0 siblings, 0 replies; 2+ messages in thread
From: Al Viro @ 2021-10-03 3:47 UTC (permalink / raw)
To: Guo Zhi; +Cc: linux-fsdevel, linux-kernel
On Wed, Sep 29, 2021 at 09:17:02PM +0800, Guo Zhi wrote:
> Pointers should be printed with %p rather than %px
> which printed kernel pointer directly.
> Change %px to %p to print the secured pointer.
Huh? What makes it a kernel pointer? It's a userland address...
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-03 3:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-29 13:17 [PATCH] fs/elf: Fix kernel pointer leak Guo Zhi
2021-10-03 3:47 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).