* [PATCH] drm/tegra: mark nvdec PM functions as __maybe_unused
@ 2021-10-13 14:41 Arnd Bergmann
2021-10-18 13:56 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-10-13 14:41 UTC (permalink / raw)
To: Thierry Reding, David Airlie, Daniel Vetter, Jonathan Hunter,
Mikko Perttunen
Cc: Arnd Bergmann, dri-devel, linux-tegra, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The resume helper is called conditionally and causes a harmless
warning when stubbed out:
drivers/gpu/drm/tegra/nvdec.c:240:12: error: 'nvdec_runtime_resume' defined but not used [-Werror=unused-function]
240 | static int nvdec_runtime_resume(struct device *dev)
Mark both suspend and resume as __maybe_unused for consistency
to avoid this warning.
Fixes: e76599df354d ("drm/tegra: Add NVDEC driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/tegra/nvdec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/tegra/nvdec.c b/drivers/gpu/drm/tegra/nvdec.c
index 30105a93de9f..791bf1acf5f0 100644
--- a/drivers/gpu/drm/tegra/nvdec.c
+++ b/drivers/gpu/drm/tegra/nvdec.c
@@ -238,7 +238,7 @@ static int nvdec_load_firmware(struct nvdec *nvdec)
}
-static int nvdec_runtime_resume(struct device *dev)
+static __maybe_unused int nvdec_runtime_resume(struct device *dev)
{
struct nvdec *nvdec = dev_get_drvdata(dev);
int err;
@@ -264,7 +264,7 @@ static int nvdec_runtime_resume(struct device *dev)
return err;
}
-static int nvdec_runtime_suspend(struct device *dev)
+static __maybe_unused int nvdec_runtime_suspend(struct device *dev)
{
struct nvdec *nvdec = dev_get_drvdata(dev);
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/tegra: mark nvdec PM functions as __maybe_unused
2021-10-13 14:41 [PATCH] drm/tegra: mark nvdec PM functions as __maybe_unused Arnd Bergmann
@ 2021-10-18 13:56 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2021-10-18 13:56 UTC (permalink / raw)
To: Arnd Bergmann
Cc: David Airlie, Daniel Vetter, Jonathan Hunter, Mikko Perttunen,
Arnd Bergmann, dri-devel, linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 724 bytes --]
On Wed, Oct 13, 2021 at 04:41:36PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The resume helper is called conditionally and causes a harmless
> warning when stubbed out:
>
> drivers/gpu/drm/tegra/nvdec.c:240:12: error: 'nvdec_runtime_resume' defined but not used [-Werror=unused-function]
> 240 | static int nvdec_runtime_resume(struct device *dev)
>
> Mark both suspend and resume as __maybe_unused for consistency
> to avoid this warning.
>
> Fixes: e76599df354d ("drm/tegra: Add NVDEC driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/tegra/nvdec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-18 14:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-13 14:41 [PATCH] drm/tegra: mark nvdec PM functions as __maybe_unused Arnd Bergmann
2021-10-18 13:56 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).