* [PATCH] mfd: replace snprintf in show functions with sysfs_emit
@ 2021-10-15 6:49 Qing Wang
2021-10-21 11:16 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Qing Wang @ 2021-10-15 6:49 UTC (permalink / raw)
To: Lee Jones, linux-kernel; +Cc: Qing Wang
show() must not use snprintf() when formatting the value to be
returned to user space.
Fix the following coccicheck warning:
drivers/mfd/janz-cmodio.c:157: WARNING: use scnprintf or sprintf.
Use sysfs_emit instead of scnprintf or sprintf makes more sense.
Signed-off-by: Qing Wang <wangqing@vivo.com>
---
drivers/mfd/janz-cmodio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/janz-cmodio.c b/drivers/mfd/janz-cmodio.c
index 70eba4c..add3bc0 100644
--- a/drivers/mfd/janz-cmodio.c
+++ b/drivers/mfd/janz-cmodio.c
@@ -154,7 +154,7 @@ static ssize_t modulbus_number_show(struct device *dev,
{
struct cmodio_device *priv = dev_get_drvdata(dev);
- return snprintf(buf, PAGE_SIZE, "%x\n", priv->hex);
+ return sysfs_emit(buf, "%x\n", priv->hex);
}
static DEVICE_ATTR_RO(modulbus_number);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: replace snprintf in show functions with sysfs_emit
2021-10-15 6:49 [PATCH] mfd: replace snprintf in show functions with sysfs_emit Qing Wang
@ 2021-10-21 11:16 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2021-10-21 11:16 UTC (permalink / raw)
To: Qing Wang; +Cc: linux-kernel
On Thu, 14 Oct 2021, Qing Wang wrote:
> show() must not use snprintf() when formatting the value to be
> returned to user space.
>
> Fix the following coccicheck warning:
> drivers/mfd/janz-cmodio.c:157: WARNING: use scnprintf or sprintf.
>
> Use sysfs_emit instead of scnprintf or sprintf makes more sense.
>
> Signed-off-by: Qing Wang <wangqing@vivo.com>
> ---
> drivers/mfd/janz-cmodio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I've fixed the subject line for you and applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-21 11:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-15 6:49 [PATCH] mfd: replace snprintf in show functions with sysfs_emit Qing Wang
2021-10-21 11:16 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).