* [PATCH] usb: tcpm: Simplify the return expression of tcpm_start_toggling
@ 2021-10-22 11:00 dingsenjie
2021-10-22 11:47 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: dingsenjie @ 2021-10-22 11:00 UTC (permalink / raw)
To: linux, heikki.krogerus, gregkh; +Cc: linux-usb, linux-kernel, dingsenjie
From: dingsenjie <dingsenjie@yulong.com>
Simplify the return expression in the tcpm.c
Signed-off-by: dingsenjie <dingsenjie@yulong.com>
---
drivers/usb/typec/tcpm/tcpm.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
index 22a85b396f69..dabe694a7eb1 100644
--- a/drivers/usb/typec/tcpm/tcpm.c
+++ b/drivers/usb/typec/tcpm/tcpm.c
@@ -2766,14 +2766,11 @@ static int tcpm_set_charge(struct tcpm_port *port, bool charge)
static bool tcpm_start_toggling(struct tcpm_port *port, enum typec_cc_status cc)
{
- int ret;
-
if (!port->tcpc->start_toggling)
return false;
tcpm_log_force(port, "Start toggling");
- ret = port->tcpc->start_toggling(port->tcpc, port->port_type, cc);
- return ret == 0;
+ return port->tcpc->start_toggling(port->tcpc, port->port_type, cc) == 0;
}
static void tcpm_set_cc(struct tcpm_port *port, enum typec_cc_status cc)
--
2.29.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: tcpm: Simplify the return expression of tcpm_start_toggling
2021-10-22 11:00 [PATCH] usb: tcpm: Simplify the return expression of tcpm_start_toggling dingsenjie
@ 2021-10-22 11:47 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-10-22 11:47 UTC (permalink / raw)
To: dingsenjie; +Cc: linux, heikki.krogerus, linux-usb, linux-kernel, dingsenjie
On Fri, Oct 22, 2021 at 07:00:45PM +0800, dingsenjie@163.com wrote:
> From: dingsenjie <dingsenjie@yulong.com>
>
> Simplify the return expression in the tcpm.c
Why?
>
> Signed-off-by: dingsenjie <dingsenjie@yulong.com>
Is this the full name you sign legal documents with? (I have to ask...)
> ---
> drivers/usb/typec/tcpm/tcpm.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 22a85b396f69..dabe694a7eb1 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -2766,14 +2766,11 @@ static int tcpm_set_charge(struct tcpm_port *port, bool charge)
>
> static bool tcpm_start_toggling(struct tcpm_port *port, enum typec_cc_status cc)
> {
> - int ret;
> -
> if (!port->tcpc->start_toggling)
> return false;
>
> tcpm_log_force(port, "Start toggling");
> - ret = port->tcpc->start_toggling(port->tcpc, port->port_type, cc);
> - return ret == 0;
> + return port->tcpc->start_toggling(port->tcpc, port->port_type, cc) == 0;
Why change this from the original code? The original code is easier to
read, right?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-22 11:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-22 11:00 [PATCH] usb: tcpm: Simplify the return expression of tcpm_start_toggling dingsenjie
2021-10-22 11:47 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).