From: Thierry Reding <thierry.reding@gmail.com>
To: Prathamesh Shete <pshete@nvidia.com>
Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com,
jonathanh@nvidia.com, linux-gpio@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
smangipudi@nvidia.com
Subject: Re: [PATCH 2/2] gpio: tegra186: Add support for Tegra234 gpio
Date: Thu, 28 Oct 2021 16:47:27 +0200 [thread overview]
Message-ID: <YXq3/1AXX7KiwpTy@orome.fritz.box> (raw)
In-Reply-To: <20211021123021.9602-2-pshete@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 2125 bytes --]
On Thu, Oct 21, 2021 at 06:00:21PM +0530, Prathamesh Shete wrote:
> Add support for the Tegra234 GPIO bank configuration.
>
> Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
> ---
> drivers/gpio/gpio-tegra186.c | 74 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 74 insertions(+)
>
> diff --git a/drivers/gpio/gpio-tegra186.c b/drivers/gpio/gpio-tegra186.c
> index d38980b9923a..edcc91b35e1e 100644
> --- a/drivers/gpio/gpio-tegra186.c
> +++ b/drivers/gpio/gpio-tegra186.c
> @@ -14,6 +14,7 @@
>
> #include <dt-bindings/gpio/tegra186-gpio.h>
> #include <dt-bindings/gpio/tegra194-gpio.h>
> +#include <dt-bindings/gpio/tegra234-gpio.h>
>
> /* security registers */
> #define TEGRA186_GPIO_CTL_SCR 0x0c
> @@ -877,6 +878,73 @@ static const struct tegra_gpio_soc tegra194_aon_soc = {
> .instance = 1,
> };
>
> +#define TEGRA234_MAIN_GPIO_PORT(_name, _bank, _port, _pins) \
> + [TEGRA234_MAIN_GPIO_PORT_##_name] = { \
> + .name = #_name, \
> + .bank = _bank, \
> + .port = _port, \
> + .pins = _pins, \
> + }
> +
> +static const struct tegra_gpio_port tegra234_main_ports[] = {
> + TEGRA234_MAIN_GPIO_PORT(A, 0, 0, 8),
> + TEGRA234_MAIN_GPIO_PORT(B, 0, 3, 1),
> + TEGRA234_MAIN_GPIO_PORT(C, 5, 1, 8),
> + TEGRA234_MAIN_GPIO_PORT(D, 5, 2, 4),
> + TEGRA234_MAIN_GPIO_PORT(E, 5, 3, 8),
> + TEGRA234_MAIN_GPIO_PORT(F, 5, 4, 6),
> + TEGRA234_MAIN_GPIO_PORT(G, 4, 0, 8),
> + TEGRA234_MAIN_GPIO_PORT(H, 4, 1, 8),
> + TEGRA234_MAIN_GPIO_PORT(I, 4, 2, 7),
> + TEGRA234_MAIN_GPIO_PORT(J, 5, 0, 6),
> + TEGRA234_MAIN_GPIO_PORT(K, 3, 0, 8),
> + TEGRA234_MAIN_GPIO_PORT(L, 3, 1, 4),
> + TEGRA234_MAIN_GPIO_PORT(M, 2, 0, 8),
> + TEGRA234_MAIN_GPIO_PORT(N, 2, 1, 8),
> + TEGRA234_MAIN_GPIO_PORT(P, 2, 2, 8),
> + TEGRA234_MAIN_GPIO_PORT(Q, 2, 3, 8),
> + TEGRA234_MAIN_GPIO_PORT(R, 2, 4, 6),
I stumbled across an old patch I had created a couple of months ago that
is very similar to this one. However, at the time I had added a couple
more ports here, namely S, T, U and V. Is there a reason why you're not
including those here?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-10-28 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 12:30 [PATCH 1/2] dt-bindings: tegra186-gpio: Add Tegra234 ports Prathamesh Shete
2021-10-21 12:30 ` [PATCH 2/2] gpio: tegra186: Add support for Tegra234 gpio Prathamesh Shete
2021-10-28 14:47 ` Thierry Reding [this message]
2021-11-02 13:21 ` Thierry Reding
2021-11-03 11:01 ` Prathamesh Shete
2021-11-09 0:30 ` Linus Walleij
2021-11-12 10:35 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXq3/1AXX7KiwpTy@orome.fritz.box \
--to=thierry.reding@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=jonathanh@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pshete@nvidia.com \
--cc=smangipudi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).