linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3] staging: mt7621-dma: reindent to avoid '(' at the end of line
@ 2021-11-13 13:59 Liu Junqi
  2021-11-13 14:11 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Liu Junqi @ 2021-11-13 13:59 UTC (permalink / raw)
  To: gregkh
  Cc: linux-staging, linux-arm-kernel, linux-mediatek, linux-kernel, Liu Junqi

A change to make the code more like typical coding style.

Signed-off-by: Liu Junqi <liujunqi@pku.edu.cn>
---
I'm a kernel newbie and it's my first time to send a patch following the "Write and Submit your first Linux kernel Patch" video on youtube.
The first version was rejected because of putting a '*' at the beginning of a line, and this version is exactly what Joe Perches advised in the reply to the original patch email.
Please let me know if I got anything wrong ^_^

 drivers/staging/mt7621-dma/hsdma-mt7621.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/mt7621-dma/hsdma-mt7621.c b/drivers/staging/mt7621-dma/hsdma-mt7621.c
index 1424d01d434b..f303579bd1a2 100644
--- a/drivers/staging/mt7621-dma/hsdma-mt7621.c
+++ b/drivers/staging/mt7621-dma/hsdma-mt7621.c
@@ -455,9 +455,9 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
 	spin_unlock_bh(&chan->vchan.lock);
 }
 
-static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
-		struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
-		size_t len, unsigned long flags)
+static struct dma_async_tx_descriptor *
+mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
+			  size_t len, unsigned long flags)
 {
 	struct mtk_hsdma_chan *chan = to_mtk_hsdma_chan(c);
 	struct mtk_hsdma_desc *desc;
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v3] staging: mt7621-dma: reindent to avoid '(' at the end of line
  2021-11-13 13:59 [PATCH v3] staging: mt7621-dma: reindent to avoid '(' at the end of line Liu Junqi
@ 2021-11-13 14:11 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-11-13 14:11 UTC (permalink / raw)
  To: Liu Junqi; +Cc: linux-staging, linux-arm-kernel, linux-mediatek, linux-kernel

On Sat, Nov 13, 2021 at 09:59:52PM +0800, Liu Junqi wrote:
> A change to make the code more like typical coding style.
> 
> Signed-off-by: Liu Junqi <liujunqi@pku.edu.cn>
> ---
> I'm a kernel newbie and it's my first time to send a patch following the "Write and Submit your first Linux kernel Patch" video on youtube.
> The first version was rejected because of putting a '*' at the beginning of a line, and this version is exactly what Joe Perches advised in the reply to the original patch email.
> Please let me know if I got anything wrong ^_^

Take a look at the link that my patch-bot told youto read.  It will show
you how to write a "this changed in this version" type of text below the
--- line.

Please do that and try again.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-13 14:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-13 13:59 [PATCH v3] staging: mt7621-dma: reindent to avoid '(' at the end of line Liu Junqi
2021-11-13 14:11 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).