* [PATCH] perf: add missing cpu entry in json output
@ 2021-11-12 11:57 Oleg Latin
2021-11-14 16:45 ` Jiri Olsa
0 siblings, 1 reply; 2+ messages in thread
From: Oleg Latin @ 2021-11-12 11:57 UTC (permalink / raw)
To: linux-kernel; +Cc: nfraser, jolsa, peterz, dmtrmonakhov
After converting perf.data with 'perf covert data --to-json' the
resulting json file missing cpu entries:
{
"timestamp": 5716840788599,
"pid": 79661,
"tid": 79661,
"comm": "python3",
"callchain": [
{
"ip": "0xffffffffafd05fc0"
}
]
},
Seems addr_location::thread::cpu is never assigned during
machine__resolve() call. This patch uses addr_location::cpu to store it
in json file.
Signed-off-by: Oleg Latin <oleglatin@yandex-team.ru>
---
tools/perf/util/data-convert-json.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/data-convert-json.c b/tools/perf/util/data-convert-json.c
index f1ab6edba446..b0e3d69c6835 100644
--- a/tools/perf/util/data-convert-json.c
+++ b/tools/perf/util/data-convert-json.c
@@ -168,8 +168,8 @@ static int process_sample_event(struct perf_tool *tool,
output_json_key_format(out, true, 3, "pid", "%i", al.thread->pid_);
output_json_key_format(out, true, 3, "tid", "%i", al.thread->tid);
- if (al.thread->cpu >= 0)
- output_json_key_format(out, true, 3, "cpu", "%i", al.thread->cpu);
+ if (al.cpu >= 0)
+ output_json_key_format(out, true, 3, "cpu", "%i", al.cpu);
output_json_key_string(out, true, 3, "comm", thread__comm_str(al.thread));
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] perf: add missing cpu entry in json output
2021-11-12 11:57 [PATCH] perf: add missing cpu entry in json output Oleg Latin
@ 2021-11-14 16:45 ` Jiri Olsa
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Olsa @ 2021-11-14 16:45 UTC (permalink / raw)
To: Oleg Latin; +Cc: linux-kernel, nfraser, peterz, dmtrmonakhov
On Fri, Nov 12, 2021 at 02:57:38PM +0300, Oleg Latin wrote:
> After converting perf.data with 'perf covert data --to-json' the
> resulting json file missing cpu entries:
>
> {
> "timestamp": 5716840788599,
> "pid": 79661,
> "tid": 79661,
> "comm": "python3",
> "callchain": [
> {
> "ip": "0xffffffffafd05fc0"
> }
> ]
> },
>
> Seems addr_location::thread::cpu is never assigned during
> machine__resolve() call. This patch uses addr_location::cpu to store it
> in json file.
>
> Signed-off-by: Oleg Latin <oleglatin@yandex-team.ru>
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks,
jirka
> ---
> tools/perf/util/data-convert-json.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/data-convert-json.c b/tools/perf/util/data-convert-json.c
> index f1ab6edba446..b0e3d69c6835 100644
> --- a/tools/perf/util/data-convert-json.c
> +++ b/tools/perf/util/data-convert-json.c
> @@ -168,8 +168,8 @@ static int process_sample_event(struct perf_tool *tool,
> output_json_key_format(out, true, 3, "pid", "%i", al.thread->pid_);
> output_json_key_format(out, true, 3, "tid", "%i", al.thread->tid);
>
> - if (al.thread->cpu >= 0)
> - output_json_key_format(out, true, 3, "cpu", "%i", al.thread->cpu);
> + if (al.cpu >= 0)
> + output_json_key_format(out, true, 3, "cpu", "%i", al.cpu);
>
> output_json_key_string(out, true, 3, "comm", thread__comm_str(al.thread));
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-14 16:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-12 11:57 [PATCH] perf: add missing cpu entry in json output Oleg Latin
2021-11-14 16:45 ` Jiri Olsa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).