From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org,
p.zabel@pengutronix.de, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 3/5] net: lan966x: add port module support
Date: Thu, 18 Nov 2021 09:59:17 +0000 [thread overview]
Message-ID: <YZYj9fwCeWdIZJOt@shell.armlinux.org.uk> (raw)
In-Reply-To: <20211118095703.owsb2nen5hb5vjz2@soft-dev3-1.localhost>
On Thu, Nov 18, 2021 at 10:57:03AM +0100, Horatiu Vultur wrote:
> > > +static void decode_sgmii_word(u16 lp_abil, struct lan966x_port_status *status)
> > > +{
> > > + status->an_complete = true;
> > > + if (!(lp_abil & LPA_SGMII_LINK)) {
> > > + status->link = false;
> > > + return;
> > > + }
> > > +
> > > + switch (lp_abil & LPA_SGMII_SPD_MASK) {
> > > + case LPA_SGMII_10:
> > > + status->speed = SPEED_10;
> > > + break;
> > > + case LPA_SGMII_100:
> > > + status->speed = SPEED_100;
> > > + break;
> > > + case LPA_SGMII_1000:
> > > + status->speed = SPEED_1000;
> > > + break;
> > > + default:
> > > + status->link = false;
> > > + return;
> > > + }
> > > + if (lp_abil & LPA_SGMII_FULL_DUPLEX)
> > > + status->duplex = DUPLEX_FULL;
> > > + else
> > > + status->duplex = DUPLEX_HALF;
> > > +}
> >
> > The above mentioned function will also handle SGMII as well.
>
> I noticed that you have phylink_decode_sgmii_work(), so I will try to
> export it also.
Another approach would be to split phylink_mii_c22_pcs_decode_state()
so that the appropriate decode function is selected depending on the
interface state, which may be a better idea.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-11-18 9:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 9:18 [PATCH net-next 0/5] net: lan966x: Add lan966x switch driver Horatiu Vultur
2021-11-17 9:18 ` [PATCH net-next 1/5] dt-bindings: net: lan966x: Add lan966x-switch bindings Horatiu Vultur
2021-11-17 9:18 ` [PATCH net-next 2/5] net: lan966x: add the basic lan966x driver Horatiu Vultur
2021-11-17 9:52 ` Philipp Zabel
2021-11-17 21:42 ` Horatiu Vultur
2021-11-18 10:19 ` Philipp Zabel
2021-11-18 12:49 ` Horatiu Vultur
2021-11-17 9:18 ` [PATCH net-next 3/5] net: lan966x: add port module support Horatiu Vultur
2021-11-17 9:54 ` Russell King (Oracle)
2021-11-18 9:57 ` Horatiu Vultur
2021-11-18 9:59 ` Russell King (Oracle) [this message]
2021-11-18 12:59 ` Horatiu Vultur
2021-11-18 13:31 ` Russell King (Oracle)
2021-11-18 15:36 ` Sean Anderson
2021-11-18 16:11 ` Russell King (Oracle)
2021-11-18 16:18 ` Sean Anderson
2021-11-19 8:49 ` Horatiu Vultur
2021-11-17 11:41 ` Russell King (Oracle)
2021-11-17 9:18 ` [PATCH net-next 4/5] net: lan966x: add mactable support Horatiu Vultur
2021-11-17 9:18 ` [PATCH net-next 5/5] net: lan966x: add ethtool configuration and statistics Horatiu Vultur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZYj9fwCeWdIZJOt@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).