* [PATCH v3] clk: imx: use module_platform_driver
@ 2021-09-04 23:54 Miles Chen
2021-09-05 0:44 ` Fabio Estevam
2021-09-05 20:42 ` Stephen Boyd
0 siblings, 2 replies; 7+ messages in thread
From: Miles Chen @ 2021-09-04 23:54 UTC (permalink / raw)
To: Abel Vesa, Michael Turquette, Stephen Boyd, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team
Cc: linux-clk, linux-arm-kernel, linux-kernel, linux-mediatek,
wsd_upstream, Miles Chen
Replace builtin_platform_driver_probe with module_platform_driver_probe
because CONFIG_CLK_IMX8QXP can be set to =m (kernel module).
Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Miles Chen <miles.chen@mediatek.com>
---
Change since v2:
use correct Fixes tag
Change since v1:
Add Fixes tags
---
drivers/clk/imx/clk-imx8qxp-lpcg.c | 2 +-
drivers/clk/imx/clk-imx8qxp.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c b/drivers/clk/imx/clk-imx8qxp-lpcg.c
index d3e905cf867d..b23758083ce5 100644
--- a/drivers/clk/imx/clk-imx8qxp-lpcg.c
+++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c
@@ -370,7 +370,7 @@ static struct platform_driver imx8qxp_lpcg_clk_driver = {
.probe = imx8qxp_lpcg_clk_probe,
};
-builtin_platform_driver(imx8qxp_lpcg_clk_driver);
+module_platform_driver(imx8qxp_lpcg_clk_driver);
MODULE_AUTHOR("Aisheng Dong <aisheng.dong@nxp.com>");
MODULE_DESCRIPTION("NXP i.MX8QXP LPCG clock driver");
diff --git a/drivers/clk/imx/clk-imx8qxp.c b/drivers/clk/imx/clk-imx8qxp.c
index c53a688d8ccc..40a2efb1329b 100644
--- a/drivers/clk/imx/clk-imx8qxp.c
+++ b/drivers/clk/imx/clk-imx8qxp.c
@@ -308,7 +308,7 @@ static struct platform_driver imx8qxp_clk_driver = {
},
.probe = imx8qxp_clk_probe,
};
-builtin_platform_driver(imx8qxp_clk_driver);
+module_platform_driver(imx8qxp_clk_driver);
MODULE_AUTHOR("Aisheng Dong <aisheng.dong@nxp.com>");
MODULE_DESCRIPTION("NXP i.MX8QXP clock driver");
--
2.18.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v3] clk: imx: use module_platform_driver
2021-09-04 23:54 [PATCH v3] clk: imx: use module_platform_driver Miles Chen
@ 2021-09-05 0:44 ` Fabio Estevam
2021-09-05 20:42 ` Stephen Boyd
1 sibling, 0 replies; 7+ messages in thread
From: Fabio Estevam @ 2021-09-05 0:44 UTC (permalink / raw)
To: Miles Chen
Cc: Abel Vesa, Michael Turquette, Stephen Boyd, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, NXP Linux Team, linux-clk,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel, linux-mediatek, wsd_upstream
Hi Miles,
On Sat, Sep 4, 2021 at 8:54 PM Miles Chen <miles.chen@mediatek.com> wrote:
>
> Replace builtin_platform_driver_probe with module_platform_driver_probe
> because CONFIG_CLK_IMX8QXP can be set to =m (kernel module).
>
> Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3] clk: imx: use module_platform_driver
2021-09-04 23:54 [PATCH v3] clk: imx: use module_platform_driver Miles Chen
2021-09-05 0:44 ` Fabio Estevam
@ 2021-09-05 20:42 ` Stephen Boyd
2021-11-05 5:59 ` miles.chen
1 sibling, 1 reply; 7+ messages in thread
From: Stephen Boyd @ 2021-09-05 20:42 UTC (permalink / raw)
To: Abel Vesa, Fabio Estevam, Michael Turquette, Miles Chen,
NXP Linux Team, Pengutronix Kernel Team, Sascha Hauer, Shawn Guo
Cc: linux-clk, linux-arm-kernel, linux-kernel, linux-mediatek,
wsd_upstream, Miles Chen
Quoting Miles Chen (2021-09-04 16:54:18)
> Replace builtin_platform_driver_probe with module_platform_driver_probe
> because CONFIG_CLK_IMX8QXP can be set to =m (kernel module).
>
> Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
>
> ---
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3] clk: imx: use module_platform_driver
2021-09-05 20:42 ` Stephen Boyd
@ 2021-11-05 5:59 ` miles.chen
2021-11-20 20:37 ` Abel Vesa
0 siblings, 1 reply; 7+ messages in thread
From: miles.chen @ 2021-11-05 5:59 UTC (permalink / raw)
To: sboyd
Cc: abel.vesa, festevam, kernel, linux-arm-kernel, linux-clk,
linux-imx, linux-kernel, linux-mediatek, miles.chen, mturquette,
s.hauer, shawnguo, wsd_upstream
From: Miles Chen <miles.chen@mediatek.com>
Hi Stephen,
>> Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
>> Cc: Fabio Estevam <festevam@gmail.com>
>> Cc: Stephen Boyd <sboyd@kernel.org>
>> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
> Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Thanks for doing the review, I cannot find this patch in clk-imx tree,
Would you pick this patch, please?
Miles
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3] clk: imx: use module_platform_driver
2021-11-05 5:59 ` miles.chen
@ 2021-11-20 20:37 ` Abel Vesa
2021-12-03 1:57 ` Stephen Boyd
0 siblings, 1 reply; 7+ messages in thread
From: Abel Vesa @ 2021-11-20 20:37 UTC (permalink / raw)
To: miles.chen
Cc: sboyd, festevam, kernel, linux-arm-kernel, linux-clk, linux-imx,
linux-kernel, linux-mediatek, mturquette, s.hauer, shawnguo,
wsd_upstream
On 21-11-05 13:59:32, miles.chen@mediatek.com wrote:
> From: Miles Chen <miles.chen@mediatek.com>
>
> Hi Stephen,
>
> >> Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
> >> Cc: Fabio Estevam <festevam@gmail.com>
> >> Cc: Stephen Boyd <sboyd@kernel.org>
> >> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
>
> > Reviewed-by: Stephen Boyd <sboyd@kernel.org>
>
> Thanks for doing the review, I cannot find this patch in clk-imx tree,
> Would you pick this patch, please?
Sorry for the delay.
Fixes are usually picked up directly by Stephen,
therefore they're not going through clk-imx tree.
Stephen, can you pick this one up please?
>
> Miles
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3] clk: imx: use module_platform_driver
2021-11-20 20:37 ` Abel Vesa
@ 2021-12-03 1:57 ` Stephen Boyd
2021-12-13 11:27 ` Abel Vesa
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Boyd @ 2021-12-03 1:57 UTC (permalink / raw)
To: Abel Vesa, miles.chen
Cc: festevam, kernel, linux-arm-kernel, linux-clk, linux-imx,
linux-kernel, linux-mediatek, mturquette, s.hauer, shawnguo,
wsd_upstream
Quoting Abel Vesa (2021-11-20 12:37:24)
> On 21-11-05 13:59:32, miles.chen@mediatek.com wrote:
> > From: Miles Chen <miles.chen@mediatek.com>
> >
> > Hi Stephen,
> >
> > >> Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
> > >> Cc: Fabio Estevam <festevam@gmail.com>
> > >> Cc: Stephen Boyd <sboyd@kernel.org>
> > >> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
> >
> > > Reviewed-by: Stephen Boyd <sboyd@kernel.org>
> >
> > Thanks for doing the review, I cannot find this patch in clk-imx tree,
> > Would you pick this patch, please?
>
> Sorry for the delay.
>
> Fixes are usually picked up directly by Stephen,
> therefore they're not going through clk-imx tree.
>
> Stephen, can you pick this one up please?
>
It doesn't look like a very critical fix but ok. I suppose someone could
try to use =m for these files?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3] clk: imx: use module_platform_driver
2021-12-03 1:57 ` Stephen Boyd
@ 2021-12-13 11:27 ` Abel Vesa
0 siblings, 0 replies; 7+ messages in thread
From: Abel Vesa @ 2021-12-13 11:27 UTC (permalink / raw)
To: Stephen Boyd
Cc: miles.chen, festevam, kernel, linux-arm-kernel, linux-clk,
linux-imx, linux-kernel, linux-mediatek, mturquette, s.hauer,
shawnguo, wsd_upstream
On 21-12-02 17:57:13, Stephen Boyd wrote:
> Quoting Abel Vesa (2021-11-20 12:37:24)
> > On 21-11-05 13:59:32, miles.chen@mediatek.com wrote:
> > > From: Miles Chen <miles.chen@mediatek.com>
> > >
> > > Hi Stephen,
> > >
> > > >> Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
> > > >> Cc: Fabio Estevam <festevam@gmail.com>
> > > >> Cc: Stephen Boyd <sboyd@kernel.org>
> > > >> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
> > >
> > > > Reviewed-by: Stephen Boyd <sboyd@kernel.org>
> > >
> > > Thanks for doing the review, I cannot find this patch in clk-imx tree,
> > > Would you pick this patch, please?
> >
> > Sorry for the delay.
> >
> > Fixes are usually picked up directly by Stephen,
> > therefore they're not going through clk-imx tree.
> >
> > Stephen, can you pick this one up please?
> >
>
> It doesn't look like a very critical fix but ok. I suppose someone could
> try to use =m for these files?
Yes. I think this is for GKI.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-12-13 11:27 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-04 23:54 [PATCH v3] clk: imx: use module_platform_driver Miles Chen
2021-09-05 0:44 ` Fabio Estevam
2021-09-05 20:42 ` Stephen Boyd
2021-11-05 5:59 ` miles.chen
2021-11-20 20:37 ` Abel Vesa
2021-12-03 1:57 ` Stephen Boyd
2021-12-13 11:27 ` Abel Vesa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).