* Re: [PATCH v5 2/3] firmware: mediatek: add adsp ipc protocol interface [not found] ` <20211126071432.21990-3-allen-kh.cheng@mediatek.com> @ 2021-11-26 7:32 ` Tzung-Bi Shih 0 siblings, 0 replies; 2+ messages in thread From: Tzung-Bi Shih @ 2021-11-26 7:32 UTC (permalink / raw) To: allen-kh.cheng Cc: Mark Brown, Rob Herring, Matthias Brugger, Jassi Brar, devicetree, Linux-ALSA, Kai Vehmanen, Liam Girdwood, cujomalainey, linux-kernel, Takashi Iwai, Ranjani Sridharan, Pierre-Louis Bossart, Project_Global_Chrome_Upstream_Group, linux-mediatek, Daniel Baluta, linux-arm-kernel, sound-open-firmware On Fri, Nov 26, 2021 at 03:14:31PM +0800, allen-kh.cheng wrote: > Signed-off-by: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> Reviewed-by: Tzung-Bi Shih <tzungbi@google.com> ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <20211126071432.21990-4-allen-kh.cheng@mediatek.com>]
* Re: [PATCH v5 3/3] mailbox: mediatek: add support for adsp mailbox controller [not found] ` <20211126071432.21990-4-allen-kh.cheng@mediatek.com> @ 2021-11-26 7:32 ` Tzung-Bi Shih 0 siblings, 0 replies; 2+ messages in thread From: Tzung-Bi Shih @ 2021-11-26 7:32 UTC (permalink / raw) To: allen-kh.cheng Cc: Mark Brown, Rob Herring, Matthias Brugger, Jassi Brar, Linux-ALSA, cujomalainey, Pierre-Louis Bossart, Liam Girdwood, Ranjani Sridharan, Kai Vehmanen, Daniel Baluta, Jaroslav Kysela, Takashi Iwai, Project_Global_Chrome_Upstream_Group, linux-kernel, devicetree, linux-arm-kernel, linux-mediatek, sound-open-firmware On Fri, Nov 26, 2021 at 03:14:32PM +0800, allen-kh.cheng wrote: > diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c [...] > +static bool mtk_adsp_mbox_last_tx_done(struct mbox_chan *chan) > +{ > + struct adsp_mbox_ch_info *ch_info = chan->con_priv; > + void __iomem *reg = ch_info->va_reg; > + > + return readl(reg + MTK_ADSP_MBOX_IN_CMD) == 0 ? true : false; The expression "readl(...) == 0" should be already a boolean. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-26 7:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20211126071432.21990-1-allen-kh.cheng@mediatek.com>
[not found] ` <20211126071432.21990-3-allen-kh.cheng@mediatek.com>
2021-11-26 7:32 ` [PATCH v5 2/3] firmware: mediatek: add adsp ipc protocol interface Tzung-Bi Shih
[not found] ` <20211126071432.21990-4-allen-kh.cheng@mediatek.com>
2021-11-26 7:32 ` [PATCH v5 3/3] mailbox: mediatek: add support for adsp mailbox controller Tzung-Bi Shih
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).