From: Greg KH <gregkh@linuxfoundation.org>
To: luizluca@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, alsi@bang-olufsen.dk
Subject: Re: [PATCH v2] net: dsa: realtek-smi: fix indirect reg access for ports>3
Date: Fri, 26 Nov 2021 09:21:03 +0100 [thread overview]
Message-ID: <YaCY76T9ZWPKtKn1@kroah.com> (raw)
In-Reply-To: <20211126081252.32254-1-luizluca@gmail.com>
On Fri, Nov 26, 2021 at 05:12:52AM -0300, luizluca@gmail.com wrote:
> From: Luiz Angelo Daros de Luca <luizluca@gmail.com>
>
> This switch family can have up to 8 ports {0..7}. However,
> INDIRECT_ACCESS_ADDRESS_PHYNUM_MASK was using 2 bits instead of 3,
> dropping the most significant bit during indirect register reads and
> writes. Reading or writing ports 4, 5, 6, and 7 registers was actually
> manipulating, respectively, ports 0, 1, 2, and 3 registers.
>
> rtl8365mb_phy_{read,write} will now returns -EINVAL if phy is greater
> than 7.
>
> v2:
> - fix affected ports in commit message
>
> Fixes: 4af2950c50c8 ("net: dsa: realtek-smi: add rtl8365mb subdriver for RTL8365MB-VC")
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
> ---
> drivers/net/dsa/rtl8365mb.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2021-11-26 8:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 6:36 [PATCH] net: dsa: realtek-smi: fix indirect reg access for ports>4 luizluca
2021-11-26 8:12 ` [PATCH v2] net: dsa: realtek-smi: fix indirect reg access for ports>3 luizluca
2021-11-26 8:21 ` Greg KH [this message]
2021-11-26 9:34 ` Alvin Šipraga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaCY76T9ZWPKtKn1@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alsi@bang-olufsen.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=luizluca@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).