* Re: [PATCH v7 1/3] dt-bindings: mediatek: add adsp-mbox document [not found] ` <20211129063954.1616-2-allen-kh.cheng@mediatek.com> @ 2021-11-29 7:10 ` Tzung-Bi Shih 0 siblings, 0 replies; 3+ messages in thread From: Tzung-Bi Shih @ 2021-11-29 7:10 UTC (permalink / raw) To: allen-kh.cheng Cc: Mark Brown, Rob Herring, Matthias Brugger, Jassi Brar, Linux-ALSA, cujomalainey, Pierre-Louis Bossart, Liam Girdwood, Ranjani Sridharan, Kai Vehmanen, Daniel Baluta, Jaroslav Kysela, Takashi Iwai, Project_Global_Chrome_Upstream_Group, linux-kernel, devicetree, linux-arm-kernel, linux-mediatek, sound-open-firmware On Mon, Nov 29, 2021 at 02:39:52PM +0800, allen-kh.cheng wrote: > From: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> > > This patch adds document for mediatek adsp mbox > > Reviewed-by: Tzung-Bi Shih <tzungbi@google.com> > Reviewed-by: AngeloGioacchino Del Regno<angelogioacchino.delregno@collabora.com> > Signed-off-by: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> Neither AngeloGioacchino Del Regno nor myself provided the R-b tags for the patch. Please remove them. ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <20211129063954.1616-3-allen-kh.cheng@mediatek.com>]
* Re: [PATCH v7 2/3] firmware: mediatek: add adsp ipc protocol interface [not found] ` <20211129063954.1616-3-allen-kh.cheng@mediatek.com> @ 2021-11-29 7:11 ` Tzung-Bi Shih 0 siblings, 0 replies; 3+ messages in thread From: Tzung-Bi Shih @ 2021-11-29 7:11 UTC (permalink / raw) To: allen-kh.cheng Cc: Mark Brown, Rob Herring, Matthias Brugger, Jassi Brar, Linux-ALSA, cujomalainey, Pierre-Louis Bossart, Liam Girdwood, Ranjani Sridharan, Kai Vehmanen, Daniel Baluta, Jaroslav Kysela, Takashi Iwai, Project_Global_Chrome_Upstream_Group, linux-kernel, devicetree, linux-arm-kernel, linux-mediatek, sound-open-firmware On Mon, Nov 29, 2021 at 02:39:53PM +0800, allen-kh.cheng wrote: > Reviewed-by: Tzung-Bi Shih <tzungbi@google.com> > Reviewed-by: AngeloGioacchino Del Regno<angelogioacchino.delregno@collabora.com> > Signed-off-by: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> Please double check again if you use the R-b tags correctly. I have provided my R-b tag before but have some more minor comments below. With the minor comments: Reviewed-by: Tzung-Bi Shih <tzungbi@google.com> > diff --git a/drivers/firmware/mediatek/mtk-adsp-ipc.c b/drivers/firmware/mediatek/mtk-adsp-ipc.c [...] > +int adsp_ipc_send(struct mtk_adsp_ipc *ipc, unsigned int idx, uint32_t op) > +{ > + struct mtk_adsp_chan *dsp_chan; > + struct adsp_mbox_ch_info *ch_info; > + int ret; > + > + if (idx >= MTK_ADSP_MBOX_NUM) > + return -EINVAL; > + > + dsp_chan = &ipc->chans[idx]; > + ch_info = dsp_chan->ch->con_priv; > + ch_info->ipc_op_val = op; > + ret = mbox_send_message(dsp_chan->ch, NULL); > + if (ret < 0) > + return ret; > + > + return 0; > +} > +EXPORT_SYMBOL(adsp_ipc_send); To be neat, I think use mtk_adsp for all names looks better. I.e. s/adsp_ipc_send/mtk_adsp_ipc_send/. > +static void adsp_ipc_recv(struct mbox_client *c, void *msg) > +{ Ditto, mtk_adsp_ipc_recv looks better to me. > diff --git a/include/linux/firmware/mediatek/mtk-adsp-ipc.h b/include/linux/firmware/mediatek/mtk-adsp-ipc.h [...] > +struct adsp_mbox_ch_info { > + u32 ipc_op_val; > + void __iomem *va_reg; > +}; Ditto, mtk_adsp_mbox_ch_info. > +static inline void adsp_ipc_set_data(struct mtk_adsp_ipc *ipc, void *data) > +{ mtk_adsp_ipc_set_data, although there is no use case yet. > +static inline void *adsp_ipc_get_data(struct mtk_adsp_ipc *ipc) > +{ mtk_adsp_ipc_get_data, although there is no use case yet. ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <20211129063954.1616-4-allen-kh.cheng@mediatek.com>]
* Re: [PATCH v7 3/3] mailbox: mediatek: add support for adsp mailbox controller [not found] ` <20211129063954.1616-4-allen-kh.cheng@mediatek.com> @ 2021-11-29 7:12 ` Tzung-Bi Shih 0 siblings, 0 replies; 3+ messages in thread From: Tzung-Bi Shih @ 2021-11-29 7:12 UTC (permalink / raw) To: allen-kh.cheng Cc: Mark Brown, Rob Herring, Matthias Brugger, Jassi Brar, Linux-ALSA, cujomalainey, Pierre-Louis Bossart, Liam Girdwood, Ranjani Sridharan, Kai Vehmanen, Daniel Baluta, Jaroslav Kysela, Takashi Iwai, Project_Global_Chrome_Upstream_Group, linux-kernel, devicetree, linux-arm-kernel, linux-mediatek, sound-open-firmware On Mon, Nov 29, 2021 at 02:39:54PM +0800, allen-kh.cheng wrote: > From: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> > > This patch is to for MediaTek ADSP IPC mailbox controller driver > It is used to send short messages between processors with adsp > > Reviewed-by: Tzung-Bi Shih <tzungbi@google.com> > Reviewed-by: AngeloGioacchino Del Regno<angelogioacchino.delregno@collabora.com> > Signed-off-by: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> Please double check again if you use the R-b tags correctly. I have provided my R-b tag before but have some more minor comments below. With the minor comments: Reviewed-by: Tzung-Bi Shih <tzungbi@google.com> > diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c [...] > +static const struct mbox_chan_ops adsp_mbox_chan_ops = { > + .send_data = mtk_adsp_mbox_send_data, > + .startup = mtk_adsp_mbox_startup, > + .shutdown = mtk_adsp_mbox_shutdown, > + .last_tx_done = mtk_adsp_mbox_last_tx_done, > +}; Rename adsp_mbox_chan_ops to mtk_adsp_mbox_chan_ops looks better to me. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-29 7:14 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20211129063954.1616-1-allen-kh.cheng@mediatek.com> [not found] ` <20211129063954.1616-2-allen-kh.cheng@mediatek.com> 2021-11-29 7:10 ` [PATCH v7 1/3] dt-bindings: mediatek: add adsp-mbox document Tzung-Bi Shih [not found] ` <20211129063954.1616-3-allen-kh.cheng@mediatek.com> 2021-11-29 7:11 ` [PATCH v7 2/3] firmware: mediatek: add adsp ipc protocol interface Tzung-Bi Shih [not found] ` <20211129063954.1616-4-allen-kh.cheng@mediatek.com> 2021-11-29 7:12 ` [PATCH v7 3/3] mailbox: mediatek: add support for adsp mailbox controller Tzung-Bi Shih
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).