From: Wolfram Sang <wsa@kernel.org>
To: Dejin Zheng <zhengdejin5@gmail.com>
Cc: helgaas@kernel.org, corbet@lwn.net,
jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com,
mika.westerberg@linux.intel.com, rric@kernel.org,
bhelgaas@google.com, Sanket.Goswami@amd.com,
linux-doc@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 3/4] i2c: designware: Use pcim_alloc_irq_vectors() to allocate IRQ vectors
Date: Mon, 29 Nov 2021 20:15:48 +0100 [thread overview]
Message-ID: <YaUm5NBr/Pb/i0Vv@kunai> (raw)
In-Reply-To: <20210607153916.1021016-4-zhengdejin5@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 942 bytes --]
On Mon, Jun 07, 2021 at 11:39:15PM +0800, Dejin Zheng wrote:
> The pcim_alloc_irq_vectors() function, an explicit device-managed version
> of pci_alloc_irq_vectors(). If pcim_enable_device() has been called
> before, then pci_alloc_irq_vectors() is actually a device-managed
> function. It is used here as a device-managed function, So replace it
> with pcim_alloc_irq_vectors(). At the same time, Remove the
> pci_free_irq_vectors() function to simplify the error handling path.
> the freeing resources will take automatically when device is gone.
>
> Reviewed-by: Robert Richter <rric@kernel.org>
> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
Dunno the status of this series, but if it ever goes upstream, I am fine
with the I2C changes:
Acked-by: Wolfram Sang <wsa@kernel.org> # for I2C
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-11-29 22:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 15:39 [PATCH v7 0/4] Introduce pcim_alloc_irq_vectors() Dejin Zheng
2021-06-07 15:39 ` [PATCH v7 1/4] PCI: " Dejin Zheng
2021-06-07 16:12 ` Andy Shevchenko
2021-06-07 17:14 ` Bjorn Helgaas
2021-06-08 14:23 ` Dejin Zheng
2021-06-08 14:20 ` Dejin Zheng
2021-06-10 22:41 ` Bjorn Helgaas
2021-06-11 9:37 ` Andy Shevchenko
2021-06-16 19:25 ` Bjorn Helgaas
2021-06-17 13:20 ` Andy Shevchenko
2021-06-17 15:58 ` Bjorn Helgaas
2022-12-16 8:34 ` Andy Shevchenko
2021-06-17 17:17 ` Dejin Zheng
2022-02-24 11:07 ` Christoph Hellwig
2021-06-07 15:39 ` [PATCH v7 2/4] Documentation: devres: Add pcim_alloc_irq_vectors() Dejin Zheng
2021-06-07 16:13 ` Andy Shevchenko
2021-06-07 15:39 ` [PATCH v7 3/4] i2c: designware: Use pcim_alloc_irq_vectors() to allocate IRQ vectors Dejin Zheng
2021-11-29 19:15 ` Wolfram Sang [this message]
2021-06-07 15:39 ` [PATCH v7 4/4] i2c: thunderx: " Dejin Zheng
2021-11-29 19:16 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaUm5NBr/Pb/i0Vv@kunai \
--to=wsa@kernel.org \
--cc=Sanket.Goswami@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=helgaas@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rric@kernel.org \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).