* [PATCH 1/2] arm64: dts: Place LG Bullhead generic code into a DTSI file
@ 2021-11-30 22:56 Jean THOMAS
2021-11-30 22:56 ` [PATCH 2/2] arm64: dts: Add support for LG Bullhead rev 1.0 Jean THOMAS
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jean THOMAS @ 2021-11-30 22:56 UTC (permalink / raw)
To: virgule, devicetree
Cc: linux-arm-msm, linux-kernel, ~postmarketos/upstreaming, petr.vorel
This patch puts the generic code common across all hardware revisions
into a DTSI file.
It also prefixes the DTS filename with the vendor name, to follow the
naming convention used by other DTS files.
---
arch/arm64/boot/dts/qcom/Makefile | 2 +-
.../boot/dts/qcom/msm8992-lg-bullhead-rev-101.dts | 12 ++++++++++++
...bullhead-rev-101.dts => msm8992-lg-bullhead.dtsi} | 2 --
3 files changed, 13 insertions(+), 3 deletions(-)
create mode 100644 arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-101.dts
rename arch/arm64/boot/dts/qcom/{msm8992-bullhead-rev-101.dts => msm8992-lg-bullhead.dtsi} (98%)
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 6b816eb33309..3617157f1420 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -17,7 +17,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-a3u-eur.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-a5u-eur.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-serranove.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt88047.dtb
-dtb-$(CONFIG_ARCH_QCOM) += msm8992-bullhead-rev-101.dtb
+dtb-$(CONFIG_ARCH_QCOM) += msm8992-lg-bullhead-rev-101.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8992-msft-lumia-octagon-talkman.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8992-xiaomi-libra.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8994-angler-rev-101.dtb
diff --git a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-101.dts
new file mode 100644
index 000000000000..5151c6128b09
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-101.dts
@@ -0,0 +1,12 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/* Copyright (c) Jean Thomas <virgule@jeanthomas.me>
+ */
+
+/dts-v1/;
+
+#include "msm8992-lg-bullhead.dtsi"
+
+/ {
+ /* required for bootloader to select correct board */
+ qcom,board-id = <0xb64 0>;
+};
diff --git a/arch/arm64/boot/dts/qcom/msm8992-bullhead-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
similarity index 98%
rename from arch/arm64/boot/dts/qcom/msm8992-bullhead-rev-101.dts
rename to arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
index 4da6c44bf532..3b0cc85d6674 100644
--- a/arch/arm64/boot/dts/qcom/msm8992-bullhead-rev-101.dts
+++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
@@ -18,9 +18,7 @@ / {
compatible = "lg,bullhead", "qcom,msm8992";
chassis-type = "handset";
- /* required for bootloader to select correct board */
qcom,msm-id = <251 0>, <252 0>;
- qcom,board-id = <0xb64 0>;
qcom,pmic-id = <0x10009 0x1000A 0x0 0x0>;
/* Bullhead firmware doesn't support PSCI */
--
2.33.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm64: dts: Add support for LG Bullhead rev 1.0
2021-11-30 22:56 [PATCH 1/2] arm64: dts: Place LG Bullhead generic code into a DTSI file Jean THOMAS
@ 2021-11-30 22:56 ` Jean THOMAS
2021-11-30 23:27 ` Petr Vorel
2021-11-30 23:07 ` [PATCH 1/2] arm64: dts: Place LG Bullhead generic code into a DTSI file Petr Vorel
2021-11-30 23:31 ` Petr Vorel
2 siblings, 1 reply; 6+ messages in thread
From: Jean THOMAS @ 2021-11-30 22:56 UTC (permalink / raw)
To: virgule, devicetree
Cc: linux-arm-msm, linux-kernel, ~postmarketos/upstreaming, petr.vorel
This commit implements a DTS file for LG Bullhead (Nexus 5X) rev 1.0
with its matching "qcom,board-id" property.
---
arch/arm64/boot/dts/qcom/Makefile | 1 +
.../boot/dts/qcom/msm8992-lg-bullhead-rev-10.dts | 12 ++++++++++++
2 files changed, 13 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-10.dts
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 3617157f1420..17aa096f8b99 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -17,6 +17,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-a3u-eur.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-a5u-eur.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-serranove.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt88047.dtb
+dtb-$(CONFIG_ARCH_QCOM) += msm8992-lg-bullhead-rev-10.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8992-lg-bullhead-rev-101.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8992-msft-lumia-octagon-talkman.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8992-xiaomi-libra.dtb
diff --git a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-10.dts b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-10.dts
new file mode 100644
index 000000000000..4d2bea67c646
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-10.dts
@@ -0,0 +1,12 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/* Copyright (c) Jean Thomas <virgule@jeanthomas.me>
+ */
+
+/dts-v1/;
+
+#include "msm8992-lg-bullhead.dtsi"
+
+/ {
+ /* required for bootloader to select correct board */
+ qcom,board-id = <0xa64 0>;
+};
--
2.33.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm64: dts: Place LG Bullhead generic code into a DTSI file
2021-11-30 22:56 [PATCH 1/2] arm64: dts: Place LG Bullhead generic code into a DTSI file Jean THOMAS
2021-11-30 22:56 ` [PATCH 2/2] arm64: dts: Add support for LG Bullhead rev 1.0 Jean THOMAS
@ 2021-11-30 23:07 ` Petr Vorel
2021-11-30 23:31 ` Petr Vorel
2 siblings, 0 replies; 6+ messages in thread
From: Petr Vorel @ 2021-11-30 23:07 UTC (permalink / raw)
To: Jean THOMAS
Cc: devicetree, linux-arm-msm, linux-kernel, ~postmarketos/upstreaming
Hi Jean,
> This patch puts the generic code common across all hardware revisions
> into a DTSI file.
> It also prefixes the DTS filename with the vendor name, to follow the
> naming convention used by other DTS files.
Maybe nobody cares, but IMHO it'd be better to put the rename into separate
commit. Otherwise LGTM.
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Kind regards,
Petr
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] arm64: dts: Add support for LG Bullhead rev 1.0
2021-11-30 22:56 ` [PATCH 2/2] arm64: dts: Add support for LG Bullhead rev 1.0 Jean THOMAS
@ 2021-11-30 23:27 ` Petr Vorel
2021-12-01 23:20 ` Jean THOMAS
0 siblings, 1 reply; 6+ messages in thread
From: Petr Vorel @ 2021-11-30 23:27 UTC (permalink / raw)
To: Jean THOMAS
Cc: devicetree, linux-arm-msm, linux-kernel,
~postmarketos/upstreaming, Konrad Dybcio
Hi Jean,
[ Cc Konrad ]
> This commit implements a DTS file for LG Bullhead (Nexus 5X) rev 1.0
> with its matching "qcom,board-id" property.
I wonder if each of new dtb files should contain updated models
msm8992-lg-bullhead-rev-10.dtb:
model = "LG Nexus 5X rev 1.0";
msm8992-lg-bullhead-rev-101.dtb:
model = "LG Nexus 5X rev 1.01";
as it's in downstream sources. Because 10 and 101 are a bit cryptic values.
Otherwise LGTM.
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Kind regards,
Petr
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm64: dts: Place LG Bullhead generic code into a DTSI file
2021-11-30 22:56 [PATCH 1/2] arm64: dts: Place LG Bullhead generic code into a DTSI file Jean THOMAS
2021-11-30 22:56 ` [PATCH 2/2] arm64: dts: Add support for LG Bullhead rev 1.0 Jean THOMAS
2021-11-30 23:07 ` [PATCH 1/2] arm64: dts: Place LG Bullhead generic code into a DTSI file Petr Vorel
@ 2021-11-30 23:31 ` Petr Vorel
2 siblings, 0 replies; 6+ messages in thread
From: Petr Vorel @ 2021-11-30 23:31 UTC (permalink / raw)
To: Jean THOMAS
Cc: devicetree, linux-arm-msm, linux-kernel, ~postmarketos/upstreaming
Hi Jean,
Also, very minor nit:
subject could contain also "msm8992-lg-bullhead:", i.e.:
arm64: dts: msm8992-lg-bullhead:
Kind regards,
Petr
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] arm64: dts: Add support for LG Bullhead rev 1.0
2021-11-30 23:27 ` Petr Vorel
@ 2021-12-01 23:20 ` Jean THOMAS
0 siblings, 0 replies; 6+ messages in thread
From: Jean THOMAS @ 2021-12-01 23:20 UTC (permalink / raw)
To: Petr Vorel
Cc: devicetree, linux-arm-msm, linux-kernel,
~postmarketos/upstreaming, Konrad Dybcio
Hi Petr,
Thanks for your review.
> I wonder if each of new dtb files should contain updated models
>
> msm8992-lg-bullhead-rev-10.dtb:
> model = "LG Nexus 5X rev 1.0";
>
> msm8992-lg-bullhead-rev-101.dtb:
> model = "LG Nexus 5X rev 1.01";
>
> as it's in downstream sources. Because 10 and 101 are a bit cryptic
> values.
I fixed this in v2.
Regards,
Jean.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-12-01 23:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-30 22:56 [PATCH 1/2] arm64: dts: Place LG Bullhead generic code into a DTSI file Jean THOMAS
2021-11-30 22:56 ` [PATCH 2/2] arm64: dts: Add support for LG Bullhead rev 1.0 Jean THOMAS
2021-11-30 23:27 ` Petr Vorel
2021-12-01 23:20 ` Jean THOMAS
2021-11-30 23:07 ` [PATCH 1/2] arm64: dts: Place LG Bullhead generic code into a DTSI file Petr Vorel
2021-11-30 23:31 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).