linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] cgroup: fix a typo in comment
@ 2021-12-01  1:17 Wei Yang
  2021-12-01 16:50 ` Tejun Heo
  0 siblings, 1 reply; 4+ messages in thread
From: Wei Yang @ 2021-12-01  1:17 UTC (permalink / raw)
  To: tj, lizefan.x, hannes; +Cc: cgroups, linux-kernel, Wei Yang

In commit 8699b7762a62 ("cgroup: s/child_subsys_mask/subtree_ss_mask/"),
we rename child_subsys_mask to subtree_ss_mask. While it missed to
rename this in comment.

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
 include/linux/cgroup-defs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/cgroup-defs.h b/include/linux/cgroup-defs.h
index 4649d09396fd..e4763c892a3b 100644
--- a/include/linux/cgroup-defs.h
+++ b/include/linux/cgroup-defs.h
@@ -413,7 +413,7 @@ struct cgroup {
 	/*
 	 * The bitmask of subsystems enabled on the child cgroups.
 	 * ->subtree_control is the one configured through
-	 * "cgroup.subtree_control" while ->child_ss_mask is the effective
+	 * "cgroup.subtree_control" while ->subtree_ss_mask is the effective
 	 * one which may have more subsystems enabled.  Controller knobs
 	 * are made available iff it's enabled in ->subtree_control.
 	 */
-- 
2.33.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] cgroup: fix a typo in comment
  2021-12-01  1:17 [PATCH] cgroup: fix a typo in comment Wei Yang
@ 2021-12-01 16:50 ` Tejun Heo
  0 siblings, 0 replies; 4+ messages in thread
From: Tejun Heo @ 2021-12-01 16:50 UTC (permalink / raw)
  To: Wei Yang; +Cc: lizefan.x, hannes, cgroups, linux-kernel

On Wed, Dec 01, 2021 at 01:17:36AM +0000, Wei Yang wrote:
> In commit 8699b7762a62 ("cgroup: s/child_subsys_mask/subtree_ss_mask/"),
> we rename child_subsys_mask to subtree_ss_mask. While it missed to
> rename this in comment.
> 
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>

Applied to cgroup/for-5.17.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] cgroup: fix a typo in comment.
  2014-08-25 11:27 Dongsheng Yang
@ 2014-08-25 14:50 ` Tejun Heo
  0 siblings, 0 replies; 4+ messages in thread
From: Tejun Heo @ 2014-08-25 14:50 UTC (permalink / raw)
  To: Dongsheng Yang; +Cc: lizefan, cgroups, linux-kernel

On Mon, Aug 25, 2014 at 07:27:52PM +0800, Dongsheng Yang wrote:
> There is no function named cgroup_enable_task_cg_links().
> Instead, the correct function name in this comment should
> be cgroup_enabled_task_cg_lists().
> 
> Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>

Applied to cgroup/for-3.18.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] cgroup: fix a typo in comment.
@ 2014-08-25 11:27 Dongsheng Yang
  2014-08-25 14:50 ` Tejun Heo
  0 siblings, 1 reply; 4+ messages in thread
From: Dongsheng Yang @ 2014-08-25 11:27 UTC (permalink / raw)
  To: tj, lizefan; +Cc: cgroups, linux-kernel, Dongsheng Yang

There is no function named cgroup_enable_task_cg_links().
Instead, the correct function name in this comment should
be cgroup_enabled_task_cg_lists().

Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
---
 kernel/cgroup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 7dc8788..64bbb56 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -5161,7 +5161,7 @@ void cgroup_post_fork(struct task_struct *child)
 	int i;
 
 	/*
-	 * This may race against cgroup_enable_task_cg_links().  As that
+	 * This may race against cgroup_enable_task_cg_lists().  As that
 	 * function sets use_task_css_set_links before grabbing
 	 * tasklist_lock and we just went through tasklist_lock to add
 	 * @child, it's guaranteed that either we see the set
@@ -5176,7 +5176,7 @@ void cgroup_post_fork(struct task_struct *child)
 	 * when implementing operations which need to migrate all tasks of
 	 * a cgroup to another.
 	 *
-	 * Note that if we lose to cgroup_enable_task_cg_links(), @child
+	 * Note that if we lose to cgroup_enable_task_cg_lists(), @child
 	 * will remain in init_css_set.  This is safe because all tasks are
 	 * in the init_css_set before cg_links is enabled and there's no
 	 * operation which transfers all tasks out of init_css_set.
-- 
1.8.4.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-12-01 16:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-01  1:17 [PATCH] cgroup: fix a typo in comment Wei Yang
2021-12-01 16:50 ` Tejun Heo
  -- strict thread matches above, loose matches on Subject: below --
2014-08-25 11:27 Dongsheng Yang
2014-08-25 14:50 ` Tejun Heo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).