From: Eric Biggers <ebiggers@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations
Date: Wed, 1 Dec 2021 20:15:59 -0800 [thread overview]
Message-ID: <YahIf3UlhuxJT1O4@sol.localdomain> (raw)
In-Reply-To: <b36e2d44-4834-3931-6a32-4fa52d1d7785@kernel.org>
On Thu, Dec 02, 2021 at 11:10:41AM +0800, Chao Yu wrote:
> > +static int f2fs_iomap_begin(struct inode *inode, loff_t offset, loff_t length,
> > + unsigned int flags, struct iomap *iomap,
> > + struct iomap *srcmap)
> > +{
> > + struct f2fs_map_blocks map = {};
> > + pgoff_t next_pgofs = 0;
> > + int err;
> > +
> > + map.m_lblk = bytes_to_blks(inode, offset);
> > + map.m_len = bytes_to_blks(inode, offset + length - 1) - map.m_lblk + 1;
> > + map.m_next_pgofs = &next_pgofs;
> > + map.m_seg_type = f2fs_rw_hint_to_seg_type(inode->i_write_hint);
> > + if (flags & IOMAP_WRITE)
> > + map.m_may_create = true;
> > +
> > + err = f2fs_map_blocks(inode, &map, flags & IOMAP_WRITE,
> > + F2FS_GET_BLOCK_DIO);
> > + if (err)
> > + return err;
> > +
> > + iomap->offset = blks_to_bytes(inode, map.m_lblk);
> > +
> > + if (map.m_flags & (F2FS_MAP_MAPPED | F2FS_MAP_UNWRITTEN)) {
> > + iomap->length = blks_to_bytes(inode, map.m_len);
> > + if (map.m_flags & F2FS_MAP_MAPPED) {
> > + iomap->type = IOMAP_MAPPED;
> > + iomap->flags |= IOMAP_F_MERGED;
> > + } else {
> > + iomap->type = IOMAP_UNWRITTEN;
> > + }
> > + if (WARN_ON_ONCE(!__is_valid_data_blkaddr(map.m_pblk)))
> > + return -EINVAL;
> > + iomap->addr = blks_to_bytes(inode, map.m_pblk);
> > +
> > + if (WARN_ON_ONCE(f2fs_is_multi_device(F2FS_I_SB(inode))))
> > + return -EINVAL;
>
> Why not relocating this check before f2fs_map_blocks()?
>
> Thanks,
>
> > + iomap->bdev = inode->i_sb->s_bdev;
Are you talking about the check for !f2fs_is_multi_device()? It could go in
either location, but I think it makes the most sense to have it right before the
line that uses 'inode->i_sb->s_bdev', since that is the place which makes the
assumption that the filesystem has only one block device.
- Eric
next prev parent reply other threads:[~2021-12-02 4:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 21:45 [PATCH 1/6] f2fs: rework write preallocations Jaegeuk Kim
2021-11-16 21:45 ` [PATCH 2/6] f2fs: do not expose unwritten blocks to user by DIO Jaegeuk Kim
2021-11-17 15:16 ` [f2fs-dev] " Chao Yu
2021-11-17 19:32 ` Jaegeuk Kim
2021-11-23 6:59 ` [f2fs] e029ce2460: aim7.jobs-per-min -35.8% regression kernel test robot
2021-12-02 2:39 ` [f2fs-dev] [PATCH 2/6] f2fs: do not expose unwritten blocks to user by DIO Chao Yu
2021-12-02 18:13 ` Jaegeuk Kim
2021-12-03 6:43 ` Chao Yu
2021-12-03 22:53 ` Jaegeuk Kim
2021-12-04 19:01 ` [f2fs-dev] [PATCH 2/6 v2] " Jaegeuk Kim
2021-11-16 21:45 ` [PATCH 3/6] f2fs: reduce indentation in f2fs_file_write_iter() Jaegeuk Kim
2021-12-02 2:58 ` [f2fs-dev] " Chao Yu
2021-11-16 21:45 ` [PATCH 4/6] f2fs: fix the f2fs_file_write_iter tracepoint Jaegeuk Kim
2021-12-02 2:59 ` [f2fs-dev] " Chao Yu
2021-11-16 21:45 ` [PATCH 5/6] f2fs: implement iomap operations Jaegeuk Kim
2021-12-02 3:10 ` [f2fs-dev] " Chao Yu
2021-12-02 4:15 ` Eric Biggers [this message]
2021-12-02 14:04 ` Chao Yu
2021-12-02 18:25 ` Eric Biggers
2021-12-02 18:57 ` Jaegeuk Kim
2021-12-02 19:00 ` Jaegeuk Kim
2021-12-02 20:57 ` Eric Biggers
2021-12-02 21:19 ` Jaegeuk Kim
2021-12-02 21:28 ` Jaegeuk Kim
2021-12-03 6:51 ` Chao Yu
2021-12-30 6:43 ` Chao Yu
2022-01-04 21:15 ` Jaegeuk Kim
2021-11-16 21:45 ` [PATCH 6/6] f2fs: use iomap for direct I/O Jaegeuk Kim
2021-12-10 23:58 ` Jaegeuk Kim
2021-11-17 13:31 ` [f2fs-dev] [PATCH 1/6] f2fs: rework write preallocations Chao Yu
2021-11-17 19:27 ` Jaegeuk Kim
2021-11-18 6:47 ` Chao Yu
2022-01-04 21:24 Jaegeuk Kim
2022-01-04 21:24 ` [PATCH 5/6] f2fs: implement iomap operations Jaegeuk Kim
2022-01-05 13:20 ` [f2fs-dev] " Chao Yu
2022-01-05 18:25 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YahIf3UlhuxJT1O4@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).