From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: Eric Biggers <ebiggers@kernel.org>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations
Date: Tue, 4 Jan 2022 13:15:09 -0800 [thread overview]
Message-ID: <YdS43f15g1enklVX@google.com> (raw)
In-Reply-To: <ed10bb7a-af8c-d5a6-8bb1-a47559f78fbf@kernel.org>
On 12/30, Chao Yu wrote:
> On 2021/12/3 5:28, Jaegeuk Kim wrote:
> > On 12/02, Jaegeuk Kim wrote:
> > > On 12/02, Eric Biggers wrote:
> > > > On Thu, Dec 02, 2021 at 11:00:47AM -0800, Jaegeuk Kim wrote:
> > > > > On 12/02, Jaegeuk Kim wrote:
> > > > > > On 12/02, Eric Biggers wrote:
> > > > > > > On Thu, Dec 02, 2021 at 10:04:11PM +0800, Chao Yu wrote:
> > > > > > > > On 2021/12/2 12:15, Eric Biggers wrote:
> > > > > > > > > On Thu, Dec 02, 2021 at 11:10:41AM +0800, Chao Yu wrote:
> > > > > > > > > > Why not relocating this check before f2fs_map_blocks()?
> > > > > > > >
> > > > > > > > Wait, it supports DIO in multi-device image after commit 71f2c8206202
> > > > > > > > ("f2fs: multidevice: support direct IO"), how about
> > > > > > > > checking with f2fs_allow_multi_device_dio()?
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > >
> > > > > > >
> > > > > > > Okay, that was not the case when I sent this patch originally. We'll need to
> > > > > > > update this to support multiple devices.
> > > > > >
> > > > > > Chao/Eric, does this make sense?
> > > > > >
> > > > > > --- a/fs/f2fs/data.c
> > > > > > +++ b/fs/f2fs/data.c
> > > > > > @@ -4070,11 +4070,10 @@ static int f2fs_iomap_begin(struct inode *inode, loff_t offset, loff_t length,
> > > > > > }
> > > > > > if (WARN_ON_ONCE(!__is_valid_data_blkaddr(map.m_pblk)))
> > > > > > return -EINVAL;
> > > > > > - iomap->addr = blks_to_bytes(inode, map.m_pblk);
> > > > > >
> > > > > > - if (WARN_ON_ONCE(f2fs_is_multi_device(F2FS_I_SB(inode))))
> > > > > > - return -EINVAL;
> > > > > > - iomap->bdev = inode->i_sb->s_bdev;
> > > > > > + iomap->bdev = map->m_multidev_dio ? map.m_bdev :
> > > > >
> > > > > correction: map.m_multidev_dio
> > > > >
> > > >
> > > > I guess so, but why doesn't f2fs_map_blocks() just always set m_bdev to the
> > > > correct block device? What is the point of m_multidev_dio?
> > >
> > > It seems we can simply assign iomap->bdev = map.m_bdev, and remove
> > > map->m_multidev_dio.
> >
> > Ok, it was used in previous get_block flow, but I think it'd be worth to keep it
> > to show by f2fs_map_blocks tracepoint.
>
> The last version wasn't sent into mailing list?
No, will post it again soon.
>
> Thanks,
>
> >
> > >
> > > >
> > > > - Eric
> > >
> > >
> > > _______________________________________________
> > > Linux-f2fs-devel mailing list
> > > Linux-f2fs-devel@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> >
> >
> > _______________________________________________
> > Linux-f2fs-devel mailing list
> > Linux-f2fs-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-01-04 21:15 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 21:45 [PATCH 1/6] f2fs: rework write preallocations Jaegeuk Kim
2021-11-16 21:45 ` [PATCH 2/6] f2fs: do not expose unwritten blocks to user by DIO Jaegeuk Kim
2021-11-17 15:16 ` [f2fs-dev] " Chao Yu
2021-11-17 19:32 ` Jaegeuk Kim
2021-11-23 6:59 ` [f2fs] e029ce2460: aim7.jobs-per-min -35.8% regression kernel test robot
2021-12-02 2:39 ` [f2fs-dev] [PATCH 2/6] f2fs: do not expose unwritten blocks to user by DIO Chao Yu
2021-12-02 18:13 ` Jaegeuk Kim
2021-12-03 6:43 ` Chao Yu
2021-12-03 22:53 ` Jaegeuk Kim
2021-12-04 19:01 ` [f2fs-dev] [PATCH 2/6 v2] " Jaegeuk Kim
2021-11-16 21:45 ` [PATCH 3/6] f2fs: reduce indentation in f2fs_file_write_iter() Jaegeuk Kim
2021-12-02 2:58 ` [f2fs-dev] " Chao Yu
2021-11-16 21:45 ` [PATCH 4/6] f2fs: fix the f2fs_file_write_iter tracepoint Jaegeuk Kim
2021-12-02 2:59 ` [f2fs-dev] " Chao Yu
2021-11-16 21:45 ` [PATCH 5/6] f2fs: implement iomap operations Jaegeuk Kim
2021-12-02 3:10 ` [f2fs-dev] " Chao Yu
2021-12-02 4:15 ` Eric Biggers
2021-12-02 14:04 ` Chao Yu
2021-12-02 18:25 ` Eric Biggers
2021-12-02 18:57 ` Jaegeuk Kim
2021-12-02 19:00 ` Jaegeuk Kim
2021-12-02 20:57 ` Eric Biggers
2021-12-02 21:19 ` Jaegeuk Kim
2021-12-02 21:28 ` Jaegeuk Kim
2021-12-03 6:51 ` Chao Yu
2021-12-30 6:43 ` Chao Yu
2022-01-04 21:15 ` Jaegeuk Kim [this message]
2021-11-16 21:45 ` [PATCH 6/6] f2fs: use iomap for direct I/O Jaegeuk Kim
2021-12-10 23:58 ` Jaegeuk Kim
2021-11-17 13:31 ` [f2fs-dev] [PATCH 1/6] f2fs: rework write preallocations Chao Yu
2021-11-17 19:27 ` Jaegeuk Kim
2021-11-18 6:47 ` Chao Yu
2022-01-04 21:24 Jaegeuk Kim
2022-01-04 21:24 ` [PATCH 5/6] f2fs: implement iomap operations Jaegeuk Kim
2022-01-05 13:20 ` [f2fs-dev] " Chao Yu
2022-01-05 18:25 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdS43f15g1enklVX@google.com \
--to=jaegeuk@kernel.org \
--cc=chao@kernel.org \
--cc=ebiggers@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).