linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH v9 3/3] mailbox: mediatek: add support for adsp mailbox controller
       [not found] ` <20211201075604.27864-4-allen-kh.cheng@mediatek.com>
@ 2021-12-02  4:42   ` Tzung-Bi Shih
  0 siblings, 0 replies; 2+ messages in thread
From: Tzung-Bi Shih @ 2021-12-02  4:42 UTC (permalink / raw)
  To: allen-kh.cheng
  Cc: Mark Brown, Rob Herring, Matthias Brugger, Jassi Brar,
	Linux-ALSA, cujomalainey, Pierre-Louis Bossart, Liam Girdwood,
	Ranjani Sridharan, Kai Vehmanen, Daniel Baluta, Jaroslav Kysela,
	Takashi Iwai, Project_Global_Chrome_Upstream_Group, linux-kernel,
	devicetree, linux-arm-kernel, linux-mediatek,
	sound-open-firmware

On Wed, Dec 01, 2021 at 03:56:04PM +0800, allen-kh.cheng wrote:
> diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c
[...]
> +static const struct mbox_chan_ops adsp_mbox_chan_ops = {
> +	.send_data	= mtk_adsp_mbox_send_data,
> +	.startup	= mtk_adsp_mbox_startup,
> +	.shutdown	= mtk_adsp_mbox_shutdown,
> +	.last_tx_done	= mtk_adsp_mbox_last_tx_done,
> +};

To be consistent, s/adsp_mbox_chan_ops/mtk_adsp_mbox_chan_ops/.

With that,
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v9 2/3] firmware: mediatek: add adsp ipc protocol interface
       [not found] ` <20211201075604.27864-3-allen-kh.cheng@mediatek.com>
@ 2021-12-02  4:42   ` Tzung-Bi Shih
  0 siblings, 0 replies; 2+ messages in thread
From: Tzung-Bi Shih @ 2021-12-02  4:42 UTC (permalink / raw)
  To: allen-kh.cheng
  Cc: Mark Brown, Rob Herring, Matthias Brugger, Jassi Brar,
	Linux-ALSA, cujomalainey, Pierre-Louis Bossart, Liam Girdwood,
	Ranjani Sridharan, Kai Vehmanen, Daniel Baluta, Jaroslav Kysela,
	Takashi Iwai, Project_Global_Chrome_Upstream_Group, linux-kernel,
	devicetree, linux-arm-kernel, linux-mediatek,
	sound-open-firmware

On Wed, Dec 01, 2021 at 03:56:03PM +0800, allen-kh.cheng wrote:
> Signed-off-by: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com>

Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-02  4:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20211201075604.27864-1-allen-kh.cheng@mediatek.com>
     [not found] ` <20211201075604.27864-4-allen-kh.cheng@mediatek.com>
2021-12-02  4:42   ` [PATCH v9 3/3] mailbox: mediatek: add support for adsp mailbox controller Tzung-Bi Shih
     [not found] ` <20211201075604.27864-3-allen-kh.cheng@mediatek.com>
2021-12-02  4:42   ` [PATCH v9 2/3] firmware: mediatek: add adsp ipc protocol interface Tzung-Bi Shih

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).