From: Leon Romanovsky <leon@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
"David E. Box" <david.e.box@linux.intel.com>,
hdegoede@redhat.com, bhelgaas@google.com,
andriy.shevchenko@linux.intel.com, srinivas.pandruvada@intel.com,
shuah@kernel.org, mgross@linux.intel.com,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [V2 2/6] driver core: auxiliary bus: Add driver data helpers
Date: Wed, 8 Dec 2021 11:18:33 +0200 [thread overview]
Message-ID: <YbB4aYK4fOESbbMl@unreal> (raw)
In-Reply-To: <YbBwSV2IwDHNUrFH@google.com>
On Wed, Dec 08, 2021 at 08:43:53AM +0000, Lee Jones wrote:
> On Wed, 08 Dec 2021, Greg KH wrote:
>
> > On Wed, Dec 08, 2021 at 09:03:16AM +0200, Leon Romanovsky wrote:
> > > On Tue, Dec 07, 2021 at 09:14:44AM -0800, David E. Box wrote:
> > > > Adds get/set driver data helpers for auxiliary devices.
> > > >
> > > > Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> > > > Reviewed-by: Mark Gross <markgross@kernel.org>
> > > > ---
> > > > V2
> > > > - No changes
> > > >
> > > > include/linux/auxiliary_bus.h | 10 ++++++++++
> > > > 1 file changed, 10 insertions(+)
> > >
> > > I would really like to see an explanation why such obfuscation is really
> > > needed. dev_*_drvdata() is a standard way to access driver data.
>
> I wouldn't call it obfuscation, but it does looks like abstraction for
> the sake of abstraction, which I usually push back on. What are the
> technical benefits over using the dev_*() variant?
You can see it in Greg's answer, there is no technical benefits in any
variant. It is simple copy/paste pattern from other buses.
Maybe it is not clear from my response, I don't care if this patch is
going to be applied or not, but I would like to hear someone explains
to me what are the benefits of such one liners.
Thanks
next prev parent reply other threads:[~2021-12-08 9:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 17:14 [V2 0/6] Auxiliary bus driver support for Intel PCIe VSEC/DVSEC David E. Box
2021-12-07 17:14 ` [V2 1/6] PCI: Add #defines for accessing PCIe DVSEC fields David E. Box
2021-12-07 17:14 ` [V2 2/6] driver core: auxiliary bus: Add driver data helpers David E. Box
2021-12-07 17:35 ` Andy Shevchenko
2021-12-08 7:03 ` Leon Romanovsky
2021-12-08 7:07 ` Greg KH
2021-12-08 8:32 ` Leon Romanovsky
2021-12-08 8:43 ` Greg KH
2021-12-08 9:12 ` Leon Romanovsky
2021-12-08 10:14 ` Andy Shevchenko
2021-12-08 10:48 ` Leon Romanovsky
2021-12-08 8:43 ` Lee Jones
2021-12-08 8:47 ` Greg KH
2021-12-08 9:13 ` Lee Jones
2021-12-08 10:15 ` Andy Shevchenko
2021-12-09 16:32 ` Bjorn Helgaas
2021-12-09 16:54 ` Andy Shevchenko
2021-12-08 9:18 ` Leon Romanovsky [this message]
2021-12-07 17:14 ` [V2 3/6] platform/x86/intel: Move intel_pmt from MFD to Auxiliary Bus David E. Box
2021-12-07 17:14 ` [V2 4/6] platform/x86: Add Intel Software Defined Silicon driver David E. Box
2021-12-08 7:14 ` Leon Romanovsky
2021-12-08 10:42 ` David E. Box
2021-12-08 10:56 ` Leon Romanovsky
2021-12-07 17:14 ` [V2 5/6] sample/sdsi: Sample of SDSi provisiong using sysfs David E. Box
2021-12-07 17:14 ` [V2 6/6] selftests: sdsi: test sysfs setup David E. Box
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbB4aYK4fOESbbMl@unreal \
--to=leon@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=david.e.box@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=srinivas.pandruvada@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).