From: "David E. Box" <david.e.box@linux.intel.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: lee.jones@linaro.org, hdegoede@redhat.com, bhelgaas@google.com,
gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com,
srinivas.pandruvada@intel.com, shuah@kernel.org,
mgross@linux.intel.com, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [V2 4/6] platform/x86: Add Intel Software Defined Silicon driver
Date: Wed, 08 Dec 2021 02:42:42 -0800 [thread overview]
Message-ID: <e4bbeeec741c186090dc3da4fecfab034dde8d0f.camel@linux.intel.com> (raw)
In-Reply-To: <YbBbZ+JMk9eEgNKl@unreal>
On Wed, 2021-12-08 at 09:14 +0200, Leon Romanovsky wrote:
> On Tue, Dec 07, 2021 at 09:14:46AM -0800, David E. Box wrote:
> > Intel Software Defined Silicon (SDSi) is a post manufacturing mechanism for
> > activating additional silicon features. Features are enabled through a
> > license activation process. The SDSi driver provides a per socket, sysfs
> > attribute interface for applications to perform 3 main provisioning
> > functions:
> >
> > 1. Provision an Authentication Key Certificate (AKC), a key written to
> > internal NVRAM that is used to authenticate a capability specific
> > activation payload.
> >
> > 2. Provision a Capability Activation Payload (CAP), a token authenticated
> > using the AKC and applied to the CPU configuration to activate a new
> > feature.
> >
> > 3. Read the SDSi State Certificate, containing the CPU configuration
> > state.
> >
> > The operations perform function specific mailbox commands that forward the
> > requests to SDSi hardware to perform authentication of the payloads and
> > enable the silicon configuration (to be made available after power
> > cycling).
> >
> > The SDSi device itself is enumerated as an auxiliary device from the
> > intel_vsec driver and as such has a build dependency on CONFIG_INTEL_VSEC.
> >
> > Link: https://github.com/intel/intel-sdsi
> > Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> > Reviewed-by: Mark Gross <markgross@kernel.org>
> > ---
> > V2
> > - Use sysfs_emit() in guid_show()
> > - Fix language in ABI, suggested by Bjorn
> > - Fix wrong directory name in ABI doc
>
> <...>
>
> > @@ -0,0 +1,77 @@
> > +What: /sys/bus/auxiliary/devices/intel_vsec.sdsi.X
>
> <...>
>
> > +static const struct auxiliary_device_id sdsi_aux_id_table[] = {
> > + { .name = "intel_vsec.sdsi" },
>
> Are you sure that this sysfs is correct?
>
> Auxiliary bus set device name as a combination of module name plus suffix.
>
> 172 int __auxiliary_device_add(struct auxiliary_device *auxdev, const char
> *modname)
> 173 {
> 174 struct device *dev = &auxdev->dev;
> 175 int ret;
> ....
> 181
> 182 ret = dev_set_name(dev, "%s.%s.%d", modname, auxdev->name,
> auxdev->id);
>
> Thanks
Yes. 'intel_vsec' is the module name, 'sdsi' is the suffix, and 'X' is meant to
indicate the unique id. Will change to '*' instead of 'X'.
Thanks
David
next prev parent reply other threads:[~2021-12-08 10:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 17:14 [V2 0/6] Auxiliary bus driver support for Intel PCIe VSEC/DVSEC David E. Box
2021-12-07 17:14 ` [V2 1/6] PCI: Add #defines for accessing PCIe DVSEC fields David E. Box
2021-12-07 17:14 ` [V2 2/6] driver core: auxiliary bus: Add driver data helpers David E. Box
2021-12-07 17:35 ` Andy Shevchenko
2021-12-08 7:03 ` Leon Romanovsky
2021-12-08 7:07 ` Greg KH
2021-12-08 8:32 ` Leon Romanovsky
2021-12-08 8:43 ` Greg KH
2021-12-08 9:12 ` Leon Romanovsky
2021-12-08 10:14 ` Andy Shevchenko
2021-12-08 10:48 ` Leon Romanovsky
2021-12-08 8:43 ` Lee Jones
2021-12-08 8:47 ` Greg KH
2021-12-08 9:13 ` Lee Jones
2021-12-08 10:15 ` Andy Shevchenko
2021-12-09 16:32 ` Bjorn Helgaas
2021-12-09 16:54 ` Andy Shevchenko
2021-12-08 9:18 ` Leon Romanovsky
2021-12-07 17:14 ` [V2 3/6] platform/x86/intel: Move intel_pmt from MFD to Auxiliary Bus David E. Box
2021-12-07 17:14 ` [V2 4/6] platform/x86: Add Intel Software Defined Silicon driver David E. Box
2021-12-08 7:14 ` Leon Romanovsky
2021-12-08 10:42 ` David E. Box [this message]
2021-12-08 10:56 ` Leon Romanovsky
2021-12-07 17:14 ` [V2 5/6] sample/sdsi: Sample of SDSi provisiong using sysfs David E. Box
2021-12-07 17:14 ` [V2 6/6] selftests: sdsi: test sysfs setup David E. Box
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4bbeeec741c186090dc3da4fecfab034dde8d0f.camel@linux.intel.com \
--to=david.e.box@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=lee.jones@linaro.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=srinivas.pandruvada@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).