linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: dma: pl08x: Fix unevaluatedProperties warnings
@ 2021-12-06 17:42 Rob Herring
  2021-12-07  8:41 ` Thierry Reding
  2021-12-13  6:04 ` Vinod Koul
  0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2021-12-06 17:42 UTC (permalink / raw)
  To: Vinod Koul; +Cc: devicetree, Thierry Reding, dmaengine, linux-kernel

With 'unevaluatedProperties' support implemented, the example has
warnings on primecell properties and 'resets':

Documentation/devicetree/bindings/dma/arm-pl08x.example.dt.yaml: dma-controller@67000000: Unevaluated properties are not allowed ('arm,primecell-periphid', 'resets' were unexpected)

Add the missing reference to primecell.yaml and definition for 'resets'.

Cc: Vinod Koul <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/dma/arm-pl08x.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/dma/arm-pl08x.yaml b/Documentation/devicetree/bindings/dma/arm-pl08x.yaml
index 3bd9eea543ca..9193b18fb75f 100644
--- a/Documentation/devicetree/bindings/dma/arm-pl08x.yaml
+++ b/Documentation/devicetree/bindings/dma/arm-pl08x.yaml
@@ -10,6 +10,7 @@ maintainers:
   - Vinod Koul <vkoul@kernel.org>
 
 allOf:
+  - $ref: /schemas/arm/primecell.yaml#
   - $ref: "dma-controller.yaml#"
 
 # We need a select here so we don't match all nodes with 'arm,primecell'
@@ -89,6 +90,9 @@ properties:
       - 64
     description: bus width used for memcpy in bits. FTDMAC020 also accept 64 bits
 
+  resets:
+    maxItems: 1
+
 required:
   - reg
   - interrupts
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: dma: pl08x: Fix unevaluatedProperties warnings
  2021-12-06 17:42 [PATCH] dt-bindings: dma: pl08x: Fix unevaluatedProperties warnings Rob Herring
@ 2021-12-07  8:41 ` Thierry Reding
  2021-12-13  6:04 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2021-12-07  8:41 UTC (permalink / raw)
  To: Rob Herring; +Cc: Vinod Koul, devicetree, dmaengine, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

On Mon, Dec 06, 2021 at 11:42:31AM -0600, Rob Herring wrote:
> With 'unevaluatedProperties' support implemented, the example has
> warnings on primecell properties and 'resets':
> 
> Documentation/devicetree/bindings/dma/arm-pl08x.example.dt.yaml: dma-controller@67000000: Unevaluated properties are not allowed ('arm,primecell-periphid', 'resets' were unexpected)
> 
> Add the missing reference to primecell.yaml and definition for 'resets'.
> 
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: dmaengine@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/dma/arm-pl08x.yaml | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: dma: pl08x: Fix unevaluatedProperties warnings
  2021-12-06 17:42 [PATCH] dt-bindings: dma: pl08x: Fix unevaluatedProperties warnings Rob Herring
  2021-12-07  8:41 ` Thierry Reding
@ 2021-12-13  6:04 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2021-12-13  6:04 UTC (permalink / raw)
  To: Rob Herring; +Cc: devicetree, Thierry Reding, dmaengine, linux-kernel

On 06-12-21, 11:42, Rob Herring wrote:
> With 'unevaluatedProperties' support implemented, the example has
> warnings on primecell properties and 'resets':
> 
> Documentation/devicetree/bindings/dma/arm-pl08x.example.dt.yaml: dma-controller@67000000: Unevaluated properties are not allowed ('arm,primecell-periphid', 'resets' were unexpected)
> 
> Add the missing reference to primecell.yaml and definition for 'resets'.

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-13  6:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-06 17:42 [PATCH] dt-bindings: dma: pl08x: Fix unevaluatedProperties warnings Rob Herring
2021-12-07  8:41 ` Thierry Reding
2021-12-13  6:04 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).