* [PATCH v2] Bluetooth: hci_qca: Stop IBS timer during BT OFF
@ 2021-12-13 5:31 Panicker Harish
2021-12-13 15:07 ` Matthias Kaehlcke
0 siblings, 1 reply; 3+ messages in thread
From: Panicker Harish @ 2021-12-13 5:31 UTC (permalink / raw)
To: marcel, johan.hedberg
Cc: mka, linux-kernel, linux-bluetooth, quic_hemantg, linux-arm-msm,
quic_bgodavar, rjliao, hbandi, abhishekpandit, mcchou,
quic_saluvala, Panicker Harish
This change stops IBS timers during BT OFF.
Signed-off-by: Panicker Harish <quic_pharish@quicinc.com>
v2:
* Addressed the username
* The full implementation of IBS is based on timers
to that reason I have used timers.
v1: initial patch
---
drivers/bluetooth/hci_qca.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index dd768a8..6f44b26 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -1928,6 +1928,9 @@ static int qca_power_off(struct hci_dev *hdev)
hu->hdev->hw_error = NULL;
hu->hdev->cmd_timeout = NULL;
+ mod_timer(&qca->tx_idle_timer, 0);
+ mod_timer(&qca->wake_retrans_timer, 0);
+
/* Stop sending shutdown command if soc crashes. */
if (soc_type != QCA_ROME
&& qca->memdump_state == QCA_MEMDUMP_IDLE) {
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] Bluetooth: hci_qca: Stop IBS timer during BT OFF
2021-12-13 5:31 [PATCH v2] Bluetooth: hci_qca: Stop IBS timer during BT OFF Panicker Harish
@ 2021-12-13 15:07 ` Matthias Kaehlcke
2021-12-14 11:49 ` PANICKER HARISH (Temp) (QUIC)
0 siblings, 1 reply; 3+ messages in thread
From: Matthias Kaehlcke @ 2021-12-13 15:07 UTC (permalink / raw)
To: Panicker Harish
Cc: marcel, johan.hedberg, linux-kernel, linux-bluetooth,
quic_hemantg, linux-arm-msm, quic_bgodavar, rjliao, hbandi,
abhishekpandit, mcchou, quic_saluvala
On Mon, Dec 13, 2021 at 11:01:36AM +0530, Panicker Harish wrote:
> This change stops IBS timers during BT OFF.
nit: avoid thing like 'this patch ...' in commit messages, you could just
say 'Stop IBS timers while Bluetooth is off.
> Signed-off-by: Panicker Harish <quic_pharish@quicinc.com>
Looks like this should have a ´Fixes' tag to make sure it lands in the
relevant -stable trees. Commit 3e4be65eb82c ("Bluetooth: hci_qca: Add
poweroff support during hci down for wcn3990") would probably be a
suitable commit for that.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH v2] Bluetooth: hci_qca: Stop IBS timer during BT OFF
2021-12-13 15:07 ` Matthias Kaehlcke
@ 2021-12-14 11:49 ` PANICKER HARISH (Temp) (QUIC)
0 siblings, 0 replies; 3+ messages in thread
From: PANICKER HARISH (Temp) (QUIC) @ 2021-12-14 11:49 UTC (permalink / raw)
To: Matthias Kaehlcke, PANICKER HARISH (Temp) (QUIC)
Cc: marcel, johan.hedberg, linux-kernel, linux-bluetooth,
Hemant Gupta (QUIC),
linux-arm-msm, quic_bgodavar, rjliao, hbandi, abhishekpandit,
mcchou, Sai Teja Aluvala (Temp) (QUIC)
-----Original Message-----
From: Matthias Kaehlcke <mka@chromium.org>
Sent: Monday, December 13, 2021 8:37 PM
To: PANICKER HARISH (Temp) (QUIC) <quic_pharish@quicinc.com>
Cc: marcel@holtmann.org; johan.hedberg@gmail.com; linux-kernel@vger.kernel.org; linux-bluetooth@vger.kernel.org; Hemant Gupta (QUIC) <quic_hemantg@quicinc.com>; linux-arm-msm@vger.kernel.org; quic_bgodavar <quic_bgodavar@quicinc.com>; rjliao@codeaurora.org; hbandi@codeaurora.org; abhishekpandit@chromium.org; mcchou@chromium.org; Sai Teja Aluvala (Temp) (QUIC) <quic_saluvala@quicinc.com>
Subject: Re: [PATCH v2] Bluetooth: hci_qca: Stop IBS timer during BT OFF
On Mon, Dec 13, 2021 at 11:01:36AM +0530, Panicker Harish wrote:
> This change stops IBS timers during BT OFF.
nit: avoid thing like 'this patch ...' in commit messages, you could just say 'Stop IBS timers while Bluetooth is off.
[Harish] : I will update
> Signed-off-by: Panicker Harish <quic_pharish@quicinc.com>
Looks like this should have a ´Fixes' tag to make sure it lands in the relevant -stable trees. Commit 3e4be65eb82c ("Bluetooth: hci_qca: Add poweroff support during hci down for wcn3990") would probably be a suitable commit for that.
[Harish] : I will update with Fixes tag.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-14 11:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-13 5:31 [PATCH v2] Bluetooth: hci_qca: Stop IBS timer during BT OFF Panicker Harish
2021-12-13 15:07 ` Matthias Kaehlcke
2021-12-14 11:49 ` PANICKER HARISH (Temp) (QUIC)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).