* [PATCH] mmc: mmci: add st,stm32-sdmmc2 compatible
@ 2021-12-10 9:18 Yann Gautier
2021-12-10 20:12 ` Linus Walleij
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Yann Gautier @ 2021-12-10 9:18 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Linus Walleij, linux-mmc, devicetree,
linux-kernel, loic.pallardy
Cc: yann.gautier
Although this compatible is not used in kernel, as we use the common
MMCI driver, it is used by bootloaders. The U-Boot driver was merged
before the kernel driver and uses this compatible.
To avoid issues when aligning device tree files between kernel and
boot loader, the ST dedicated compatible is added to bindings file.
Signed-off-by: Yann Gautier <yann.gautier@foss.st.com>
---
Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
index 47595cb483be..eed54bee7665 100644
--- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
+++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
@@ -53,6 +53,12 @@ properties:
items:
- const: arm,pl18x
- const: arm,primecell
+ - description: Entry for STMicroelectronics variant of PL18x.
+ This dedicated compatible is used by bootloaders.
+ items:
+ - const: st,stm32-sdmmc2
+ - const: arm,pl18x
+ - const: arm,primecell
clocks:
description: One or two clocks, the "apb_pclk" and the "MCLK"
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: mmci: add st,stm32-sdmmc2 compatible
2021-12-10 9:18 [PATCH] mmc: mmci: add st,stm32-sdmmc2 compatible Yann Gautier
@ 2021-12-10 20:12 ` Linus Walleij
2021-12-15 19:53 ` Rob Herring
2021-12-21 13:02 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2021-12-10 20:12 UTC (permalink / raw)
To: Yann Gautier
Cc: Ulf Hansson, Rob Herring, linux-mmc, devicetree, linux-kernel,
loic.pallardy
On Fri, Dec 10, 2021 at 10:19 AM Yann Gautier <yann.gautier@foss.st.com> wrote:
> Although this compatible is not used in kernel, as we use the common
> MMCI driver, it is used by bootloaders. The U-Boot driver was merged
> before the kernel driver and uses this compatible.
> To avoid issues when aligning device tree files between kernel and
> boot loader, the ST dedicated compatible is added to bindings file.
>
> Signed-off-by: Yann Gautier <yann.gautier@foss.st.com>
Why not
Acked-by: Linus Walleij <linus.walleij@linaro.org>
> + - description: Entry for STMicroelectronics variant of PL18x.
> + This dedicated compatible is used by bootloaders.
> + items:
> + - const: st,stm32-sdmmc2
> + - const: arm,pl18x
> + - const: arm,primecell
You *could* mark it deprecated if it's not supposed to be used.
But no strong opinion.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: mmci: add st,stm32-sdmmc2 compatible
2021-12-10 9:18 [PATCH] mmc: mmci: add st,stm32-sdmmc2 compatible Yann Gautier
2021-12-10 20:12 ` Linus Walleij
@ 2021-12-15 19:53 ` Rob Herring
2021-12-21 13:02 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2021-12-15 19:53 UTC (permalink / raw)
To: Yann Gautier
Cc: Rob Herring, linux-mmc, linux-kernel, loic.pallardy,
Linus Walleij, Ulf Hansson, devicetree
On Fri, 10 Dec 2021 10:18:34 +0100, Yann Gautier wrote:
> Although this compatible is not used in kernel, as we use the common
> MMCI driver, it is used by bootloaders. The U-Boot driver was merged
> before the kernel driver and uses this compatible.
> To avoid issues when aligning device tree files between kernel and
> boot loader, the ST dedicated compatible is added to bindings file.
>
> Signed-off-by: Yann Gautier <yann.gautier@foss.st.com>
> ---
> Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: mmci: add st,stm32-sdmmc2 compatible
2021-12-10 9:18 [PATCH] mmc: mmci: add st,stm32-sdmmc2 compatible Yann Gautier
2021-12-10 20:12 ` Linus Walleij
2021-12-15 19:53 ` Rob Herring
@ 2021-12-21 13:02 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2021-12-21 13:02 UTC (permalink / raw)
To: Yann Gautier
Cc: Rob Herring, Linus Walleij, linux-mmc, devicetree, linux-kernel,
loic.pallardy
On Fri, 10 Dec 2021 at 10:19, Yann Gautier <yann.gautier@foss.st.com> wrote:
>
> Although this compatible is not used in kernel, as we use the common
> MMCI driver, it is used by bootloaders. The U-Boot driver was merged
> before the kernel driver and uses this compatible.
> To avoid issues when aligning device tree files between kernel and
> boot loader, the ST dedicated compatible is added to bindings file.
>
> Signed-off-by: Yann Gautier <yann.gautier@foss.st.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> index 47595cb483be..eed54bee7665 100644
> --- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> @@ -53,6 +53,12 @@ properties:
> items:
> - const: arm,pl18x
> - const: arm,primecell
> + - description: Entry for STMicroelectronics variant of PL18x.
> + This dedicated compatible is used by bootloaders.
> + items:
> + - const: st,stm32-sdmmc2
> + - const: arm,pl18x
> + - const: arm,primecell
>
> clocks:
> description: One or two clocks, the "apb_pclk" and the "MCLK"
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-21 13:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-10 9:18 [PATCH] mmc: mmci: add st,stm32-sdmmc2 compatible Yann Gautier
2021-12-10 20:12 ` Linus Walleij
2021-12-15 19:53 ` Rob Herring
2021-12-21 13:02 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).