* [PATCH] virtio: fix spelling error
@ 2021-12-16 3:08 zhuxinran
2021-12-16 3:17 ` Jason Wang
2021-12-16 3:18 ` asmadeus
0 siblings, 2 replies; 3+ messages in thread
From: zhuxinran @ 2021-12-16 3:08 UTC (permalink / raw)
To: ericvh, lucho, asmadeus, davem, kuba
Cc: v9fs-developer, linux-kernel, zhuxinran
start my first kernel patch commit
Signed-off-by: zhuxinran <zhuran@mail.ustc.edu.cn>
---
net/9p/trans_virtio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c
index bd5a89c4960d..f7dc561ca516 100644
--- a/net/9p/trans_virtio.c
+++ b/net/9p/trans_virtio.c
@@ -648,7 +648,7 @@ static int p9_virtio_probe(struct virtio_device *vdev)
* @args: args passed from sys_mount() for per-transport options (unused)
*
* This sets up a transport channel for 9p communication. Right now
- * we only match the first available channel, but eventually we couldlook up
+ * we only match the first available channel, but eventually we could look up
* alternate channels by matching devname versus a virtio_config entry.
* We use a simple reference count mechanism to ensure that only a single
* mount has a channel open at a time.
--
2.33.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] virtio: fix spelling error
2021-12-16 3:08 [PATCH] virtio: fix spelling error zhuxinran
@ 2021-12-16 3:17 ` Jason Wang
2021-12-16 3:18 ` asmadeus
1 sibling, 0 replies; 3+ messages in thread
From: Jason Wang @ 2021-12-16 3:17 UTC (permalink / raw)
To: zhuxinran
Cc: ericvh, lucho, asmadeus, davem, Jakub Kicinski, v9fs-developer,
linux-kernel
On Thu, Dec 16, 2021 at 11:09 AM zhuxinran <zhuran@mail.ustc.edu.cn> wrote:
>
> start my first kernel patch commit
>
Patch looks good but this is not a good change log.
It should be something like "Fix typo in the comment for p9_virtio_create()"
Thanks
> Signed-off-by: zhuxinran <zhuran@mail.ustc.edu.cn>
> ---
> net/9p/trans_virtio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c
> index bd5a89c4960d..f7dc561ca516 100644
> --- a/net/9p/trans_virtio.c
> +++ b/net/9p/trans_virtio.c
> @@ -648,7 +648,7 @@ static int p9_virtio_probe(struct virtio_device *vdev)
> * @args: args passed from sys_mount() for per-transport options (unused)
> *
> * This sets up a transport channel for 9p communication. Right now
> - * we only match the first available channel, but eventually we couldlook up
> + * we only match the first available channel, but eventually we could look up
> * alternate channels by matching devname versus a virtio_config entry.
> * We use a simple reference count mechanism to ensure that only a single
> * mount has a channel open at a time.
> --
> 2.33.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] virtio: fix spelling error
2021-12-16 3:08 [PATCH] virtio: fix spelling error zhuxinran
2021-12-16 3:17 ` Jason Wang
@ 2021-12-16 3:18 ` asmadeus
1 sibling, 0 replies; 3+ messages in thread
From: asmadeus @ 2021-12-16 3:18 UTC (permalink / raw)
To: zhuxinran; +Cc: ericvh, lucho, davem, kuba, v9fs-developer, linux-kernel
Thanks for the patch.
A few comments below:
zhuxinran wrote on Thu, Dec 16, 2021 at 11:08:36AM +0800:
> Subject: virtio: fix spelling error
"virtio" is much more than this.
Have a look at previous commit messages for this file, something like
'9p/trans_virtio' would make a better component name.
(`git log net/9p/trans_virtio.c` to get git history for a single file)
> start my first kernel patch commit
This is not particularly useful for someone reading the git log, I'd
just remove this line.
I can do both changes on my end, but since you're learning it can also
be a good time to also see how to send a v2 (setting subject as [PATCH
v2], sending patch with in-reply-to)
I don't really mind either way, please let me know if you won't resend.
--
Dominique
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-16 3:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-16 3:08 [PATCH] virtio: fix spelling error zhuxinran
2021-12-16 3:17 ` Jason Wang
2021-12-16 3:18 ` asmadeus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).