* [PATCH] usb: uhci: Use platform_get_irq() to get the interrupt
@ 2021-12-15 22:52 Rob Herring
2021-12-16 16:10 ` Alan Stern
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2021-12-15 22:52 UTC (permalink / raw)
To: Alan Stern, Greg Kroah-Hartman
Cc: Lad Prabhakar, linux-arm-kernel, linux-usb, linux-kernel
Accessing platform device resources directly has long been deprecated for
DT as IRQ resources may not be available at device creation time. Drivers
continuing to use static IRQ resources is blocking removing the static setup
from the DT core code.
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/usb/host/uhci-platform.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/uhci-platform.c b/drivers/usb/host/uhci-platform.c
index 70dbd95c3f06..b854699e9e4e 100644
--- a/drivers/usb/host/uhci-platform.c
+++ b/drivers/usb/host/uhci-platform.c
@@ -132,7 +132,11 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev)
goto err_rmr;
}
- ret = usb_add_hcd(hcd, pdev->resource[1].start, IRQF_SHARED);
+ ret = platform_get_irq(pdev, 0);
+ if (ret < 0)
+ goto err_clk;
+
+ ret = usb_add_hcd(hcd, ret, IRQF_SHARED);
if (ret)
goto err_clk;
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: uhci: Use platform_get_irq() to get the interrupt
2021-12-15 22:52 [PATCH] usb: uhci: Use platform_get_irq() to get the interrupt Rob Herring
@ 2021-12-16 16:10 ` Alan Stern
0 siblings, 0 replies; 2+ messages in thread
From: Alan Stern @ 2021-12-16 16:10 UTC (permalink / raw)
To: Rob Herring
Cc: Greg Kroah-Hartman, Lad Prabhakar, linux-arm-kernel, linux-usb,
linux-kernel
On Wed, Dec 15, 2021 at 04:52:03PM -0600, Rob Herring wrote:
> Accessing platform device resources directly has long been deprecated for
> DT as IRQ resources may not be available at device creation time. Drivers
> continuing to use static IRQ resources is blocking removing the static setup
> from the DT core code.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
Acked-by: Alan Stern <stern@rowland.harvard.edu>
> drivers/usb/host/uhci-platform.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/uhci-platform.c b/drivers/usb/host/uhci-platform.c
> index 70dbd95c3f06..b854699e9e4e 100644
> --- a/drivers/usb/host/uhci-platform.c
> +++ b/drivers/usb/host/uhci-platform.c
> @@ -132,7 +132,11 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev)
> goto err_rmr;
> }
>
> - ret = usb_add_hcd(hcd, pdev->resource[1].start, IRQF_SHARED);
> + ret = platform_get_irq(pdev, 0);
> + if (ret < 0)
> + goto err_clk;
> +
> + ret = usb_add_hcd(hcd, ret, IRQF_SHARED);
> if (ret)
> goto err_clk;
>
> --
> 2.32.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-16 16:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-15 22:52 [PATCH] usb: uhci: Use platform_get_irq() to get the interrupt Rob Herring
2021-12-16 16:10 ` Alan Stern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).