* [PATCH] ARM: OMAP2+: hwmod: Add of_node_put() before break
@ 2021-10-14 8:57 Wan Jiabing
2021-12-17 12:14 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Wan Jiabing @ 2021-10-14 8:57 UTC (permalink / raw)
To: Benoît Cousson, Paul Walmsley, Tony Lindgren, Russell King,
linux-omap, linux-arm-kernel, linux-kernel
Cc: kael_w, Wan Jiabing
Fix following coccicheck warning:
./arch/arm/mach-omap2/omap_hwmod.c:753:1-23: WARNING: Function
for_each_matching_node should have of_node_put() before break
Early exits from for_each_matching_node should decrement the
node reference counter.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
arch/arm/mach-omap2/omap_hwmod.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
index ccb0e3732c0d..31d1a21f6041 100644
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -752,8 +752,10 @@ static int __init _init_clkctrl_providers(void)
for_each_matching_node(np, ti_clkctrl_match_table) {
ret = _setup_clkctrl_provider(np);
- if (ret)
+ if (ret) {
+ of_node_put(np);
break;
+ }
}
return ret;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: OMAP2+: hwmod: Add of_node_put() before break
2021-10-14 8:57 [PATCH] ARM: OMAP2+: hwmod: Add of_node_put() before break Wan Jiabing
@ 2021-12-17 12:14 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2021-12-17 12:14 UTC (permalink / raw)
To: Wan Jiabing
Cc: Benoît Cousson, Paul Walmsley, Russell King, linux-omap,
linux-arm-kernel, linux-kernel, kael_w
* Wan Jiabing <wanjiabing@vivo.com> [211014 11:58]:
> Fix following coccicheck warning:
> ./arch/arm/mach-omap2/omap_hwmod.c:753:1-23: WARNING: Function
> for_each_matching_node should have of_node_put() before break
>
> Early exits from for_each_matching_node should decrement the
> node reference counter.
Thanks adding into omap-for-v5.17/fixes-not-urgent.
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-17 12:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-14 8:57 [PATCH] ARM: OMAP2+: hwmod: Add of_node_put() before break Wan Jiabing
2021-12-17 12:14 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).